Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w69Uc-0040TA-1W for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Mar 2026 15:53:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w69Ua-00AajY-2A for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Mar 2026 15:53:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w69Ua-00AajQ-1D for pgsql-hackers@lists.postgresql.org; Fri, 27 Mar 2026 15:53:00 +0000 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w69UZ-00000001LGT-0Irv for pgsql-hackers@postgresql.org; Fri, 27 Mar 2026 15:52:59 +0000 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.stl.internal (Postfix) with ESMTP id 1F2787A017D; Fri, 27 Mar 2026 11:52:58 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Fri, 27 Mar 2026 11:52:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1774626777; x=1774713177; bh=NhAQrqKJbcYp2go9nM1DTor6IJZtg7fD jQYj8gfhOoE=; b=iyQ9/SEwPiLBa2V2EHW0IS7vbAqkYnUuypBe+cbG44SyM6gz X8jMD6YVMCUhmSiaThqJ0c/JMBoSxwxxTbUG4moAU3VczpI7mOFDLz/EGK1lLCoh ZMK9yWFiksWDGKrMGt69YseV45Bm34XPj8/AqeLLVWm+Xe4Qpnlp3yYkFzDQcVZ1 Fct5KVmZODYyvBKvFZEk2Z+zfcgLIoWnyo5CjtY3R4JeB0pryrRQsQwqGROODcj4 IvXoTg3gWGIlyzfponSht3QnMESK+HLVmauCMFLl/xhWNe+u8fyVsZADmP829rr9 Z4xl+F/RqUGNOKTUyVm/FL0yIMys0MqyQSaJfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1774626777; x= 1774713177; bh=NhAQrqKJbcYp2go9nM1DTor6IJZtg7fDjQYj8gfhOoE=; b=T P/rG41cwLaJk9F5W+MDrG6W6JQ94yT2Vou5Xh/+UEZJHhJHY5XfkEppjUNiMq5Mc H3X4qO5nzkQzu1O+VFt73I9gp4x7wWB4UCsI/RdC3UqMq//0aH9ZiFb1F/8q0RlD TNmO0+jZQgq1X4WWp9Cv6SGWXF6Fw3xzG2wn5ze1fG1X34JuyVFWK9SyA0xz2rko NoEQh9AnmsZka93jHj8RNa2Vdb2ESASE8gxNHmDrbp5y52+k9ozD1VBSqVQEWH/p r0IDijUWbRV/BdzmQy7zbLmqXazGC9zjVWW6cFqqpAi2ma0o5p4YvILg0EVVcv1n xi1Ymx6WQiqSCMg+FNGCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeffedtieelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileehteeljeeghfeuledthfeutedv ffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhnsggprhgtphhtthho peeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjihgrnhdruhhnihhvvghrsh grlhhithihsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghnughrvgifseguuhhnshhl rghnvgdrnhgvthdprhgtphhtthhopegurghvihgurdhgrdhjohhhnhhsthhonhesghhmrg hilhdrtghomhdprhgtphhtthhopehmrghrtghoshesfhdutddrtghomhdrsghrpdhrtghp thhtohepphhgshhqlhdqhhgrtghkvghrshesphhoshhtghhrvghsqhhlrdhorhhgpdhrtg hpthhtohepthhglhesshhsshdrphhghhdrphgrrdhush X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Mar 2026 11:52:56 -0400 (EDT) Message-ID: Date: Fri, 27 Mar 2026 16:52:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: add function argument name to substring and substr To: jian he Cc: Andrew Dunstan , "David G. Johnston" , Marcos Pegoraro , PostgreSQL-development , Tom Lane References: <243365.1760371856@sss.pgh.pa.us> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 31.12.25 08:47, jian he wrote: > rebased, and rechecked it again. > > seems no changes to the citext extension are required, since the citext data > type does not define specialized substring/substr function. I don't really see the point of this. These are standardized functions, and people should be using them in the standardized ways. By adding parameter names, we are opening up the use of these in nonstandard and unportable ways. I don't think the arguments of these functions are terribly confusing that use of named parameters adds much value. At least I didn't see this argument being made. Furthermore, if we somehow decided to do this, let's not do it four functions at a time but have a general plan about whether, why, and how to add parameter names to built-in/standard functions.