Subject: Re: Add .editorconfig
To: Daniel Gustafsson <daniel@yesql.se>
References: <273cb788-bbb2-ff34-ad6f-5192b44e5049@2ndquadrant.com>
 <BCBA36BB-7969-478A-8267-0BA75249AAC9@yesql.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <c926ec2a-cf4b-933a-8471-d08e77ddd689@2ndquadrant.com>
Date: Wed, 11 Dec 2019 17:28:09 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <BCBA36BB-7969-478A-8267-0BA75249AAC9@yesql.se>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-12-11 17:09, Daniel Gustafsson wrote:
>> On 11 Dec 2019, at 17:00, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> There were a couple of recent threads that wanted to add an .editorconfig file but never actually ended up doing so.[0][1]  Here is a patch.  It is meant to match more or less what's in .dir-locals.el.
> 
> +[*.{c,h,l,y,pl,pm}]
> 
> What about *.sh?
> 
> Not that there is much of Python in the tree, but shouldn't those also be
> covered if we do this?
> 
> [*.py]
> indent_style = space
> indent_size = 4

Those were not in the Emacs config either.

I'd be inclined to leave the Python stuff alone, in particular.  The 
PEP-8 style appears to be universally accepted as the default, so we 
don't need to specify it here.  We only need to specify what's different 
or where no sensible default exists.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services