From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: btree_gin and btree_gist for enums
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <56EA8A71.8060107@dunslane.net> <56EACB8C.1040406@dunslane.net>
 <CAE2gYzyB=vyquQ2hEWA9UwNb=zYAKFsNO5vBtbfkV2=PzoPZjg@mail.gmail.com>
 <03f7d748-0f89-e8e1-094d-f04e1026b93d@dunslane.net>
 <27220.1478360811@sss.pgh.pa.us>
 <e60f50c4-899a-d48a-6cb4-4611acf2f73c@dunslane.net>
 <31412.1478366009@sss.pgh.pa.us>
 <60fb708c-8b3c-1337-934e-c1bfe2afc539@dunslane.net>
 <db2b70a4-78d7-294a-a315-8e7f506c5978@2ndQuadrant.com>
 <8258.1487886101@sss.pgh.pa.us>
 <4376a7bf-ab8c-e640-9021-94b148f9d733@2ndQuadrant.com>
 <6704.1487952174@sss.pgh.pa.us>
 <930cb563-6dc6-c4af-3be9-31f06c60361e@2ndQuadrant.com>
 <8a8c60b4-39c0-69a4-824c-e364f5fd97ea@2ndQuadrant.com>
 <fac3c5d1-ad66-3a15-c181-c7aadf1d6ad1@2ndQuadrant.com>
 <12734.1488042261@sss.pgh.pa.us>
 <4e730f28-742b-45e9-d507-4d292fbd7834@2ndQuadrant.com>
 <22791.1488047671@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Message-ID: <c934ffff-c062-39d8-25a0-7157a3ecff49@2ndQuadrant.com>
Date: Sat, 25 Feb 2017 13:39:31 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <22791.1488047671@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 02/25/2017 01:34 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 02/25/2017 12:04 PM, Tom Lane wrote:
>>> I think it'd be better to leave DirectFunctionCallN alone and just invent
>>> a small number of CallerFInfoFunctionCallN support functions (maybe N=1
>>> and N=2 would be enough, at least for now).
>> See attached.
> Yeah, I like this better, except that instead of
>
> + * The callee should not look at anything except the fn_mcxt and fn_extra.
> + * Anything else is likely to be bogus.
>
> maybe
>
> + * It's recommended that the callee only use the fn_extra and fn_mcxt
> + * fields, as other fields will typically describe the calling function
> + * not the callee.  Conversely, the calling function should not have
> + * used fn_extra, unless its use is known compatible with the callee's.
>
> 			


OK, Works for me. Thanks.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers