Message-ID: <c978f4127cf30280fdee877c3e6e5cfaa26e11af.camel@j-davis.com>
Subject: Re: Comments on Custom RMGRs
From: Jeff Davis <pgsql@j-davis.com>
To: Danil Anisimow <anisimow.d@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers
	 <pgsql-hackers@postgresql.org>
Date: Thu, 21 Mar 2024 12:07:38 -0700
In-Reply-To: <CABm2Ma6avU5hkk7dd+G2oRNJZJtLOT=Yzeq6fb0v2rf7_YYp7g@mail.gmail.com>
References: 
	<CANbhV-E4pTWeF-DsdaGsOrjJNFWPaR+Dstjrnkqvf9JFFgOKKQ@mail.gmail.com>
	 <f781f8f198567cee9e3776487bab3e41a7b91b82.camel@j-davis.com>
	 <20220512034010.4oqa76pasrulkw32@alap3.anarazel.de>
	 <CANbhV-G7SfdRLR6r7sxY0uL=TRU0S=cxkWJGWyTdss3u8LFK=g@mail.gmail.com>
	 <20220512234207.pwwp6q33f72byet2@alap3.anarazel.de>
	 <CANbhV-FFgAFeNZ=qNc7Fr991Asym+sfj=R5hb02XeRE6067=hg@mail.gmail.com>
	 <CABm2Ma7v4=W-1vH=kiA4M352F=Nd-Nvd_QBZufJ6EMGsS7Q-_A@mail.gmail.com>
	 <0892cd00635c8bcd458de6d43d31cf61953da1b2.camel@j-davis.com>
	 <CABm2Ma5Hi9PU_wWP0f=YFu9aDDdeSdX2+JFDL_oDH-QHgexsgg@mail.gmail.com>
	 <727b0f3b48aec2a4f968bf11c6fa8ca6382b6cca.camel@j-davis.com>
	 <CABm2Ma6avU5hkk7dd+G2oRNJZJtLOT=Yzeq6fb0v2rf7_YYp7g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/c978f4127cf30280fdee877c3e6e5cfaa26e11af.camel%40j-davis.com>
Precedence: bulk

On Thu, 2024-03-21 at 19:47 +0700, Danil Anisimow wrote:
> The proposed patch is not a complete solution for pgss and may not
> work correctly with replication.

Also, what is the desired behavior during replication? Should queries
on the primary be represented in pgss on the replica? If the answer is
yes, should they be differentiated somehow so that you can know where
the slow queries are running?

Regards,
	Jeff Davis