Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5rMl-0004uR-Lf for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 15:09:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5rMk-0005Kd-AJ for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 15:09:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5rMj-0005KT-UK for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 15:09:02 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5rMg-0005Tg-Je for pgsql-hackers@postgresql.org; Tue, 20 Jul 2021 15:09:00 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A64F23200942 for ; Tue, 20 Jul 2021 11:08:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 20 Jul 2021 11:08:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zJ6Fj2 cJJwCXZpVydd5ZmzS5y1EEPLjPXfS33omk5P4=; b=O9o2hSqjTbTjrbcNoQCGZD sOzK7qJeSLPFM/kK9LmQtkZS3eHSuh0blnSCXIWNUPZU+uIB2MXbpijQDeKNRfPT +Uc6/JUaP1ZWAtSWk+R5arrrTchA0ZokKLePM8+LTbER3ZAgleiL/1Wak3RiRFkk ay/eyWp1e3dG8UsB1CA8RhhsJUcX3NCVabbzZBlk7Qj+YSmeOA7Wtftg4KunF23p 3XA1IUXpdpxjHJE4W9Fb240VIfj4nznyZTzarrc7VEIKTJze2e2/UCvTLuw9bq5C HTfDr7UJn1RD+rvYjaiJsTomD6k3oXiOCbVWQ/ZXXf4UuZfJZWMi29ENS0bEHteQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfedvgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffhfhfvkffffgggjggtsehmtderre dtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgv ihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtth gvrhhnpeffvddvfeeiuddttefhheejfeehffeijeduvddvleehjefhkeekjeeuheeuieeh jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvg htvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 20 Jul 2021 11:08:54 -0400 (EDT) Subject: Re: wrong relkind error messages From: Peter Eisentraut References: <202107021610.fv2n3ehw4yu7@alvherre.pgsql> <08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com> To: pgsql-hackers Message-ID: Date: Tue, 20 Jul 2021 17:08:53 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com> Content-Type: multipart/mixed; boundary="------------817EE8C28E481DD39AB91234" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------817EE8C28E481DD39AB91234 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit While reviewing the logical decoding of sequences patch, I found a few more places that could be updated in the new style introduced by this thread. See attached patch. --------------817EE8C28E481DD39AB91234 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-More-improvements-of-error-messages-about-mismatchin.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-More-improvements-of-error-messages-about-mismatchin.pa"; filename*1="tch" RnJvbSA5MmEwNmViZmE2Zjg1NjI0NmMyNjQyYTRlNDVjNWIyYWY2OWE5MTFkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogVHVlLCAyMCBKdWwgMjAyMSAxNjoyODo0NCArMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIE1vcmUgaW1wcm92ZW1lbnRzIG9mIGVycm9yIG1lc3NhZ2VzIGFib3V0IG1p c21hdGNoaW5nIHJlbGtpbmQKCkZvbGxvdy11cCB0byAyZWQ1MzJlZThjNDc0ZTk3NjdlNzZl MWYzMjUxY2MzYTAyMjQzNThjLCBhIGZldyBlcnJvcgptZXNzYWdlcyBpbiB0aGUgbG9naWNh bCByZXBsaWNhdGlvbiBhcmVhIGN1cnJlbnRseSBvbmx5IGRlYWwgd2l0aAp0YWJsZXMsIGJ1 dCBpZiB3ZSdyZSBhbnRpY2lwYXRpbmcgbW9yZSByZWxraW5kcyBzdWNoIGFzIHNlcXVlbmNl cwpiZWluZyBoYW5kbGVkLCB0aGVuIHRoZXNlIG1lc3NhZ2VzIGFsc28gZmFsbCBpbnRvIHRo ZSBjYXRlZ29yeQphZmZlY3RlZCBieSB0aGUgcHJldmlvdXMgcGF0Y2gsIHNvIGFkanVzdCB0 aGVtIHRvby4KLS0tCiBzcmMvYmFja2VuZC9jYXRhbG9nL3BnX3B1YmxpY2F0aW9uLmMgICAg ICB8IDEwICsrKysrLS0tLS0KIHNyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNSZXBsaWNhdGlv bi5jICAgIHwgMTQgKy0tLS0tLS0tLS0tLS0KIHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQv cHVibGljYXRpb24ub3V0IHwgIDggKysrKy0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQv Y2F0YWxvZy9wZ19wdWJsaWNhdGlvbi5jIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9wZ19wdWJs aWNhdGlvbi5jCmluZGV4IDM2YmZmZjk3MDYuLjJhMmZlMDNjMTMgMTAwNjQ0Ci0tLSBhL3Ny Yy9iYWNrZW5kL2NhdGFsb2cvcGdfcHVibGljYXRpb24uYworKysgYi9zcmMvYmFja2VuZC9j YXRhbG9nL3BnX3B1YmxpY2F0aW9uLmMKQEAgLTU0LDIzICs1NCwyMyBAQCBjaGVja19wdWJs aWNhdGlvbl9hZGRfcmVsYXRpb24oUmVsYXRpb24gdGFyZ2V0cmVsKQogCQlSZWxhdGlvbkdl dEZvcm0odGFyZ2V0cmVsKS0+cmVsa2luZCAhPSBSRUxLSU5EX1BBUlRJVElPTkVEX1RBQkxF KQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9QQVJB TUVURVJfVkFMVUUpLAotCQkJCSBlcnJtc2coIlwiJXNcIiBpcyBub3QgYSB0YWJsZSIsCisJ CQkJIGVycm1zZygiY2Fubm90IGFkZCByZWxhdGlvbiBcIiVzXCIgdG8gcHVibGljYXRpb24i LAogCQkJCQkJUmVsYXRpb25HZXRSZWxhdGlvbk5hbWUodGFyZ2V0cmVsKSksCi0JCQkJIGVy cmRldGFpbCgiT25seSB0YWJsZXMgY2FuIGJlIGFkZGVkIHRvIHB1YmxpY2F0aW9ucy4iKSkp OworCQkJCSBlcnJkZXRhaWxfcmVsa2luZF9ub3Rfc3VwcG9ydGVkKFJlbGF0aW9uR2V0Rm9y bSh0YXJnZXRyZWwpLT5yZWxraW5kKSkpOwogCiAJLyogQ2FuJ3QgYmUgc3lzdGVtIHRhYmxl ICovCiAJaWYgKElzQ2F0YWxvZ1JlbGF0aW9uKHRhcmdldHJlbCkpCiAJCWVyZXBvcnQoRVJS T1IsCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9JTlZBTElEX1BBUkFNRVRFUl9WQUxVRSksCi0J CQkJIGVycm1zZygiXCIlc1wiIGlzIGEgc3lzdGVtIHRhYmxlIiwKKwkJCQkgZXJybXNnKCJj YW5ub3QgYWRkIHJlbGF0aW9uIFwiJXNcIiB0byBwdWJsaWNhdGlvbiIsCiAJCQkJCQlSZWxh dGlvbkdldFJlbGF0aW9uTmFtZSh0YXJnZXRyZWwpKSwKLQkJCQkgZXJyZGV0YWlsKCJTeXN0 ZW0gdGFibGVzIGNhbm5vdCBiZSBhZGRlZCB0byBwdWJsaWNhdGlvbnMuIikpKTsKKwkJCQkg ZXJyZGV0YWlsKCJUaGlzIG9wZXJhdGlvbiBpcyBub3Qgc3VwcG9ydGVkIGZvciBzeXN0ZW0g dGFibGVzLiIpKSk7CiAKIAkvKiBVTkxPR0dFRCBhbmQgVEVNUCByZWxhdGlvbnMgY2Fubm90 IGJlIHBhcnQgb2YgcHVibGljYXRpb24uICovCiAJaWYgKCFSZWxhdGlvbklzUGVybWFuZW50 KHRhcmdldHJlbCkpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9J TlZBTElEX1BBUkFNRVRFUl9WQUxVRSksCi0JCQkJIGVycm1zZygidGFibGUgXCIlc1wiIGNh bm5vdCBiZSByZXBsaWNhdGVkIiwKKwkJCQkgZXJybXNnKCJjYW5ub3QgYWRkIHJlbGF0aW9u IFwiJXNcIiB0byBwdWJsaWNhdGlvbiIsCiAJCQkJCQlSZWxhdGlvbkdldFJlbGF0aW9uTmFt ZSh0YXJnZXRyZWwpKSwKIAkJCQkgZXJyZGV0YWlsKCJUZW1wb3JhcnkgYW5kIHVubG9nZ2Vk IHJlbGF0aW9ucyBjYW5ub3QgYmUgcmVwbGljYXRlZC4iKSkpOwogfQpkaWZmIC0tZ2l0IGEv c3JjL2JhY2tlbmQvZXhlY3V0b3IvZXhlY1JlcGxpY2F0aW9uLmMgYi9zcmMvYmFja2VuZC9l eGVjdXRvci9leGVjUmVwbGljYXRpb24uYwppbmRleCAxZTI4NWUwMzQ5Li41NzRkN2QyN2Zk IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9leGVjdXRvci9leGVjUmVwbGljYXRpb24uYwor KysgYi9zcmMvYmFja2VuZC9leGVjdXRvci9leGVjUmVwbGljYXRpb24uYwpAQCAtNjA4LDIy ICs2MDgsMTAgQEAgdm9pZAogQ2hlY2tTdWJzY3JpcHRpb25SZWxraW5kKGNoYXIgcmVsa2lu ZCwgY29uc3QgY2hhciAqbnNwbmFtZSwKIAkJCQkJCSBjb25zdCBjaGFyICpyZWxuYW1lKQog ewotCS8qCi0JICogR2l2ZSBhIG1vcmUgc3BlY2lmaWMgZXJyb3IgZm9yIGZvcmVpZ24gdGFi bGVzLgotCSAqLwotCWlmIChyZWxraW5kID09IFJFTEtJTkRfRk9SRUlHTl9UQUJMRSkKLQkJ ZXJlcG9ydChFUlJPUiwKLQkJCQkoZXJyY29kZShFUlJDT0RFX1dST05HX09CSkVDVF9UWVBF KSwKLQkJCQkgZXJybXNnKCJjYW5ub3QgdXNlIHJlbGF0aW9uIFwiJXMuJXNcIiBhcyBsb2dp Y2FsIHJlcGxpY2F0aW9uIHRhcmdldCIsCi0JCQkJCQluc3BuYW1lLCByZWxuYW1lKSwKLQkJ CQkgZXJyZGV0YWlsKCJcIiVzLiVzXCIgaXMgYSBmb3JlaWduIHRhYmxlLiIsCi0JCQkJCQkg ICBuc3BuYW1lLCByZWxuYW1lKSkpOwotCiAJaWYgKHJlbGtpbmQgIT0gUkVMS0lORF9SRUxB VElPTiAmJiByZWxraW5kICE9IFJFTEtJTkRfUEFSVElUSU9ORURfVEFCTEUpCiAJCWVyZXBv cnQoRVJST1IsCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9XUk9OR19PQkpFQ1RfVFlQRSksCiAJ CQkJIGVycm1zZygiY2Fubm90IHVzZSByZWxhdGlvbiBcIiVzLiVzXCIgYXMgbG9naWNhbCBy ZXBsaWNhdGlvbiB0YXJnZXQiLAogCQkJCQkJbnNwbmFtZSwgcmVsbmFtZSksCi0JCQkJIGVy cmRldGFpbCgiXCIlcy4lc1wiIGlzIG5vdCBhIHRhYmxlLiIsCi0JCQkJCQkgICBuc3BuYW1l LCByZWxuYW1lKSkpOworCQkJCSBlcnJkZXRhaWxfcmVsa2luZF9ub3Rfc3VwcG9ydGVkKHJl bGtpbmQpKSk7CiB9CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3B1 YmxpY2F0aW9uLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcHVibGljYXRpb24u b3V0CmluZGV4IGI1YjA2NWExYjYuLjRhNWVmMGJjMjQgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0 L3JlZ3Jlc3MvZXhwZWN0ZWQvcHVibGljYXRpb24ub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jl c3MvZXhwZWN0ZWQvcHVibGljYXRpb24ub3V0CkBAIC0xNjAsOCArMTYwLDggQEAgRFJPUCBU QUJMRSB0ZXN0cHViX3BhcnRlZDE7CiBEUk9QIFBVQkxJQ0FUSU9OIHRlc3RwdWJfZm9ycGFy dGVkLCB0ZXN0cHViX2ZvcnBhcnRlZDE7CiAtLSBmYWlsIC0gdmlldwogQ1JFQVRFIFBVQkxJ Q0FUSU9OIHRlc3RwdWJfZm9ydGJsIEZPUiBUQUJMRSB0ZXN0cHViX3ZpZXc7Ci1FUlJPUjog ICJ0ZXN0cHViX3ZpZXciIGlzIG5vdCBhIHRhYmxlCi1ERVRBSUw6ICBPbmx5IHRhYmxlcyBj YW4gYmUgYWRkZWQgdG8gcHVibGljYXRpb25zLgorRVJST1I6ICBjYW5ub3QgYWRkIHJlbGF0 aW9uICJ0ZXN0cHViX3ZpZXciIHRvIHB1YmxpY2F0aW9uCitERVRBSUw6ICBUaGlzIG9wZXJh dGlvbiBpcyBub3Qgc3VwcG9ydGVkIGZvciB2aWV3cy4KIFNFVCBjbGllbnRfbWluX21lc3Nh Z2VzID0gJ0VSUk9SJzsKIENSRUFURSBQVUJMSUNBVElPTiB0ZXN0cHViX2ZvcnRibCBGT1Ig VEFCTEUgdGVzdHB1Yl90YmwxLCBwdWJfdGVzdC50ZXN0cHViX25vcGs7CiBSRVNFVCBjbGll bnRfbWluX21lc3NhZ2VzOwpAQCAtMTgyLDggKzE4Miw4IEBAIFRhYmxlczoKIAogLS0gZmFp bCAtIHZpZXcKIEFMVEVSIFBVQkxJQ0FUSU9OIHRlc3RwdWJfZGVmYXVsdCBBREQgVEFCTEUg dGVzdHB1Yl92aWV3OwotRVJST1I6ICAidGVzdHB1Yl92aWV3IiBpcyBub3QgYSB0YWJsZQot REVUQUlMOiAgT25seSB0YWJsZXMgY2FuIGJlIGFkZGVkIHRvIHB1YmxpY2F0aW9ucy4KK0VS Uk9SOiAgY2Fubm90IGFkZCByZWxhdGlvbiAidGVzdHB1Yl92aWV3IiB0byBwdWJsaWNhdGlv bgorREVUQUlMOiAgVGhpcyBvcGVyYXRpb24gaXMgbm90IHN1cHBvcnRlZCBmb3Igdmlld3Mu CiBBTFRFUiBQVUJMSUNBVElPTiB0ZXN0cHViX2RlZmF1bHQgQUREIFRBQkxFIHRlc3RwdWJf dGJsMTsKIEFMVEVSIFBVQkxJQ0FUSU9OIHRlc3RwdWJfZGVmYXVsdCBTRVQgVEFCTEUgdGVz dHB1Yl90YmwxOwogQUxURVIgUFVCTElDQVRJT04gdGVzdHB1Yl9kZWZhdWx0IEFERCBUQUJM RSBwdWJfdGVzdC50ZXN0cHViX25vcGs7Ci0tIAoyLjMyLjAKCg== --------------817EE8C28E481DD39AB91234--