Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
References: <3185430.1626133592@sss.pgh.pa.us> <YOzy2rlluWYYoUvW@paquier.xyz>
 <3198753.1626150306@sss.pgh.pa.us> <YO1GcUp9IPVU9wuJ@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <ca06751a-deb1-6f07-b1ac-7c4df17e392d@enterprisedb.com>
Date: Tue, 13 Jul 2021 17:01:53 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YO1GcUp9IPVU9wuJ@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ca06751a-deb1-6f07-b1ac-7c4df17e392d%40enterprisedb.com>
Precedence: bulk

On 13.07.21 09:53, Michael Paquier wrote:
> I was thinking to just do the easiest move and fix this issue down to
> 13, not bothering about older branches :p
> 
> Looking at the commit, a backpatch is not that complicated and it is
> possible to check the generation of pg_config.h on non-MSVC
> environments if some objects are missing.  Still, I think that it
> would be better to be careful and test this code properly on Windows
> with a real build.  It means that..  Err...  Andrew or I should look
> at that.  I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.

We have lived with the previous system for a decade, so I think 
backpatching this would be a bit excessive.