Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciLXU-0005im-CF for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2017 13:40:32 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ciLXT-00058w-V7 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2017 13:40:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ciLXS-00057s-MR for pgsql-hackers@postgresql.org; Mon, 27 Feb 2017 13:40:30 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ciLXQ-0001gg-9R for pgsql-hackers@postgresql.org; Mon, 27 Feb 2017 13:40:30 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B3A2320B92; Mon, 27 Feb 2017 08:40:26 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Mon, 27 Feb 2017 08:40:26 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=qamq9SXVmUyJ0IpDsVvaLtmHozs=; b=hl2rUn1irYp/w+FUzMpx ZarPxflnp2JvKFW2H9yTCgjPFGKeFhGEV3VpVJW34/m/rzTkb2IFofQkxbTb0g+E PfKoCiYafkZLMx9rBdWu4kVI54nPc3KkIXgI4ualJq25/D44YWwS7Db0wzC2hg+a 77I+ET7UmgF7mcnErZ8c/Bw= X-ME-Sender: X-Sasl-enc: P6bT/ic55RyGq48qo1KBUO3G43im/pLFzTsU4lYUM9vC 1488202826 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 5DE777E31E; Mon, 27 Feb 2017 08:40:26 -0500 (EST) Subject: Re: WIP: Covering + unique indexes. To: Anastasia Lubennikova , Amit Kapila References: <56168952.4010101@postgrespro.ru> <20160814171131.21390.75752.pgcf@coridan.postgresql.org> <8d6b5b13-9c41-bd41-9c86-497e4e6a46ab@postgrespro.ru> <374642a5-b84e-faab-5d5c-18e558bde195@postgrespro.ru> <71e457e5-44e5-b507-16b7-1ced37581804@postgrespro.ru> <30b36728-4de8-6d69-5e2c-48e9d959e1ff@postgrespro.ru> <60afe4b8-76b1-64d0-31a3-f5dd016af47e@postgrespro.ru> Cc: Michael Paquier , Andrey Borodin , pgsql-hackers , Anastasia Lubennikova , Brad DeJong From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Mon, 27 Feb 2017 08:40:26 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <60afe4b8-76b1-64d0-31a3-f5dd016af47e@postgrespro.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2/16/17 08:13, Anastasia Lubennikova wrote: > @@ -629,7 +630,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query); > > HANDLER HAVING HEADER_P HOLD HOUR_P > > - IDENTITY_P IF_P ILIKE IMMEDIATE IMMUTABLE IMPLICIT_P IMPORT_P IN_P > + IDENTITY_P IF_P ILIKE IMMEDIATE IMMUTABLE IMPLICIT_P IMPORT_P IN_P INCLUDE > INCLUDING INCREMENT INDEX INDEXES INHERIT INHERITS INITIALLY INLINE_P > INNER_P INOUT INPUT_P INSENSITIVE INSERT INSTEAD INT_P INTEGER > INTERSECT INTERVAL INTO INVOKER IS ISNULL ISOLATION I think your syntax would read no worse, possibly even better, if you just used the existing INCLUDING keyword. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers