Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etEBt-0004y0-JD for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Mar 2018 15:07:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etEBs-0007WG-9P for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Mar 2018 15:07:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etEBr-0007W6-V6 for pgsql-hackers@lists.postgresql.org; Tue, 06 Mar 2018 15:07:44 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etEBp-0001bH-0x for pgsql-hackers@postgresql.org; Tue, 06 Mar 2018 15:07:42 +0000 Received: from Davids-iMac.local (unknown [173.169.74.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id BE3C054683; Tue, 6 Mar 2018 15:07:39 +0000 (UTC) Subject: Re: Re: Re: [HACKERS] Cached plans and statement generalization To: Konstantin Knizhnik Cc: Thomas Munro , Stephen Frost , Michael Paquier , PostgreSQL mailing lists , "Tsunakawa, Takayuki" References: <4bd78cd4-1e64-5294-2eb8-3d061b20288f@postgrespro.ru> <8eed9c23-19ba-5404-7a9e-0584b836b3f3@postgrespro.ru> <283dfb96-48c2-1a87-90ab-97ca87b237fe@postgrespro.ru> <20180106225118.GS2416@tamriel.snowman.net> <20638bbb-2744-a4ba-116d-084e9c6520bf@postgrespro.ru> From: David Steele Message-ID: Date: Tue, 6 Mar 2018 10:07:39 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 3/2/18 9:26 AM, David Steele wrote: > On 1/12/18 7:53 AM, Konstantin Knizhnik wrote: >> >> >> On 12.01.2018 03:40, Thomas Munro wrote: >>> On Sun, Jan 7, 2018 at 11:51 AM, Stephen Frost >>> wrote: >>>> * Konstantin Knizhnik (k.knizhnik@postgrespro.ru) wrote: >>>>> Updated version of the patch is attached. >>>> This patch appears to apply with just a bit of fuzz and make check >>>> passes, so I'm not sure why this is currently marked as 'Waiting for >>>> author'. >>>> >>>> I've updated it to be 'Needs review'.  If that's incorrect, feel free to >>>> change it back with an explanation. >>> Hi Konstantin, >>> >>> /home/travis/build/postgresql-cfbot/postgresql/src/backend/tcop/postgres.c:5249: >>> >>> undefined reference to `PortalGetHeapMemory' >>> >>> That's because commit 0f7c49e85518dd846ccd0a044d49a922b9132983 killed >>> PortalGetHeapMemory.  Looks like it needs to be replaced with >>> portal->portalContext. >>> >> Hi  Thomas, >> >> Thank you very much for reporting the problem. >> Rebased version of the patch is attached. > > This patch has received no review or comments since last May and appears > too complex and invasive for the final CF of PG11. > > I don't think it makes sense to keep pushing a patch through CFs when it > is not getting reviewed. I'm planning to mark this as Returned with > Feedback unless there are solid arguments to the contrary. Marked as Returned with Feedback. Regards, -- -David david@pgmasters.net