Message-ID: <ca9f44f0-a553-2f57-8017-d0ad84e06a6a@enterprisedb.com>
Date: Thu, 24 Feb 2022 13:23:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: Design of pg_stat_subscription_workers vs pgstats
Content-Language: en-US
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila
 <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20220215182641.2cejma6tcgeoqyw2@alap3.anarazel.de>
 <CAD21AoA-MVZcMA1iYwbtvTCOHx1SwG8amQUTT8j2ssh2zuc6OQ@mail.gmail.com>
 <20220218203255.d3evl6qi2n6gxy6b@alap3.anarazel.de>
 <CAD21AoDTO3bJvrc39Tv3VCeyUzZpimXnJuRhHQhKyjOWorHeOA@mail.gmail.com>
 <20220219160203.y5w2ktc2utthn7pe@alap3.anarazel.de>
 <CAD21AoA_r+Wc-zJZdy4Lii3oOvvdGcLwrY=2Y4y63HueYSd6Eg@mail.gmail.com>
 <20220221053453.lo6fzmji23ennvgj@alap3.anarazel.de>
 <CAA4eK1+j00Pc+p=AfJLXh-a+OJ-a0UD4adMr2tRkQvKG_LggHA@mail.gmail.com>
 <20220221074806.nyhdberpuwbcbudp@alap3.anarazel.de>
 <CAA4eK1J3dhfMRNQ6Q585nFr1vmXaTXVW9qv4hmUxLwDwJp-9RQ@mail.gmail.com>
 <CAD21AoAtrgBEUU08VvfzRnGS+=9rS=MEq1cTLaZ1OT51xX34dQ@mail.gmail.com>
 <CAHut+PtH-uN5rbGRh-=kCd8xvQYDf_JCcjLcVjW3OXGz6T+xCw@mail.gmail.com>
 <CAD21AoCCaQfGzDCAJgYH=yo72GXozpoMF4fau=5gViXK+uquWw@mail.gmail.com>
 <6f7701b0-ce5c-d01c-18f2-5de3a02ff6b6@enterprisedb.com>
 <CAD21AoBstze6x4zCXrSp_PppO_8M-s8L7PK7GsJahMmjQXSC+Q@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CAD21AoBstze6x4zCXrSp_PppO_8M-s8L7PK7GsJahMmjQXSC+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/ca9f44f0-a553-2f57-8017-d0ad84e06a6a%40enterprisedb.com>
Precedence: bulk


On 24.02.22 12:46, Masahiko Sawada wrote:
>> We have a view called pg_stat_activity, which is very well known.  From
>> that perspective, "activity" means what is happening right now or what
>> has happened most recently.  The reworked view in this patch does not
>> contain that (we already have pg_stat_subscription for that), but it
>> contains accumulated counters.
> Right.
> 
> What pg_stat_subscription shows is rather suitable for the name
> pg_stat_subscription_activity than the reworked view. But switching
> these names would also not be a good idea.  I think it's better to use
> "subscription" in the view name since it shows actually statistics for
> subscriptions and subscription OID is the key. I personally prefer
> pg_stat_subscription_counters among the ideas that have been proposed
> so far, but I'd like to hear opinions and votes.

_counters will fail if there is something not a counter (such as 
last-timestamp-of-something).

Earlier, pg_stat_subscription_stats was mentioned, which doesn't have 
that problem.