Message-ID: <caa515eb-e9e7-9fe7-ceb1-a96b6f3787ce@amazon.com>
Date: Tue, 9 Aug 2022 12:18:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.1
Subject: Re: shared-memory based stats collector - v70
To: Greg Stark <stark@mit.edu>, Andres Freund <andres@anarazel.de>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Melanie Plageman
	<melanieplageman@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>, Thomas Munro <thomas.munro@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers
	<pgsql-hackers@lists.postgresql.org>
References: <20220317073652.kz3uuh6le6vbfod4@alap3.anarazel.de>
 <CAAKRu_YsFzW3jsQUD7MVUY8c+87OiKW_Y93TsPAfLr3zi_jX9w@mail.gmail.com>
 <20220325.142256.1649716600998659084.horikyota.ntt@gmail.com>
 <20220325.172418.1055357550509939415.horikyota.ntt@gmail.com>
 <20220402082102.ojdd2e6cobsmljvh@alap3.anarazel.de>
 <20220404041516.cctrvpadhuriawlq@alap3.anarazel.de>
 <20220405030506.lfdhbu5zf4tzdpux@alap3.anarazel.de>
 <20220406030008.2qxipjxo776dwnqs@alap3.anarazel.de>
 <CAM-w4HN=4ss5dS2DH6Cof=zocJXeGOjRNKxEGgUZdJPMndyNzA@mail.gmail.com>
 <CAAKRu_Z18jYbarKA4GZMOO00KtUqKtBqgQ8SgB=wSvSqKq3iiA@mail.gmail.com>
 <1736122.1658333315@sss.pgh.pa.us>
 <CAM-w4HOxaO6iJ94bGt1A65PRgX_b4gGSmb4mdzakZ1QhvGW=jA@mail.gmail.com>
 <83D73EC0-E3ED-4C98-A528-5E122278D553@anarazel.de>
 <CAM-w4HMhHAxjpXNVMZ5WhULHpd3+LuP27zaSKSFnzZeRwHZTjg@mail.gmail.com>
Content-Language: en-US
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
In-Reply-To: 
 <CAM-w4HMhHAxjpXNVMZ5WhULHpd3+LuP27zaSKSFnzZeRwHZTjg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/caa515eb-e9e7-9fe7-ceb1-a96b6f3787ce%40amazon.com>
Precedence: bulk

Hi,

On 7/21/22 5:07 PM, Greg Stark wrote:
> On Wed, 20 Jul 2022 at 15:09, Andres Freund <andres@anarazel.de> wrote:
>> What are your trying to do?
> Ideally I would want to dump out the stats without connecting to each
> database.

I can see the use case too (specially for monitoring tools) of being 
able to collect the stats without connecting to each database.

> It seems like just having an interface to iterate over the shared hash
> table and return entries one by one without filtering by database
> would be fairly straightforward and I would be able to do most of what
> I want just with that.

What do you think about adding a function in core PG to provide such 
functionality? (means being able to retrieve all the stats (+ eventually 
add some filtering) without the need to connect to each database).

If there is some interest, I'd be happy to work on it and propose a patch.

Regards,

-- 
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com