Feedback-ID: ie0a040ee:Fastmail
Message-ID: <cab23590-19d4-4895-9333-1c25f4194741@eisentraut.org>
Date: Wed, 21 Feb 2024 08:46:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
 Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
 Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com
References: <ZCIxFkgOGv64nYE7@paquier.xyz> <ZCJuW3GOfE/0eBjh@telsasoft.com>
 <ZCUZLiCeXq4Im7OG@telsasoft.com> <ZEccbkBYCMy42Rxt@telsasoft.com>
 <ZG8E6DggGkPyEPPx@paquier.xyz> <ZHfZxjcR0J9Ws7ze@telsasoft.com>
 <ZHiUKhhT71X4CjJl@paquier.xyz> <ZLgn3Ou4YpgP8Z8l@telsasoft.com>
 <d1cb16ec-9af1-4657-81f2-865480d2bd6d@eisentraut.org>
 <ZdWa0sSExPfBvAyR@paquier.xyz>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ZdWa0sSExPfBvAyR@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/cab23590-19d4-4895-9333-1c25f4194741%40eisentraut.org>
Precedence: bulk

On 21.02.24 07:40, Michael Paquier wrote:
> This means that all partitioned tables would have pg_class.relam set,
> and that relam would never be 0:
> - The USING clause takes priority over default_table_access_method.
> - If no USING clause, default_table_access_method is the AM used
> 
> Any partitions created from this partitioned table would inherit the
> AM set, ignoring default_table_access_method.
> 
> Alvaro has made a very good point a couple of days ago at [1] where we
> should try to make the behavior stick closer to tablespaces, where it
> could be possible to set relam to 0 for a partitioned table, where a
> partition would inherit the AM set in the GUC when a USING clause is
> not defined (if USING specifies the AM, we'd just use it).

Yes, I think most people agreed that that would be the preferred behavior.