public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 6/8] Default to LZ4..
4+ messages / 4 participants
[nested] [flat]
* [PATCH 6/8] Default to LZ4..
@ 2021-03-12 21:35 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw)
this is meant to exercise in the CIs, and not meant to be merged
---
configure | 6 ++++--
configure.ac | 4 ++--
src/backend/utils/misc/guc.c | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 9b590eb432..3afa1e87e3 100755
--- a/configure
+++ b/configure
@@ -1575,7 +1575,7 @@ Optional Packages:
--with-system-tzdata=DIR
use system time zone data in DIR
--without-zlib do not use Zlib
- --with-lz4 build with LZ4 support
+ --without-lz4 build without LZ4 support
--with-gnu-ld assume the C compiler uses GNU ld [default=no]
--with-ssl=LIB use LIB for SSL/TLS support (openssl)
--with-openssl obsolete spelling of --with-ssl=openssl
@@ -8598,7 +8598,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h
esac
else
- with_lz4=no
+ with_lz4=yes
+
+$as_echo "#define USE_LZ4 1" >>confdefs.h
fi
diff --git a/configure.ac b/configure.ac
index 2b3b5676eb..d62ea5f742 100644
--- a/configure.ac
+++ b/configure.ac
@@ -990,8 +990,8 @@ AC_SUBST(with_zlib)
# LZ4
#
AC_MSG_CHECKING([whether to build with LZ4 support])
-PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support],
- [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])])
+PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support],
+ [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])])
AC_MSG_RESULT([$with_lz4])
AC_SUBST(with_lz4)
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index c37a8313d3..52f9cd0242 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] =
NULL
},
&wal_compression_method,
- WAL_COMPRESSION_ZLIB, wal_compression_options,
+ WAL_COMPRESSION_LZ4, wal_compression_options,
NULL, NULL, NULL
},
--
2.17.0
--f0KYrhQ4vYSV2aJu
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0007-add-wal_compression_method-zstd.patch"
^ permalink raw reply [nested|flat] 4+ messages in thread
* A tiny improvement of psql
@ 2023-12-24 18:17 Kevin Wang <[email protected]>
2023-12-26 16:36 ` Re: A tiny improvement of psql Tom Lane <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Wang @ 2023-12-24 18:17 UTC (permalink / raw)
To: pgsql-hackers
Hello hackers!
I am an Oracle/PostgreSQL DBA, I am not a PG hacker. During my daily job,
I find a pain that should be fixed.
As you know, we can use the UP arrow key to get the previous command to
avoid extra typing. This is a wonderful feature to save the lives of every
DBA. However, if I type the commands like this sequence: A, B, B, B, B, B,
B, as you can see, B is the last command I execute.
But if I try to get command A, I have to press the UP key 7 times. I think
the best way is: when you press the UP key, plsql should show the command
that is different from the previous command, so the recall sequence should
be B -> A, not B -> B -> ... -> A. Then I only press the UP key 2 times to
get command A.
I think this should change little code in psql, but it will make all DBA's
lives much easier. This is a strong requirement from the real DBA. Hope to
get some feedback on this.
Another requirement is: could we use / to repeat executing the last command
in plsql just like sqlplus in Oracle?
I will try to learn how to fix it sooner or later, but if some
proficient hacker focuses on this, it can be fixed quickly, I guess.
Thoughts?
Regards,
Kevin
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: A tiny improvement of psql
2023-12-24 18:17 A tiny improvement of psql Kevin Wang <[email protected]>
@ 2023-12-26 16:36 ` Tom Lane <[email protected]>
2023-12-26 21:45 ` Re: A tiny improvement of psql Vik Fearing <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Lane @ 2023-12-26 16:36 UTC (permalink / raw)
To: Kevin Wang <[email protected]>; +Cc: pgsql-hackers
Kevin Wang <[email protected]> writes:
> As you know, we can use the UP arrow key to get the previous command to
> avoid extra typing. This is a wonderful feature to save the lives of every
> DBA. However, if I type the commands like this sequence: A, B, B, B, B, B,
> B, as you can see, B is the last command I execute.
> But if I try to get command A, I have to press the UP key 7 times. I think
> the best way is: when you press the UP key, plsql should show the command
> that is different from the previous command, so the recall sequence should
> be B -> A, not B -> B -> ... -> A. Then I only press the UP key 2 times to
> get command A.
This is driven by libreadline, not anything we control. I have
seen the behavior you describe in some other programs, so I wonder
whether it's configurable.
> Another requirement is: could we use / to repeat executing the last command
> in plsql just like sqlplus in Oracle?
I'm pretty certain you can configure this for yourself with readline.
regards, tom lane
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: A tiny improvement of psql
2023-12-24 18:17 A tiny improvement of psql Kevin Wang <[email protected]>
2023-12-26 16:36 ` Re: A tiny improvement of psql Tom Lane <[email protected]>
@ 2023-12-26 21:45 ` Vik Fearing <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Vik Fearing @ 2023-12-26 21:45 UTC (permalink / raw)
To: Tom Lane <[email protected]>; Kevin Wang <[email protected]>; +Cc: pgsql-hackers
On 12/26/23 17:36, Tom Lane wrote:
> Kevin Wang <[email protected]> writes:
>> As you know, we can use the UP arrow key to get the previous command to
>> avoid extra typing. This is a wonderful feature to save the lives of every
>> DBA. However, if I type the commands like this sequence: A, B, B, B, B, B,
>> B, as you can see, B is the last command I execute.
>
>> But if I try to get command A, I have to press the UP key 7 times. I think
>> the best way is: when you press the UP key, plsql should show the command
>> that is different from the previous command, so the recall sequence should
>> be B -> A, not B -> B -> ... -> A. Then I only press the UP key 2 times to
>> get command A.
>
> This is driven by libreadline, not anything we control. I have
> seen the behavior you describe in some other programs, so I wonder
> whether it's configurable.
It is kind of something we control. Per the psql docs, setting
HISTCONTROL=ignoredups
will do the trick.
https://www.postgresql.org/docs/current/app-psql.html#APP-PSQL-VARIABLES-HISTCONTROL
--
Vik Fearing
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-12-26 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 21:35 [PATCH 6/8] Default to LZ4.. Justin Pryzby <[email protected]>
2023-12-24 18:17 A tiny improvement of psql Kevin Wang <[email protected]>
2023-12-26 16:36 ` Re: A tiny improvement of psql Tom Lane <[email protected]>
2023-12-26 21:45 ` Re: A tiny improvement of psql Vik Fearing <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox