Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb
MIME-Version: 1.0
Message-Id: <cb061371-7fc9-42b1-ad99-9f5fc4e687c2@app.fastmail.com>
In-Reply-To: <bde6ac67-69cc-c104-5ab6-dd4f5deadf24@gmail.com>
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com>
 <CAA4eK1KPoLUUGzjw9eEQd56LUAf2QQj8BqMcsoSe6vycB5CYUQ@mail.gmail.com>
 <2e86cf53-c806-49d2-9a10-1a1257776d1f@app.fastmail.com>
 <CAA4eK1JJq_ER6Kq_H=jKHR75QPRd8y9_D=RtYw=aPYKMfqLi9A@mail.gmail.com>
 <CAA4eK1KdCb+5sjYu6qCMXXdCX1y_ihr8kFzMozq0=P=auYxgog@mail.gmail.com>
 <CANhcyEV6q1Vhd37i1axUeScLi0UAGVxta1LDa0BV0Eh--TcPMg@mail.gmail.com>
 <CAA4eK1JaQcAZ=n513-4VDW4ujE9T9f007fczNCpVDbg1smhT4g@mail.gmail.com>
 <5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com>
 <776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com>
 <3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org>
 <0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com>
 <OSBPR01MB25528300C71FDD83EA1DCA12F5DD2@OSBPR01MB2552.jpnprd01.prod.outlook.com>
 <CAA4eK1+Qmc34cooSNm2=U6YsySSjZTn2_eD_deDFEAZv+aj-AA@mail.gmail.com>
 <OSBPR01MB2552440DCE1AE5EDC51BAEC6F5DD2@OSBPR01MB2552.jpnprd01.prod.outlook.com>
 <CAA4eK1J9Vn1HB7sXNx-cH4COBd_moGZtrZd82Z160mK6u0HspQ@mail.gmail.com>
 <bde6ac67-69cc-c104-5ab6-dd4f5deadf24@gmail.com>
Date: Wed, 10 Jul 2024 08:20:50 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Alexander Lakhin" <exclusion@gmail.com>,
 "Amit Kapila" <amit.kapila16@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/mixed;
 boundary=b988ecfca8d64708898a8490fc51b671
Archived-At: <https://www.postgresql.org/message-id/cb061371-7fc9-42b1-ad99-9f5fc4e687c2%40app.fastmail.com>
Precedence: bulk

--b988ecfca8d64708898a8490fc51b671
Content-Type: multipart/alternative;
 boundary=9b12ef09bc2b473a826cdf56bcda3899

--9b12ef09bc2b473a826cdf56bcda3899
Content-Type: text/plain

On Tue, Jul 9, 2024, at 8:00 AM, Alexander Lakhin wrote:
> Hello Amit and Kuroda-san,
> 
> 03.07.2024 14:02, Amit Kapila wrote:
> > Pushed 0002 and 0003. Let's wait for a discussion on 0001.
> 
> Please look at another failure of the test [1]:
> [13:28:05.647](2.460s) not ok 26 - failover slot is synced
> [13:28:05.648](0.001s) #   Failed test 'failover slot is synced'
> #   at /home/bf/bf-build/skink-master/HEAD/pgsql/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl line 307.
> [13:28:05.648](0.000s) #          got: ''
> #     expected: 'failover_slot'

I'm wondering if the attached patch is sufficient to move the restart_lsn
forward. I experimented several lightweight ideas but none works. BTW the steps
to create the failover slot here is similar 040_standby_failover_slots_sync.pl.
I don't have a clue why it is failing for this one.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--9b12ef09bc2b473a826cdf56bcda3899
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Tue, Jul 9, =
2024, at 8:00 AM, Alexander Lakhin wrote:<br></div><blockquote type=3D"c=
ite" id=3D"qt" style=3D""><div>Hello Amit and Kuroda-san,<br></div><div>=
<br></div><div>03.07.2024 14:02, Amit Kapila wrote:<br></div><div>&gt; P=
ushed 0002 and 0003. Let's wait for a discussion on 0001.<br></div><div>=
<br></div><div>Please look at another failure of the test [1]:<br></div>=
<div>[13:28:05.647](2.460s) not ok 26 - failover slot is synced<br></div=
><div>[13:28:05.648](0.001s) #&nbsp;&nbsp; Failed test 'failover slot is=
 synced'<br></div><div>#&nbsp;&nbsp; at /home/bf/bf-build/skink-master/H=
EAD/pgsql/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl line 307.<b=
r></div><div>[13:28:05.648](0.000s) #&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
;&nbsp;&nbsp;&nbsp; got: ''<br></div><div>#&nbsp;&nbsp;&nbsp;&nbsp; expe=
cted: 'failover_slot'<br></div></blockquote><div><br></div><div>I'm wond=
ering if the attached patch is sufficient to move the restart_lsn<br></d=
iv><div>forward. I experimented several lightweight ideas but none works=
. BTW the steps<br></div><div>to create the failover slot here is simila=
r 040_standby_failover_slots_sync.pl.<br></div><div>I don't have a clue =
why it is failing for this one.<br></div><div><br></div><div><br></div><=
div id=3D"sig112409080"><div class=3D"signature">--<br></div><div class=3D=
"signature">Euler Taveira<br></div><div class=3D"signature">EDB&nbsp;&nb=
sp; <a href=3D"https://www.enterprisedb.com/">https://www.enterprisedb.c=
om/</a><br></div></div><div><br></div></body></html>
--9b12ef09bc2b473a826cdf56bcda3899--

--b988ecfca8d64708898a8490fc51b671
Content-Disposition: attachment; filename="fix.diff"
Content-Type: text/x-patch; name="fix.diff"
Content-Transfer-Encoding: BASE64

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC90LzA0MF9wZ19jcmVhdGVzdWJz
Y3JpYmVyLnBsIGIvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3QvMDQwX3BnX2NyZWF0ZXN1YnNj
cmliZXIucGwKaW5kZXggNzRiOTBkOWE5MTMuLjIzMmRiYmJjNTVlIDEwMDY0NAotLS0gYS9z
cmMvYmluL3BnX2Jhc2ViYWNrdXAvdC8wNDBfcGdfY3JlYXRlc3Vic2NyaWJlci5wbAorKysg
Yi9zcmMvYmluL3BnX2Jhc2ViYWNrdXAvdC8wNDBfcGdfY3JlYXRlc3Vic2NyaWJlci5wbApA
QCAtMjk3LDYgKzI5NywxNyBAQCAkbm9kZV9wLT5zYWZlX3BzcWwoJGRiMSwKIAkiU0VMRUNU
IHBnX2NyZWF0ZV9sb2dpY2FsX3JlcGxpY2F0aW9uX3Nsb3QoJyRmc2xvdG5hbWUnLCAncGdv
dXRwdXQnLCBmYWxzZSwgZmFsc2UsIHRydWUpIgogKTsKICRub2RlX3MtPnN0YXJ0OworJG5v
ZGVfcC0+c2FmZV9wc3FsKCRkYjEsIHFxKAorCVNFTEVDVCBwZ19sb2dpY2FsX2VtaXRfbWVz
c2FnZSh0cnVlLCAnYScsICcxJyk7CisJQ0hFQ0tQT0lOVDsKKykpOworJG5vZGVfcC0+c2Fm
ZV9wc3FsKCRkYjEsIHFxKAorCVNFTEVDVCAqCisJRlJPTSBwZ19sb2dpY2FsX3Nsb3RfZ2V0
X2JpbmFyeV9jaGFuZ2VzKCckZnNsb3RuYW1lJywgTlVMTCwgTlVMTCwKKwkJJ3Byb3RvX3Zl
cnNpb24nLCAnMScsCisJCSdwdWJsaWNhdGlvbl9uYW1lcycsICdkdW1teScsCisJCSdtZXNz
YWdlcycsICd0cnVlJyk7CispKTsKICMgV2FpdCBmb3IgdGhlIHN0YW5kYnkgdG8gY2F0Y2gg
dXAgc28gdGhhdCB0aGUgc3RhbmRieSBpcyBub3QgbGFnZ2luZyBiZWhpbmQKICMgdGhlIGZh
aWxvdmVyIHNsb3QuCiAkbm9kZV9wLT53YWl0X2Zvcl9yZXBsYXlfY2F0Y2h1cCgkbm9kZV9z
KTsK

--b988ecfca8d64708898a8490fc51b671--