Message-ID: <cbc03892163dbf67980e2863b784745517a516a5.camel@cybertec.at>
Subject: Re: doc: create table improvements
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: jian he <jian.universality@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Peter Eisentraut	
 <peter@eisentraut.org>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Date: Thu, 16 Oct 2025 15:19:32 +0200
In-Reply-To: 
 <CACJufxFgZtLENzJkZZssKdWEfHo1hk9uyC0h3JcGJJb19XRJQQ@mail.gmail.com>
References: 
	<CAKFQuwYfMV-2SdrP-umr5SVNSqTn378BUvHsebetp5=DhT494w@mail.gmail.com>
	 <ec0bd3d2-3e15-4492-b93a-683c04ec345c@eisentraut.org>
	 <CAKFQuwYk7NsEAEsPEUdbc_gXB0OR+gZzmBjDcUSe5JZuE+d_iw@mail.gmail.com>
	 <ae5203d1f68267b1e67cfd32023ece1367689b83.camel@cybertec.at>
	 <CACJufxFgZtLENzJkZZssKdWEfHo1hk9uyC0h3JcGJJb19XRJQQ@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-qlcQ4YIVkv4XCxhzj8xS"
User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/cbc03892163dbf67980e2863b784745517a516a5.camel%40cybertec.at>
Precedence: bulk

--=-qlcQ4YIVkv4XCxhzj8xS
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2025-10-16 at 11:28 +0800, jian he wrote:
> -<phrase>where <replaceable
> class=3D"parameter">column_constraint</replaceable> is:</phrase>
> +<phrase>where <replaceable>persistence_mode</replaceable> is: </phrase>
> +
> +[ GLOBAL | LOCAL ] { TEMPORARY | TEMP } |
> +UNLOGGED
>=20
> we can just do it with one line:
> [ GLOBAL | LOCAL ] { TEMPORARY | TEMP } | UNLOGGED

You are right; changed.

> most of the time, the patch using:
> <replaceable>persistence_mode</replaceable>
> <replaceable>oversize_storage</replaceable>
>=20
> for column_constraint we are using
> <replaceable class=3D"parameter">column_constraint</replaceable>
>=20
> do we need change it to
> <replaceable class=3D"parameter">persistence_mode</replaceable>
> <replaceable class=3D"parameter">oversize_storage</replaceable>
> ?
>=20
> I don't know the purpose of this extra ``"class=3D"parameter"``.

I don't know either.  I guess it makes no visible difference.

Anyway, I had a try to establish some consistency in using that
attribute, but had to give up.  There is no rhyme and reason for
me.  All I did was label <replaceable>parent_table</replaceable>
and <replaceable>source_table</replaceable> with class=3D"parameter",
since that seemed appropriate.

I left the rest alone, any massive changes in that area would make
the patch rather noisy.

Attached is version 3.

Yours,
Laurenz Albe

--=-qlcQ4YIVkv4XCxhzj8xS
Content-Disposition: attachment;
 filename="v3-0001-Unclutter-CREATE-TABLE-synopsis.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
 name="v3-0001-Unclutter-CREATE-TABLE-synopsis.patch";
	charset="UTF-8"

RnJvbSBiNGFlOTJhNGVkN2E2ZWU5MDM2ODZkOThmNmNjNzAzMjY1ZDVjMjMxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogVGh1LCAxNiBPY3QgMjAyNSAxNToxMzo1NyArMDIwMApTdWJqZWN0OiBbUEFUQ0gg
djNdIFVuY2x1dHRlciBDUkVBVEUgVEFCTEUgc3lub3BzaXMKCkZhY3RvciBvdXQgdGhlICJwZXJz
aXN0ZW5jZSBtb2RlIiBhbmQgIm92ZXJzaXplIHN0b3JhZ2UiIHBhcnRzCm9mIHRoZSBzeW50YXgg
c3lub3BzaXMgdG8gcmVkdWNlIHRoZSBsaW5lIGxlbmd0aCBhbmQgaW5jcmVhc2UKdGhlIHJlYWRh
YmlsaXR5LgoKQXV0aG9yOiBEYXZpZCBHLiBKb2huc3RvbiA8ZGF2aWQuZy5qb2huc3RvbkBnbWFp
bC5jb20+ClJldmlld2VkLWJ5OiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KUmV2aWV3ZWQtYnk6IEppYW4gSGUgPGppYW4udW5pdmVyc2FsaXR5QGdtYWlsLmNvbT4KRGlz
Y3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9DQUtGUXV3WWZNVi0yU2RyUC11bXI1U1ZOU3FU
bjM3OEJVdkhzZWJldHA1JTNERGhUNDk0dyU0MG1haWwuZ21haWwuY29tCi0tLQogZG9jL3NyYy9z
Z21sL3JlZi9jcmVhdGVfdGFibGUuc2dtbCB8IDMwICsrKysrKysrKysrKysrKysrKysrKysrLS0t
LS0tLQogMSBmaWxlIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3JlZi9jcmVhdGVfdGFibGUuc2dtbCBiL2RvYy9zcmMv
c2dtbC9yZWYvY3JlYXRlX3RhYmxlLnNnbWwKaW5kZXggYTE1N2EyNDRlNGUuLmU0NmI0ODBiY2Y5
IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2NyZWF0ZV90YWJsZS5zZ21sCisrKyBiL2Rv
Yy9zcmMvc2dtbC9yZWYvY3JlYXRlX3RhYmxlLnNnbWwKQEAgLTIxLDIwICsyMSwyMCBAQCBQb3N0
Z3JlU1FMIGRvY3VtZW50YXRpb24KIAogIDxyZWZzeW5vcHNpc2Rpdj4KIDxzeW5vcHNpcz4KLUNS
RUFURSBbIFsgR0xPQkFMIHwgTE9DQUwgXSB7IFRFTVBPUkFSWSB8IFRFTVAgfSB8IFVOTE9HR0VE
IF0gVEFCTEUgWyBJRiBOT1QgRVhJU1RTIF0gPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIi
PnRhYmxlX25hbWU8L3JlcGxhY2VhYmxlPiAoIFsKLSAgeyA8cmVwbGFjZWFibGUgY2xhc3M9InBh
cmFtZXRlciI+Y29sdW1uX25hbWU8L3JlcGxhY2VhYmxlPiA8cmVwbGFjZWFibGUgY2xhc3M9InBh
cmFtZXRlciI+ZGF0YV90eXBlPC9yZXBsYWNlYWJsZT4gWyBTVE9SQUdFIHsgUExBSU4gfCBFWFRF
Uk5BTCB8IEVYVEVOREVEIHwgTUFJTiB8IERFRkFVTFQgfSBdIFsgQ09NUFJFU1NJT04gPHJlcGxh
Y2VhYmxlPmNvbXByZXNzaW9uX21ldGhvZDwvcmVwbGFjZWFibGU+IF0gWyBDT0xMQVRFIDxyZXBs
YWNlYWJsZT5jb2xsYXRpb248L3JlcGxhY2VhYmxlPiBdIFsgPHJlcGxhY2VhYmxlIGNsYXNzPSJw
YXJhbWV0ZXIiPmNvbHVtbl9jb25zdHJhaW50PC9yZXBsYWNlYWJsZT4gWyAuLi4gXSBdCitDUkVB
VEUgWyA8cmVwbGFjZWFibGU+cGVyc2lzdGVuY2VfbW9kZTwvcmVwbGFjZWFibGU+IF0gVEFCTEUg
WyBJRiBOT1QgRVhJU1RTIF0gPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnRhYmxlX25h
bWU8L3JlcGxhY2VhYmxlPiAoIFsKKyAgeyA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+
Y29sdW1uX25hbWU8L3JlcGxhY2VhYmxlPiA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+
ZGF0YV90eXBlPC9yZXBsYWNlYWJsZT4gWyA8cmVwbGFjZWFibGU+b3ZlcnNpemVfc3RvcmFnZTwv
cmVwbGFjZWFibGU+IF0gWyBDT0xMQVRFIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5j
b2xsYXRpb248L3JlcGxhY2VhYmxlPiBdIFsgPHJlcGxhY2VhYmxlPmNvbHVtbl9jb25zdHJhaW50
PC9yZXBsYWNlYWJsZT4gWyAuLi4gXSBdCiAgICAgfCA8cmVwbGFjZWFibGU+dGFibGVfY29uc3Ry
YWludDwvcmVwbGFjZWFibGU+Ci0gICAgfCBMSUtFIDxyZXBsYWNlYWJsZT5zb3VyY2VfdGFibGU8
L3JlcGxhY2VhYmxlPiBbIDxyZXBsYWNlYWJsZT5saWtlX29wdGlvbjwvcmVwbGFjZWFibGU+IC4u
LiBdIH0KKyAgICB8IExJS0UgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnNvdXJjZV90
YWJsZTwvcmVwbGFjZWFibGU+IFsgPHJlcGxhY2VhYmxlPmxpa2Vfb3B0aW9uPC9yZXBsYWNlYWJs
ZT4gLi4uIF0gfQogICAgIFssIC4uLiBdCiBdICkKLVsgSU5IRVJJVFMgKCA8cmVwbGFjZWFibGU+
cGFyZW50X3RhYmxlPC9yZXBsYWNlYWJsZT4gWywgLi4uIF0gKSBdCitbIElOSEVSSVRTICggPHJl
cGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnBhcmVudF90YWJsZTwvcmVwbGFjZWFibGU+IFss
IC4uLiBdICkgXQogWyBQQVJUSVRJT04gQlkgeyBSQU5HRSB8IExJU1QgfCBIQVNIIH0gKCB7IDxy
ZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5jb2x1bW5fbmFtZTwvcmVwbGFjZWFibGU+IHwg
KCA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+ZXhwcmVzc2lvbjwvcmVwbGFjZWFibGU+
ICkgfSBbIENPTExBVEUgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPmNvbGxhdGlvbjwv
cmVwbGFjZWFibGU+IF0gWyA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+b3BjbGFzczwv
cmVwbGFjZWFibGU+IF0gWywgLi4uIF0gKSBdCiBbIFVTSU5HIDxyZXBsYWNlYWJsZSBjbGFzcz0i
cGFyYW1ldGVyIj5tZXRob2Q8L3JlcGxhY2VhYmxlPiBdCiBbIFdJVEggKCA8cmVwbGFjZWFibGUg
Y2xhc3M9InBhcmFtZXRlciI+c3RvcmFnZV9wYXJhbWV0ZXI8L3JlcGxhY2VhYmxlPiBbPSA8cmVw
bGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+dmFsdWU8L3JlcGxhY2VhYmxlPl0gWywgLi4uIF0g
KSB8IFdJVEhPVVQgT0lEUyBdCiBbIE9OIENPTU1JVCB7IFBSRVNFUlZFIFJPV1MgfCBERUxFVEUg
Uk9XUyB8IERST1AgfSBdCiBbIFRBQkxFU1BBQ0UgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0
ZXIiPnRhYmxlc3BhY2VfbmFtZTwvcmVwbGFjZWFibGU+IF0KIAotQ1JFQVRFIFsgWyBHTE9CQUwg
fCBMT0NBTCBdIHsgVEVNUE9SQVJZIHwgVEVNUCB9IHwgVU5MT0dHRUQgXSBUQUJMRSBbIElGIE5P
VCBFWElTVFMgXSA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+dGFibGVfbmFtZTwvcmVw
bGFjZWFibGU+CitDUkVBVEUgWyA8cmVwbGFjZWFibGU+cGVyc2lzdGVuY2VfbW9kZTwvcmVwbGFj
ZWFibGU+IF0gVEFCTEUgWyBJRiBOT1QgRVhJU1RTIF0gPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJh
bWV0ZXIiPnRhYmxlX25hbWU8L3JlcGxhY2VhYmxlPgogICAgIE9GIDxyZXBsYWNlYWJsZSBjbGFz
cz0icGFyYW1ldGVyIj50eXBlX25hbWU8L3JlcGxhY2VhYmxlPiBbICgKICAgeyA8cmVwbGFjZWFi
bGUgY2xhc3M9InBhcmFtZXRlciI+Y29sdW1uX25hbWU8L3JlcGxhY2VhYmxlPiBbIFdJVEggT1BU
SU9OUyBdIFsgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPmNvbHVtbl9jb25zdHJhaW50
PC9yZXBsYWNlYWJsZT4gWyAuLi4gXSBdCiAgICAgfCA8cmVwbGFjZWFibGU+dGFibGVfY29uc3Ry
YWludDwvcmVwbGFjZWFibGU+IH0KQEAgLTQ2LDcgKzQ2LDcgQEAgQ1JFQVRFIFsgWyBHTE9CQUwg
fCBMT0NBTCBdIHsgVEVNUE9SQVJZIHwgVEVNUCB9IHwgVU5MT0dHRUQgXSBUQUJMRSBbIElGIE5P
VCBFWEkKIFsgT04gQ09NTUlUIHsgUFJFU0VSVkUgUk9XUyB8IERFTEVURSBST1dTIHwgRFJPUCB9
IF0KIFsgVEFCTEVTUEFDRSA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+dGFibGVzcGFj
ZV9uYW1lPC9yZXBsYWNlYWJsZT4gXQogCi1DUkVBVEUgWyBbIEdMT0JBTCB8IExPQ0FMIF0geyBU
RU1QT1JBUlkgfCBURU1QIH0gfCBVTkxPR0dFRCBdIFRBQkxFIFsgSUYgTk9UIEVYSVNUUyBdIDxy
ZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj50YWJsZV9uYW1lPC9yZXBsYWNlYWJsZT4KK0NS
RUFURSBbIDxyZXBsYWNlYWJsZT5wZXJzaXN0ZW5jZV9tb2RlPC9yZXBsYWNlYWJsZT4gXSBUQUJM
RSBbIElGIE5PVCBFWElTVFMgXSA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+dGFibGVf
bmFtZTwvcmVwbGFjZWFibGU+CiAgICAgUEFSVElUSU9OIE9GIDxyZXBsYWNlYWJsZSBjbGFzcz0i
cGFyYW1ldGVyIj5wYXJlbnRfdGFibGU8L3JlcGxhY2VhYmxlPiBbICgKICAgeyA8cmVwbGFjZWFi
bGUgY2xhc3M9InBhcmFtZXRlciI+Y29sdW1uX25hbWU8L3JlcGxhY2VhYmxlPiBbIFdJVEggT1BU
SU9OUyBdIFsgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPmNvbHVtbl9jb25zdHJhaW50
PC9yZXBsYWNlYWJsZT4gWyAuLi4gXSBdCiAgICAgfCA8cmVwbGFjZWFibGU+dGFibGVfY29uc3Ry
YWludDwvcmVwbGFjZWFibGU+IH0KQEAgLTU4LDcgKzU4LDE1IEBAIENSRUFURSBbIFsgR0xPQkFM
IHwgTE9DQUwgXSB7IFRFTVBPUkFSWSB8IFRFTVAgfSB8IFVOTE9HR0VEIF0gVEFCTEUgWyBJRiBO
T1QgRVhJCiBbIE9OIENPTU1JVCB7IFBSRVNFUlZFIFJPV1MgfCBERUxFVEUgUk9XUyB8IERST1Ag
fSBdCiBbIFRBQkxFU1BBQ0UgPHJlcGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnRhYmxlc3Bh
Y2VfbmFtZTwvcmVwbGFjZWFibGU+IF0KIAotPHBocmFzZT53aGVyZSA8cmVwbGFjZWFibGUgY2xh
c3M9InBhcmFtZXRlciI+Y29sdW1uX2NvbnN0cmFpbnQ8L3JlcGxhY2VhYmxlPiBpczo8L3BocmFz
ZT4KKzxwaHJhc2U+d2hlcmUgPHJlcGxhY2VhYmxlPnBlcnNpc3RlbmNlX21vZGU8L3JlcGxhY2Vh
YmxlPiBpczogPC9waHJhc2U+CisKK1sgR0xPQkFMIHwgTE9DQUwgXSB7IFRFTVBPUkFSWSB8IFRF
TVAgfSB8IFVOTE9HR0VECisKKzxwaHJhc2U+YW5kIDxyZXBsYWNlYWJsZT5vdmVyc2l6ZV9zdG9y
YWdlPC9yZXBsYWNlYWJsZT4gaXM6PC9waHJhc2U+CisKK1NUT1JBR0UgeyBQTEFJTiB8IEVYVEVS
TkFMIHwgRVhURU5ERUQgfCBNQUlOIHwgREVGQVVMVCB9IFsgQ09NUFJFU1NJT04gPHJlcGxhY2Vh
YmxlPmNvbXByZXNzaW9uX21ldGhvZDwvcmVwbGFjZWFibGU+IF0KKworPHBocmFzZT5hbmQgPHJl
cGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPmNvbHVtbl9jb25zdHJhaW50PC9yZXBsYWNlYWJs
ZT4gaXM6PC9waHJhc2U+CiAKIFsgQ09OU1RSQUlOVCA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFt
ZXRlciI+Y29uc3RyYWludF9uYW1lPC9yZXBsYWNlYWJsZT4gXQogeyBOT1QgTlVMTCBbIE5PIElO
SEVSSVQgXSAgfApAQCAtMTIzLDYgKzEzMSwxNCBAQCBXSVRIICggTU9EVUxVUyA8cmVwbGFjZWFi
bGUgY2xhc3M9InBhcmFtZXRlciI+bnVtZXJpY19saXRlcmFsPC9yZXBsYWNlYWJsZT4sIFJFTQog
ICAgY29tbWFuZC4KICAgPC9wYXJhPgogCisgIDxwYXJhPgorICAgVGhlIGR1cmFiaWxpdHkgY2hh
cmFjdGVyaXN0aWNzIG9mIGEgdGFibGUgYXJlIGdvdmVybmVkIGJ5IGl0cyBwZXJzaXN0ZW5jZQor
ICAgbW9kZS4gIElmIG5vbmUgaXMgc3BlY2lmaWVkLCB0aGUgZGF0YSB3aWxsIGJlIHBlcnNpc3Rl
bnQgYW5kIGNyYXNoLXNhZmUuCisgICBGb3IgbGVzcyBzdHJpbmdlbnQgcmVxdWlyZW1lbnRzIGFu
ZCBiZXR0ZXIgcGVyZm9ybWFuY2UsIGEgdGFibGUgY2FuIGJlCisgICBzcGVjaWZpZWQgYXMgPGxp
bmsgbGlua2VuZD0ic3FsLWNyZWF0ZXRhYmxlLXRlbXBvcmFyeSI+dGVtcG9yYXJ5PC9saW5rPgor
ICAgb3IgPGxpbmsgbGlua2VuZD0ic3FsLWNyZWF0ZXRhYmxlLXVubG9nZ2VkIj51bmxvZ2dlZDwv
bGluaz4uCisgIDwvcGFyYT4KKwogICA8cGFyYT4KICAgIElmIGEgc2NoZW1hIG5hbWUgaXMgZ2l2
ZW4gKGZvciBleGFtcGxlLCA8bGl0ZXJhbD5DUkVBVEUgVEFCTEUKICAgIG15c2NoZW1hLm15dGFi
bGUgLi4uPC9saXRlcmFsPikgdGhlbiB0aGUgdGFibGUgaXMgY3JlYXRlZCBpbiB0aGUgc3BlY2lm
aWVkCi0tIAoyLjUxLjAKCg==


--=-qlcQ4YIVkv4XCxhzj8xS--