Message-ID: <cc145d1a-a245-3a14-c9d6-c6300b2872a3@enterprisedb.com>
Date: Wed, 28 Jun 2023 23:45:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: POC, WIP: OR-clause support for indexes
Content-Language: en-US
To: Ranier Vilela <ranier.vf@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Cc: "Lena.ribackina@yandex.ru" <Lena.ribackina@yandex.ru>,
 Marcos Pegoraro <marcos@f10.com.br>
References: <CAEudQAq8K=mK-Rm5F1v6csKbghbyyfkanQkWL5k5oUGfjJ6GnQ@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <CAEudQAq8K=mK-Rm5F1v6csKbghbyyfkanQkWL5k5oUGfjJ6GnQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/cc145d1a-a245-3a14-c9d6-c6300b2872a3%40enterprisedb.com>
Precedence: bulk

On 6/27/23 20:55, Ranier Vilela wrote:
> Hi,
> 
>>I finished writing the code patch for transformation "Or" expressions to
>>"Any" expressions. I didn't see any problems in regression tests, even
>>when I changed the constant at which the minimum or expression is
>>replaced by any at 0. I ran my patch on sqlancer and so far the code has
>>never fallen.
> Thanks for working on this.
> 
> I took the liberty of making some modifications to the patch.
> I didn't compile or test it.
> Please feel free to use them.
> 

I don't want to be rude, but this doesn't seem very helpful.

- You made some changes, but you don't even attempt to explain what you
changed or why you changed it.

- You haven't even tried to compile the code, nor tested it. If it
happens to compile, wow could others even know it actually behaves the
way you wanted?

- You responded in a way that breaks the original thread, so it's not
clear which message you're responding to.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company