public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Aleksander Alekseev <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: David Rowley <[email protected]>
Subject: Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
Date: Thu, 12 Jan 2023 08:34:25 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAJ7c6TM2=08mNKD9aJg8vEY9hd+G4L7+Nvh30UiNT3kShgRgNg@mail.gmail.com>
	<[email protected]>
	<CAJ7c6TO8VcipfRwEA1B3o1bzr2qsvm-vaTM4ghyD7HJJFR2nKw@mail.gmail.com>
	<[email protected]>

On 07.01.23 08:21, Peter Eisentraut wrote:
> On 23.11.22 14:57, Aleksander Alekseev wrote:
>> Hi Andres,
>>
>> Thanks for the review!
>>
>>> I don't think it is correct for any of these to add const. The only 
>>> reason it
>>> works is because of casting etc.
>>
>> Fair enough. PFA the corrected patch v2.
> 
> This patch version looks correct to me.  It is almost the same as the 
> one that Andres had posted in his thread, except that yours also 
> modifies slist_delete() and dlist_member_check().  Both of these changes 
> also look correct to me.

committed

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox