Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJut1-0006pD-8Z for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Aug 2022 10:48:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oJut0-0006jn-6A for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Aug 2022 10:48:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJusz-0006gg-Og for pgsql-hackers@lists.postgresql.org; Fri, 05 Aug 2022 10:48:57 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJusx-0000SN-2a for pgsql-hackers@postgresql.org; Fri, 05 Aug 2022 10:48:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1659696535; x=1691232535; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TP29cl5BrrHGNiFqst2NGfGDb9fBHrbcegh4R7hoFog=; b=KYta0iDCS1BqGHtpcCSfE0scKyVntQpIHtLLqn52EQmbRPTyl7z/YXhu gGkEupwvAm3p/2MMjGiVC5CfZvwhonzs6Gc8Iy/NdmAyUAa6uPdE45rDh DvSBCh0YOVLZjfLhpqQiVif0mVT3HO/ECm6mq1j1cgA7DbXNbWTWnp+D3 o=; Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1box-d-0e176545.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 10:48:43 +0000 Received: from EX13D03EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1box-d-0e176545.us-east-1.amazon.com (Postfix) with ESMTPS id 9078983842; Fri, 5 Aug 2022 10:48:41 +0000 (UTC) Received: from [192.168.1.84] (10.43.162.134) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Fri, 5 Aug 2022 10:48:37 +0000 Message-ID: Date: Fri, 5 Aug 2022 12:48:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers Content-Language: en-US To: Jacob Champion , Robert Haas CC: Tom Lane , Michael Paquier , "sfrost@snowman.net" , "rjuju123@gmail.com" , "pgsql-hackers@postgresql.org" , "andres@anarazel.de" References: <20220329235332.z4q5hgv7jsmcavzv@alap3.anarazel.de> <300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com> <200677.1654265052@sss.pgh.pa.us> <3b678314-054a-6119-b373-4574067f404e@timescale.com> From: "Drouvot, Bertrand" In-Reply-To: <3b678314-054a-6119-b373-4574067f404e@timescale.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.162.134] X-ClientProxiedBy: EX13D03UWC003.ant.amazon.com (10.43.162.79) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 8/2/22 11:57 PM, Jacob Champion wrote: > On 6/22/22 06:31, Drouvot, Bertrand wrote: >> FWIW, I just created a new thread to expose the port->authn_id through >> the SYSTEM_USER sql reserved word. > Review for both seems to have dried up a bit. I'm not particularly > invested in my code, but I do want to see *a* solution go in. So if it > helps the review momentum for me to withdraw this patch and put my > effort into SYSTEM_USER, I can do that no problem. > > Thoughts from prior reviewers? Is SYSTEM_USER the way to go? I did not look in detail to this thread, but if the goal is "only" to expose authn_id (as the subject describes) then it seems to me that SYSTEM_USER [1] is the way to go. [1]: https://commitfest.postgresql.org/39/3703/ -- Bertrand Drouvot Amazon Web Services: https://aws.amazon.com