Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vdFGT-00FomT-0a for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jan 2026 22:10:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vdFGS-00AkEH-0C for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jan 2026 22:10:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vdFGR-00AkE9-23 for pgsql-hackers@lists.postgresql.org; Tue, 06 Jan 2026 22:10:56 +0000 Received: from mail-dl1-x122f.google.com ([2607:f8b0:4864:20::122f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vdFGQ-004bNE-2U for pgsql-hackers@postgresql.org; Tue, 06 Jan 2026 22:10:55 +0000 Received: by mail-dl1-x122f.google.com with SMTP id a92af1059eb24-11f2eac9726so274078c88.1 for ; Tue, 06 Jan 2026 14:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1767737453; x=1768342253; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=WkuFciqSe7+maF8tDhD2asOISVrVSZA32S6MOnBP0lw=; b=OiI1FhsznHHtp4/qDjAkgR5EvEv3Dn4kXMCQ0so5ZMsrDNg76XpzT45+CVT3gazgEO Ko3dDIwv2bxYWJADcdaisyUyb1c5qhZ0vyTVaXT6hqEn82RfpzwxSlpH0bk2Kv1TzT6F evfAQ+zVgEJVgtP7qdc4XHNtXwda3zHoUABNyRmGsV/lcWIV3RhFX0j80bwWMt3tmVed MCP2v9qSeBCuk97OeUtVsKWFWEhd5c5p+3TGQ1RhUHm5nFP4cu1wAIe4XZ0gsK95UeWY jDg5KhR4GYghyPjYjMeOmN1hjOpZ/IG97Avgzg5DXm9vJ6Jj3dapqgdFG3GA5ch9Xok4 8Fyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767737453; x=1768342253; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WkuFciqSe7+maF8tDhD2asOISVrVSZA32S6MOnBP0lw=; b=i6954AZ2DGIYYEfLXKY+qw2PlTLqt6phYRvuj7oTTIr2A25kvL6sgDo6ujljxJeZPX hvKkseL0LzchWSqsefPgZIOK3IcO/3IelDeDEGG2FJsVFEYGj+LoDrdqp6Z9Dnq35/0a jNeEScw9bbCrrw6ZbhC8/xGa7SBGReRXAlGd5h4hjrVqWICccAQ5Ev2GzFMuUgOBltEE Uk6OlICYNW+ByosZkTVW2yhwnvLvh9s12TwELUExGhXRxQBt3qe7o/lJaoh5HOQHQV8p PXOXE5KTYYgyXsBNdBMDfT+K3Hpv3mELzlZ/9Rg0/Cv2v0/X6NPHLk+vULoAcrpJdz1b t89w== X-Forwarded-Encrypted: i=1; AJvYcCWIvWvYkmbMF0bziW3xBU18hU1I4P6IY3nx3WxtTsDxgkQR4YTZ/+zCaaY44yfO8mpq67jBfPDmB/BAbybS@postgresql.org X-Gm-Message-State: AOJu0YwnFkzllWJz9kfo20ghm77WaG+fyxx0+/rgJM4oxf+FI5EQgV2C haurNXUE4Ku5tmJpPFj/EI3ijfHWSeFVuQDB/Wf54iiySzOIYZ07PJPTMMNPTRj1O3DvZXC8xE3 rWYM= X-Gm-Gg: AY/fxX7kSHLK/00iS534bZLULtnvAiqmySpjCvSYyhxDVqjwzqgGCq0HhrxMTsQLwNk I2oFEJCXdI39ia9uLk93cejPOxJU+EZdIno8uUFihak2oPNgvr5T+1fKYmyl7y9jmqPhFnJhmvQ A94JkzM3UaM8YbzGjymjPmJyRkL38hL7DY7NKLZRPes7oixse6EnVwVHqxJWKWjr3hAKOhqdUV8 pAPhNye6Y3d8vkEUgbMLEaoP0emwVrQsY8AwplMHj+hNAS9/NtoZjTSj+HvQuYQEV7z7hNwzYWA iNSh7tBbuJO6Mm40yYQ+cXCoW/9v6rQRkFinkJUxEyTRj4C6vNIK+0HEC0g0mesfaPLRihpbhFf JTXeq3MVuVLcOav8bchZNU/Phjnm3GoK0FiMuqEA1CifhCu3OoTRkfkBsBzkAAzNFdDyiC4H45Q N2HHfpGz3DeTLZMti5oRfKHjhFs+KrPfRCo6crm5pNKDdZJ5P6GiihDQ== X-Google-Smtp-Source: AGHT+IF663fXDcLc2j8kMdBAeoBLItIUWZonJMjI6/jJt8YqbTkOBSZnV8IoAa79ZMdsI3UHkUkbEg== X-Received: by 2002:a05:7022:429b:b0:119:e569:f850 with SMTP id a92af1059eb24-121f1adaf6cmr3674451c88.7.1767737453241; Tue, 06 Jan 2026 14:10:53 -0800 (PST) Received: from jeff-ws-bridge.lan (c-24-7-19-3.hsd1.ca.comcast.net. [24.7.19.3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121f24985d1sm7816321c88.16.2026.01.06.14.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 14:10:52 -0800 (PST) Message-ID: Subject: Re: Speed up ICU case conversion by using ucasemap_utf8To*() From: Jeff Davis To: Andreas Karlsson , zengman , pgsql-hackers Date: Tue, 06 Jan 2026 14:10:51 -0800 In-Reply-To: <5a010b27-8ed9-4739-86fe-1562b07ba564@proxel.se> References: <167986ff-afcf-4542-94c6-61ee8474e138@proxel.se> <72c7c2b5848da44caddfe0f20f6c7ebc7c0c6e60.camel@j-davis.com> <4cfde442-25dd-495f-8d76-a23502ce17b8@proxel.se> <744b9998-4463-4be5-b60e-a960eeb43202@proxel.se> <5a010b27-8ed9-4739-86fe-1562b07ba564@proxel.se> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, 2026-01-03 at 04:12 +0100, Andreas Karlsson wrote: > On 1/3/26 4:05 AM, zengman wrote: > > I don't have any major objections, but I noticed a few minor > > details that might need a bit more tweaking. > >=20 > > `signficant`=C2=A0 -> `significant` > > `realtively`=C2=A0 ->=C2=A0 `relatively` > > `if (status !=3D U_BUFFER_OVERFLOW_ERROR && U_FAILURE(status))` -> > > `if (U_FAILURE(status) && status !=3D U_BUFFER_OVERFLOW_ERROR)` > Fixed, thanks! Committed, thank you! Regards, Jeff Davis