public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Jelte Fennema <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Jesse Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Tue, 14 Feb 2023 11:46:24 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGECzQQ-_Uabcrv_0RaVqUagtOAAbKmxN8NRWsDqu8DU=dGpZg@mail.gmail.com>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
<CA+TgmoYTg4avVbkzhhQi3Z-HoxsAvtD=tZiSdWZU9avF_2ouZA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
<[email protected]>
<TYAPR01MB6315B86619944D4A6B56842DFDDE9@TYAPR01MB6315.jpnprd01.prod.outlook.com>
<CAGECzQT44xN-zcTQ0+OxLpWa9nONxmEaYxQpaWM+My+A4o72PA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAGECzQTGVef30yn=Yvs+dVWoOR2X0b2oLbrJxo36-3tyn1VnOQ@mail.gmail.com>
<[email protected]>
<CAGECzQQ-_Uabcrv_0RaVqUagtOAAbKmxN8NRWsDqu8DU=dGpZg@mail.gmail.com>
On 2023-02-13 Mo 13:29, Jelte Fennema wrote:
> On Mon, 13 Feb 2023 at 17:47, Andrew Dunstan<[email protected]> wrote:
>> OK, but I'd like to hear from more people about what they want. Experience tells me that making assumptions about how people work is not a good idea. I doubt anyone's work pattern is like mine. I don't want to implement an option that three people are going to use.
>
> In the general case I agree with you. But in this specific case I
> don't. To me the whole point of this email thread is to nudge people
> towards indenting the changes that they are committing. Thus indenting
> those changes (either before or after adding) is the workflow that we
> want to make as easy as possible. Because even if it's not people
> their current workflow, by adding the flag it hopefully becomes their
> workflow, because it's so easy to use. So my point is we want to
> remove as few hurdles as possible for people to indent their changes
> (and setting up git aliases or pre-commit hooks are all hurdles).
(ITYM "remove as many hurdles as possible"). It remains to be seen how
much easier any of this will make life for committers, at least. But I
concede this might make life a bit simpler for developers generally.
Anyway, let's talk about the details of what is proposed.
So far, we have had the following categories suggested: dirty, staged,
dirty+staged, untracked. Are there any others?
Another issue is whether or not to restrict these to files under the
current directory. I think we probably should, or at least provide a
--relative option.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox