Subject: Re: pg11+: pg_ls_*dir LIMIT 1: temporary files .. not closed at
 end-of-transaction
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Fabien COELHO
 <coelho@cri.ensmp.fr>, pgsql-hackers@postgresql.org,
 Alvaro Herrera <alvherre@2ndquadrant.com>, David Steele
 <david@pgmasters.net>, "Bossart, Nathan" <bossartn@amazon.com>,
 Thomas Munro <thomas.munro@gmail.com>
References: <24244.1585415634@sss.pgh.pa.us>
 <20200328183904.GI20103@telsasoft.com> <28906.1585422475@sss.pgh.pa.us>
 <27064.1585499825@sss.pgh.pa.us> <20200329171415.GL20103@telsasoft.com>
 <29512.1585502524@sss.pgh.pa.us> <20200329201215.GM20103@telsasoft.com>
 <alpine.DEB.2.21.2003300704430.16227@pseudo> <4028.1585579463@sss.pgh.pa.us>
 <alpine.DEB.2.21.2003310723560.16227@pseudo>
 <20200331080643.GE14618@telsasoft.com> <11882.1585672910@sss.pgh.pa.us>
 <83048c77-2531-48cb-aa2b-aa01cc5af519@gmail.com>
 <396837.1605298573@sss.pgh.pa.us>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <ccd33e2c-9816-6c04-1cf7-031218bbc035@gmail.com>
Date: Fri, 13 Nov 2020 23:30:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <396837.1605298573@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

13.11.2020 23:16, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> Shouldn't pg_ls_dir_files() retry stat() on ERROR_ACCESS_DENIED just
>> like the pgwin32_open() does to ignore files in "delete pending" state?
> That would soon lead us to changing every stat() caller in the system
> to have Windows-specific looping logic.  No thanks.  If we need to do
> this, let's put in a Windows wrapper layer comparable to pgwin32_open()
> for open().
Maybe pgwin32_safestat() should perform this... For now it checks
GetLastError() for ERROR_DELETE_PENDING, but as we've found out
previously this error code in fact is not returned by the OS.
And if the fix is not going to be quick, probably it should be discussed
in another thread...

Best regards,
Alexander