Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wGWFT-006IeN-2K for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Apr 2026 06:12:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wGWFS-008MnH-32 for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Apr 2026 06:12:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wGWFS-008Mn9-0j for pgsql-hackers@lists.postgresql.org; Sat, 25 Apr 2026 06:12:14 +0000 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wGWFP-00000002wT6-2PMQ for pgsql-hackers@postgresql.org; Sat, 25 Apr 2026 06:12:13 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 899301400138; Sat, 25 Apr 2026 02:12:09 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Sat, 25 Apr 2026 02:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1777097529; x=1777183929; bh=pZJIui0Aq4B4HcDui0We1A6jQBSk80xWn/zdwp+AcKM=; b= bgI3QcWOZGYT74sSdouYLskxTp4aBJieXt/xML+6RFCXuVkeAOPJccZNSdXbaKgh YFtwyC1mzvcVHe4OC/BizzQ6BnIAIR77glzVSlmwMiuljwNpkQg8tVmHfrF0uJ35 1Jo5QJeSmLi+ynXcy60PUK7bXqPdrddtqoy8upZEYlT0jcNe6jOBfwGhQKTCc0vy CgKTd/MRlzU4lyo7M2uAxL47AMuxLR5KWpj5c9pxCoGNhuNdvZ+cofvMxdc1/iDx yU3xqdq9T44s1qwoxIJtT8BHErGr5eWg8YDu1awCA6yPZZ/lj67fm1icD7XvJjDj xV77tBeOA/iIm16C5lQK6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1777097529; x=1777183929; bh=p ZJIui0Aq4B4HcDui0We1A6jQBSk80xWn/zdwp+AcKM=; b=UrvMRSp3fryb7fOwe 5lBWTAd1wlFSenZf2YPPWlFhGHuI5J+mANrM1z09PSUYEGPoa+SjqFhRoolG13QJ 8ewHEe8WkaZzGq4raMdO6ywIk9dUduKqBsdzp49vcujOnQHBpodRPeO/08jLvmaK U+2q2j6ACBECq+wAYHAssTjNrXI5QvtgwgTb+6pZyyFoKpz6XCF0VMoF2ippvfGE qQvg4ed1g1YdRjtYKlLTPaGhQ3yrG6F+KWNzwELnywPksxtUOkDOMLCi+1rPmklL BJ9FacTGtJAe7h67dZOthwHFDzjBljkLhhbx0svkzgyfkAWJ1not/q4tZ52Prv8D WuYYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdejvdduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttd dvjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghi shgvnhhtrhgruhhtrdhorhhgqeenucggtffrrghtthgvrhhnpeehiedvhfeuhfeugefgfe ehgeejtdevuefhtefhueefvddugfdtueehgfefudfhffenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuth drohhrghdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepphhgshhqlhesjhdquggrvhhishdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrg gtkhgvrhhssehpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Apr 2026 02:12:08 -0400 (EDT) Message-ID: Date: Sat, 25 Apr 2026 08:12:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: small cleanup patches for collation code To: Jeff Davis , pgsql-hackers@postgresql.org References: <581a72ff452bb045ba83bbe3c6cf4467702d4f0f.camel@j-davis.com> Content-Language: en-US From: Peter Eisentraut In-Reply-To: <581a72ff452bb045ba83bbe3c6cf4467702d4f0f.camel@j-davis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 17.04.26 21:30, Jeff Davis wrote: > Two patches attached. > > 0001 fixes a style issue. Backport because it eliminates a warning in > the 'update-unicode' target. These warning options were only added in PG19, so backpatching is not necessary. > 0002 looks like a bug, but is not a real issue because there are no > callers that pass srclen==-1, aside from a test (which fails to fail). > So it's just cleanup, but it seems worth backporting. That looks right.