public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nikita Glukhov <[email protected]>
To: Pavel Stehule <[email protected]>
To: PostgreSQL-development <[email protected]>
Cc: Erik Rijkers <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andrew Alsup <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Dmitry Dolgov <[email protected]>
Cc: Oleg Bartunov <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Simon Riggs <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Subject: Re: SQL/JSON: functions
Date: Tue, 17 Mar 2020 03:55:06 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFj8pRBLk2Nhh692v1Zg0jgOdppreurVDBQt-_pj+CDEHE+HxA@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CAFj8pRBpkMC6+iSVA_k_ByAjeA2PEgixAsSiuAWy+uYp67ucbA@mail.gmail.com>
<[email protected]>
<CAFj8pRCnzO2cnHi5ebXciV=tuGVvAQOW9uPU+DQV1GkL31R=-g@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAFj8pRCj3fnGRe8Jj6QOUR_ohs=0DdYQ_mFSopJw=jgdfwgWKQ@mail.gmail.com>
<[email protected]>
<CAFj8pRBLk2Nhh692v1Zg0jgOdppreurVDBQt-_pj+CDEHE+HxA@mail.gmail.com>
Attached 44th version of the patches.
On 12.03.2020 16:41, Pavel Stehule wrote:
>
> On 12.03.2020 00:09 Nikita Glukhov wrote:
>
> Attached 43rd version of the patches.
>
> The previous patch #4 ("Add function formats") was removed.
> Instead, introduced new executor node JsonCtorExpr which is used to wrap
> SQL/JSON constructor function calls (FuncExpr, Aggref, WindowFunc).
>
> Also, JsonIsPredicate node began to be used as executor node.
> This helped to remove unnecessary json[b]_is_valid() user functions.
>
>
> It looks very well - all tests passed, code looks well.
>
> Now, when there are special nodes, then the introduction of
> COERCE_INTERNAL_CAST is not necessary, and it is only my one and last
> objection again this patch's set.
>
I have removed patch #3 with COERCE_INTERNAL_CAST too.
Coercions in JsonValueExpr in JsonCtorExpr, which were previously hidden with
COERCE_INTERNAL_CAST and which were outputted as RETURNING or FORMAT JSON
clauses, now moved into separate expressions.
User functions json[b]_build_object_ext() and json[b]_build_array_ext() also
can be easily removed. But it seems harder to remove new aggregate functions
json[b]_objectagg() and json[b]_agg_strict(), because they can't be called
directly from JsonCtorExpr node.
The support for json type in jsonpath also seems to be immature, so I will try
to remove it in the next iteration.
--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
[application/gzip] 0001-Jsonpath-support-for-json-v44.patch.gz (43.6K, ../[email protected]/3-0001-Jsonpath-support-for-json-v44.patch.gz)
download
[application/gzip] 0002-Add-common-SQL-JSON-clauses-v44.patch.gz (7.5K, ../[email protected]/4-0002-Add-common-SQL-JSON-clauses-v44.patch.gz)
download
[application/gzip] 0003-SQL-JSON-constructors-v44.patch.gz (30.4K, ../[email protected]/5-0003-SQL-JSON-constructors-v44.patch.gz)
download
[application/gzip] 0004-IS-JSON-predicate-v44.patch.gz (12.6K, ../[email protected]/6-0004-IS-JSON-predicate-v44.patch.gz)
download
[application/gzip] 0005-SQL-JSON-query-functions-v44.patch.gz (39.4K, ../[email protected]/7-0005-SQL-JSON-query-functions-v44.patch.gz)
download
view thread (136+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: SQL/JSON: functions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox