Feedback-ID: ie0a040ee:Fastmail
Message-ID: <cd10c5b9-3690-44b2-a505-3cb833ac31cd@eisentraut.org>
Date: Mon, 27 Apr 2026 12:04:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: FOR PORTION OF gram.y target_location seems wrong
To: jian he <jian.universality@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Paul A Jungwirth <pj@illuminatedcomputing.com>
References: 
 <CACJufxEKdga8bEE4mkMDVYJ78V_7Orj7M8FcsYk_VnsY4Bv4aA@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CACJufxEKdga8bEE4mkMDVYJ78V_7Orj7M8FcsYk_VnsY4Bv4aA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/cd10c5b9-3690-44b2-a505-3cb833ac31cd%40eisentraut.org>
Precedence: bulk

On 24.04.26 03:10, jian he wrote:
> Hi.
> 
> | FOR PORTION OF ColId FROM a_expr TO a_expr
>      {
>          ForPortionOfClause *n = makeNode(ForPortionOfClause);
>          n->range_name = $4;
>          n->location = @4;
>          n->target_start = $6;
>          n->target_end = $8;
>          n->target_location = @5;
>          $$ = (Node *) n;
>      }
> 
> n->target_location = @5;
> 
> Should be
> 
> n->target_location = @6;

I think the existing code is fine.  The target consists of the start and 
the end value.  If we pointed to @6 then one could be confused into 
thinking that only the start value is meant.