Content-Type: multipart/alternative;
 boundary="------------vOQU0m2RgsiNjBbUNjmE3IEF"
Message-ID: <cd2780c6-8a84-45f2-8f20-b66688c00c8f@dunslane.net>
Date: Tue, 4 Mar 2025 19:13:19 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: scalability bottlenecks with (many) partitions (and more)
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Tomas Vondra <tomas@vondra.me>,
 Jakub Wartak <jakub.wartak@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <7c1eeafb-2375-4ff6-8469-0640d52d44ed@vondra.me>
 <ffiwtzc6vedo6wb4gbwelon5nefqg675t5c7an2ta7pcz646cg@qwmkdb3l4ett>
 <bfca1010-e5f1-4e36-a461-61b6aad60c47@vondra.me>
 <5xahykogf2sg3ofdqk2li7xx3t2vh23m42jnvfwxoi5fhh7iya@girlhoxdxjzc>
 <486baeb2-2adc-48d2-ba9d-13c4ae43301c@vondra.me>
 <vgtms7b5egxdypmknxpobocqton3puhprk3ahhk45rcx4uyl33@6uetxejsc75r>
 <733e72fa-5fc2-48fc-ab1f-1d8f1ab387c3@vondra.me>
 <d5499660-1541-4749-aff4-6be88be76d99@vondra.me>
 <nubyc3twqd7mtuyc2rbbt2yazjzbat6mlpfgxtb2ppv2egci3g@uvptf7xmh46m>
 <193453.1741123834@sss.pgh.pa.us>
 <qdvrgej743lcddjnb4lzyakt3f5bs2oz34r274wbmgc2g4474q@utqqrqiih65h>
 <197167.1741125678@sss.pgh.pa.us>
 <8a1a5c10-0644-4ea0-a9e8-73d3a2908e18@dunslane.net>
 <200085.1741127335@sss.pgh.pa.us>
 <947e4acd-94b9-4990-83f5-874c71d69b17@dunslane.net>
 <203685.1741129474@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <203685.1741129474@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/cd2780c6-8a84-45f2-8f20-b66688c00c8f%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------vOQU0m2RgsiNjBbUNjmE3IEF
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2025-03-04 Tu 6:04 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net> writes:
>> Will check your patch out too.
> Comparing previous run against current, I now see that my patch
> caused it to skip these steps:
>
> module-ldap_password_func-check
> module-pg_bsd_indent-check
> contrib-sepgsql-check
>
> Skipping the ldap and sepgsql tests is desirable, but it shouldn't
> have skipped pg_bsd_indent.  I think the cause of that is that
> src/tools/pg_bsd_indent isn't built in any of the previous build
> steps.  Up to now it got built as a side-effect of invoking the
> tests, which isn't great because any build errors/warnings disappear
> into the install log which the script doesn't capture.  I agree
> with not capturing the install log, because that's generally
> uninteresting once we get past make-install; but we have to be sure
> that everything gets built before that.


Yeah ... I think an easy fix is to put this in make_testmodules():


+
+       # build pg_bsd_indent at the same time
+       # this doesn't really belong here, but it's convenient
+       if (-d "$pgsql/src/tools/pg_bsd_indent" && !$status)
+       {
+               my @indentout = run_log("cd 
$pgsql/src/tools/pg_bsd_indent && $make_cmd");
+               $status = $? >> 8;
+               push(@makeout,@indentout);
+       }


A lot of this special processing goes away when we're building with meson.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------vOQU0m2RgsiNjBbUNjmE3IEF
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2025-03-04 Tu 6:04 PM, Tom Lane
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:203685.1741129474@sss.pgh.pa.us">
      <pre wrap="" class="moz-quote-pre">Andrew Dunstan <a class="moz-txt-link-rfc2396E" href="mailto:andrew@dunslane.net">&lt;andrew@dunslane.net&gt;</a> writes:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">Will check your patch out too.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Comparing previous run against current, I now see that my patch
caused it to skip these steps:

module-ldap_password_func-check 
module-pg_bsd_indent-check 
contrib-sepgsql-check 

Skipping the ldap and sepgsql tests is desirable, but it shouldn't
have skipped pg_bsd_indent.  I think the cause of that is that
src/tools/pg_bsd_indent isn't built in any of the previous build
steps.  Up to now it got built as a side-effect of invoking the
tests, which isn't great because any build errors/warnings disappear
into the install log which the script doesn't capture.  I agree
with not capturing the install log, because that's generally
uninteresting once we get past make-install; but we have to be sure
that everything gets built before that.</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Yeah ... I think an easy fix is to put this in
      make_testmodules():</p>
    <p><br>
    </p>
    <p>+<br>
      +       # build pg_bsd_indent at the same time<br>
      +       # this doesn't really belong here, but it's convenient <br>
      +       if (-d "$pgsql/src/tools/pg_bsd_indent" &amp;&amp;
      !$status)<br>
      +       {<br>
      +               my @indentout = run_log("cd
      $pgsql/src/tools/pg_bsd_indent &amp;&amp; $make_cmd");<br>
      +               $status = $? &gt;&gt; 8;<br>
      +               push(@makeout,@indentout);<br>
      +       }<br>
    </p>
    <p><br>
    </p>
    <p>A lot of this special processing goes away when we're building
      with meson.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------vOQU0m2RgsiNjBbUNjmE3IEF--