Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5Kvu-0001sz-4R for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Jul 2021 04:31:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Kvt-0007ra-4t for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Jul 2021 04:31:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5Kvs-0007rR-TK for pgsql-hackers@lists.postgresql.org; Mon, 19 Jul 2021 04:31:08 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5Kvn-0006D1-Pj for pgsql-hackers@postgresql.org; Mon, 19 Jul 2021 04:31:07 +0000 Received: from hnk.local (p2388012-ipbf1027funabasi.chiba.ocn.ne.jp [118.6.6.12]) by oss.nttdata.com (Postfix) with ESMTPSA id 43243612D4; Mon, 19 Jul 2021 13:31:00 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at oss.nttdata.com Subject: Re: Doc necessity for superuser privileges to execute pg_import_system_collations() To: torikoshia , Pgsql Hackers References: From: Fujii Masao Message-ID: Date: Mon, 19 Jul 2021 13:30:59 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021/07/19 11:45, torikoshia wrote: > Hi. > > It seems that only superusers can execute pg_import_system_collations(), but this is not mentioned in the manual. > > Since other functions that require superuser privileges describe that in the manual, I think it would be better to do the same for consistency. > > Thoughts? LGTM. IMO it's better to back-patch this to v10 where pg_import_system_collations() was added. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION