Content-Type: multipart/alternative;
 boundary="------------NzR3dVVKChJSaa6K9YiVpDDI"
Message-ID: <cd8627b5-8387-424d-9ff0-868ba8efd6f0@postgrespro.ru>
Date: Sun, 3 Mar 2024 12:48:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
To: Alexander Korotkov <aekorotkov@gmail.com>,
 Andrei Lepikhov <a.lepikhov@postgrespro.ru>,
 jian he <jian.universality@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, "Finnerty, Jim" <jfinnert@amazon.com>,
 Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>, Ranier Vilela <ranier.vf@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <CACJufxH-zju3VfosSRBu8d3xs99sGENn6+P3AETLuTiAPFY+0g@mail.gmail.com>
 <5f119769-ab11-4807-abcc-71d5dd914ea0@postgrespro.ru>
 <CACJufxFMFoosvbuFYDiFtpam4sKCSGJeh5jYiZSY8PHjCpEHYA@mail.gmail.com>
 <cf0d1615-b594-404d-9a23-3d8ffd9070ec@postgrespro.ru>
 <CAEudQAq4XTcwhw2OmfW1AJNqvMfbReEWjuzqv6YTz6ZjbpmL0g@mail.gmail.com>
 <21088129-7cd3-424a-bcce-6a3427ba3276@postgrespro.ru>
 <CAEudQArk002t_C9LGoeJWnw=iGKikt+gSa8Mh==muG00WS=qYA@mail.gmail.com>
 <CACJufxFhQn0awSEcZD7=FHvjx6OLt6PUtuoi0_10pWFVXUEDJw@mail.gmail.com>
 <ded629b2-7885-4be2-b5f5-9426ff47f72c@postgrespro.ru>
 <11ee9c04-281f-43c8-a0ff-d481c1e01c09@postgrespro.ru>
 <CACJufxGqLA32zTtaJRL2Cacp771k6PJnau7gsax0KRV434Qq7w@mail.gmail.com>
 <54009ba5-4aea-4344-a30d-e3558a59e2a9@postgrespro.ru>
 <380e5683-cdfd-4220-ab9b-7cccb9d3e480@postgrespro.ru>
 <CAPpHfds=4kTMhrdijV2hxL4o1ffyceZ+p95KxnF2zBTOb12LWg@mail.gmail.com>
 <ce5ccf07-33fa-48ba-8597-68520d89c230@postgrespro.ru>
In-Reply-To: <ce5ccf07-33fa-48ba-8597-68520d89c230@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/cd8627b5-8387-424d-9ff0-868ba8efd6f0%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------NzR3dVVKChJSaa6K9YiVpDDI
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Sorry, I found explanation - 
https://www.postgresql.org/message-id/CACJufxFS-xcjaWq2Du2OyJUjRAyqCk12Q_zGOPxv61sgrdpw9w%40mail.gmail.com

On 03.03.2024 12:26, Alena Rybakina wrote:
>
> I found that it was mentioned here - 
> https://www.postgresql.org/message-id/CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu%2BHsVA%40mail.gmail.com.
>
> To be honest, I couldn't find any explanation for that.
>
> On 01.03.2024 18:33, Alexander Korotkov wrote:
>> Hi, Andrei,
>> Hi, Alena!
>>
>> On Thu, Feb 29, 2024 at 10:59 AM Andrei Lepikhov 
>> <a.lepikhov@postgrespro.ru> wrote:
>>
>>     On 28/2/2024 17:27, Alena Rybakina wrote:
>>     > Maybe like that:
>>     >
>>     > It also considers the way to generate a path using BitmapScan
>>     indexes,
>>     > converting the transformed expression into expressions
>>     separated by "OR"
>>     > operations, and if it turns out to be the best and finally
>>     selects the
>>     > best one.
>>     Thanks,
>>     I spent some time describing the feature with documentation.
>>     A condensed description of the GUC is in the runtime-config file.
>>     Feature description has spread between TransformOrExprToANY and
>>     generate_saop_pathlist routines.
>>     Also, I've made tiny changes in the code to look more smoothly.
>>     All modifications are integrated into the two new patches.
>>
>>     Feel free to add, change or totally rewrite these changes.
>>
>>
>> I'm going to review and revise the patch.
>>
>> One question I have yet.
>>
>> >        /*
>> >         * Transformation only works with both side type is not
>> >         * { array | composite | domain | record }.
>>
>> Why do we limit transformation for these types?  Also, it doesn't 
>> seem the current code restricts anything except composite/record.
>>
>> ------
>> Regards,
>> Alexander Korotkov
> -- 
> Regards,
> Alena Rybakina
> Postgres Professional:http://www.postgrespro.com
> The Russian Postgres Company

-- 
Regards,
Alena Rybakina
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company

--------------NzR3dVVKChJSaa6K9YiVpDDI
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Sorry, I found explanation -
<a class="moz-txt-link-freetext" href="https://www.postgresql.org/message-id/CACJufxFS-xcjaWq2Du2OyJUjRAyqCk12Q_zGOPxv61sgrdpw9w%40mail.gmail.com">https://www.postgresql.org/message-id/CACJufxFS-xcjaWq2Du2OyJUjRAyqCk12Q_zGOPxv61sgrdpw9w%40mail.gmail.com</a><br>
    </p>
    <div class="moz-cite-prefix">On 03.03.2024 12:26, Alena Rybakina
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:ce5ccf07-33fa-48ba-8597-68520d89c230@postgrespro.ru">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <p>I found that it was mentioned here -
        <a class="moz-txt-link-freetext"
href="https://www.postgresql.org/message-id/CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu%2BHsVA%40mail.gmail.com"
          moz-do-not-send="true">https://www.postgresql.org/message-id/CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu%2BHsVA%40mail.gmail.com</a>.</p>
      <p>To be honest, I couldn't find any explanation for that. <br>
      </p>
      <div class="moz-cite-prefix">On 01.03.2024 18:33, Alexander
        Korotkov wrote:<br>
      </div>
      <blockquote type="cite"
cite="mid:CAPpHfds=4kTMhrdijV2hxL4o1ffyceZ+p95KxnF2zBTOb12LWg@mail.gmail.com">
        <meta http-equiv="content-type"
          content="text/html; charset=UTF-8">
        <div dir="ltr">
          <div dir="ltr">
            <div>Hi, Andrei,</div>
            <div>Hi, Alena!</div>
            <br clear="all">
            <div>
              <div dir="ltr" class="gmail_signature">
                <div dir="ltr">On Thu, Feb 29, 2024 at 10:59 AM Andrei
                  Lepikhov &lt;<a
                    href="mailto:a.lepikhov@postgrespro.ru"
                    moz-do-not-send="true" class="moz-txt-link-freetext">a.lepikhov@postgrespro.ru</a>&gt;
                  wrote:<br>
                </div>
              </div>
            </div>
          </div>
          <div class="gmail_quote">
            <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On
              28/2/2024 17:27, Alena Rybakina wrote:<br>
              &gt; Maybe like that:<br>
              &gt; <br>
              &gt; It also considers the way to generate a path using
              BitmapScan indexes, <br>
              &gt; converting the transformed expression into
              expressions separated by "OR" <br>
              &gt; operations, and if it turns out to be the best and
              finally selects the <br>
              &gt; best one.<br>
              Thanks,<br>
              I spent some time describing the feature with
              documentation.<br>
              A condensed description of the GUC is in the
              runtime-config file.<br>
              Feature description has spread between
              TransformOrExprToANY and <br>
              generate_saop_pathlist routines.<br>
              Also, I've made tiny changes in the code to look more
              smoothly.<br>
              All modifications are integrated into the two new patches.<br>
              <br>
              Feel free to add, change or totally rewrite these changes.<br>
            </blockquote>
            <div><br>
            </div>
            <div>I'm going to review and revise the patch.</div>
            <div><br>
            </div>
            <div>One question I have yet.</div>
            <div><br>
            </div>
            <div><font face="monospace">&gt;        /*<br>
                &gt;         * Transformation only works with both side
                type is not<br>
                &gt;         * { array | composite | domain | record }.<br>
              </font></div>
            <div><br>
            </div>
            <div>Why do we limit transformation for these types?  Also,
              it doesn't seem the current code restricts anything except
              composite/record. </div>
            <div><br>
            </div>
            <div>------<br>
              Regards,<br>
              Alexander Korotkov<br
                class="gmail-Apple-interchange-newline">
            </div>
          </div>
        </div>
      </blockquote>
      <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional: <a class="moz-txt-link-freetext"
      href="http://www.postgrespro.com" moz-do-not-send="true">http://www.postgrespro.com</a>
The Russian Postgres Company</pre>
    </blockquote>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional: <a class="moz-txt-link-freetext" href="http://www.postgrespro.com">http://www.postgrespro.com</a>
The Russian Postgres Company</pre>
  </body>
</html>

--------------NzR3dVVKChJSaa6K9YiVpDDI--