Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u0lg9-007Wxr-QH for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Apr 2025 18:22:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u0lg8-003IUP-8p for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Apr 2025 18:22:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u0lg7-003IR4-92 for pgsql-hackers@lists.postgresql.org; Fri, 04 Apr 2025 18:22:07 +0000 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u0lg5-002xhY-0e for pgsql-hackers@postgresql.org; Fri, 04 Apr 2025 18:22:06 +0000 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id E327625400D0; Fri, 4 Apr 2025 14:22:03 -0400 (EDT) Received: from phl-imap-09 ([10.202.2.99]) by phl-compute-05.internal (MEProxy); Fri, 04 Apr 2025 14:22:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1743790923; x=1743877323; bh=OmgPG6/Ivw 5g7xsa75sBt9rIvjT8I7VtbCkxYKkMn+U=; b=Zp2kAgpkWocoUerxxSShAe0iqL 3I+9yWQq/29nBuzmFzhQx97e+Q40WuxM3Rlu4r2taD9zQJExcvUg1+O+1gaFGcay FGa6owF26h8wQ2CUYdkuT5afH6rvueLBXb/LAu8vYVtI21BFeZFMA+mVc3er3FRh 4PKk0qYhk/8xAyJxM6v1BbKfFyKgep1RwRWRg/jqzUPt6zOjtQIdW5VpYlcLiSRU rCI+75sJALLLlIVwJF3HXn/GpAyHFqW34lz1R+EwPa/CygUxJmE/lmZkOJx2ishT 7zVDPdfPnxCwFNkegPIOWYtjNeuPClIbTE5NNsy29AXNJcMozDc7AVWNq4qQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1743790923; x=1743877323; bh=OmgPG6/Ivw5g7xsa75sBt9rIvjT8I7VtbCk xYKkMn+U=; b=I98/qTAj73ETIfrPiiXC8Dok3vlE24+j/iwNt3KBYGqAOPiDuhL 2so/lzKycH1k/ud7caCseClgxCll5mmaig1Fs+27DDpya1u7pbVTUOLb8nkT+U5F SIrYPjh7FQiShee5vL/DqzoSivPCFSFDKAbT5Evsq6a3cKLLaBtRgVpYyT+CkJjx j3+/K+EvWM2tHSI9dixcTKe/C5pLjH50g7fJsdVn4wk3tyXmG0YGvS1YjvhM/bMC Yyv0i3seqRFfIhYJzPTdOupH3X5g5v2zF/ShYCfk2XZiL0LJfM5fHL9S05KgoP0g ycDBx2ZJoU32Gt/vA4TFPCGgnMYS47+zs2w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduledvudehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgesrgdtreerredt tdenucfhrhhomhepfdfguhhlvghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvg hrthhordgtohhmqeenucggtffrrghtthgvrhhnpeekheetvefggedtudevjeehjeffteeu vdfhfedtvdfgleektdfgfeektdfhheekvdenucffohhmrghinhepvghnthgvrhhprhhish gvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepvghulhgvrhesvghulhgvrhhtohdrtghomhdpnhgspghrtghpthhtohepledpmh houggvpehsmhhtphhouhhtpdhrtghpthhtoheprghlvhhhvghrrhgvsegrlhhvhhdrnhho qdhiphdrohhrghdprhgtphhtthhopegrhhestgihsggvrhhtvggtrdgrthdprhgtphhtth hopehmrghrtghoshesfhdutddrtghomhdrsghrpdhrtghpthhtohepphgrvhgvlhdrshht vghhuhhlvgesghhmrghilhdrtghomhdprhgtphhtthhopehrvghshhhkvghkihhrihhllh esghhmrghilhdrtghomhdprhgtphhtthhopeiihhhjfihpkhhusehgmhgrihhlrdgtohhm pdhrtghpthhtohepmhgsrghntghksehgmhigrdhnvghtpdhrtghpthhtohepmhhitghhrg gvlhesphgrqhhuihgvrhdrgiihiidprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhs sehpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id EC68B780069; Fri, 4 Apr 2025 14:22:02 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: T289e41e38bf4a27c Date: Fri, 04 Apr 2025 15:21:41 -0300 From: "Euler Taveira" To: "Antonin Houska" Cc: "Alvaro Herrera" , "Marcos Pegoraro" , "Michael Banck" , "Junwang Zhao" , "Kirill Reshke" , "Pavel Stehule" , "Michael Paquier" , pgsql-hackers Message-Id: In-Reply-To: <55563.1743784734@localhost> References: <202503251432.o6obtgywjow5@alvherre.pgsql> <6059.1743060030@localhost> <104580.1743431185@localhost> <178741.1743514291@localhost> <55563.1743784734@localhost> Subject: Re: why there is not VACUUM FULL CONCURRENTLY? Content-Type: multipart/alternative; boundary=09d3052c22814d1aaa85f9c7722749c9 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --09d3052c22814d1aaa85f9c7722749c9 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, Apr 4, 2025, at 1:38 PM, Antonin Houska wrote: > Euler Taveira wrote: > > > + > > + > > + > > + The FULL parameter is deprecated in favor of > > + . > > + > > + > > + > > > > The warnings, notes, and tips are usually placed *after* the description. > > You probably mean the subsecions "Notes on Clustering" and "Notes on > Resources". I moved them into the "Notes" section. No. I said that it should be put after the not before. @@ -98,6 +98,14 @@ VACUUM [ ( option [, ...] ) ] [ FULL + + + + The FULL parameter is deprecated in favor of + . + + + Selects full vacuum, which can reclaim more space, but takes much longer and exclusively locks the table. > > + SELECT > > + S.pid AS pid, > > + S.datid AS datid, > > + D.datname AS datname, > > + S.relid AS relid, > > + CASE S.param1 WHEN 1 THEN 'REPACK' > > + END AS command, > > > > Do you really need command? IIUC REPACK is the only command that will used by > > this view. There is no need to differentiate commands here. > > REPACK is a regular command, so why shouldn't it have its view? Just like > CLUSTER has one (pg_stat_progress_cluster). You missed my point. IIRC the command is relevant in the pg_stat_progress_cluster because there are multiple commands (CLUSTER, VACUUM FULL). However, in this new view there will be only one command so it is not necessary to inform it. > > + * > > + * 'cmd' indicates which commands is being executed. REPACK should be the only > > + * caller of this function in the future. > > > > command. > > Not sure I understand this comment. Singular form. ... which command is ... -- Euler Taveira EDB https://www.enterprisedb.com/ --09d3052c22814d1aaa85f9c7722749c9 Content-Type: text/html Content-Transfer-Encoding: quoted-printable