Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kY1K5-0005f6-9R for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Oct 2020 06:22:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kY1K3-0006gP-Ff for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Oct 2020 06:22:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kY1K3-0006gI-8n for pgsql-hackers@lists.postgresql.org; Thu, 29 Oct 2020 06:22:07 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kY1Jz-0001U5-AD for pgsql-hackers@postgresql.org; Thu, 29 Oct 2020 06:22:06 +0000 Received: from hnk.local (p1295030-ipngn4902funabasi.chiba.ocn.ne.jp [153.166.85.30]) by oss.nttdata.com (Postfix) with ESMTPSA id E22AC600FA; Thu, 29 Oct 2020 15:21:57 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module To: Bharath Rupireddy Cc: PostgreSQL-development References: <13156732-5189-af54-3d28-e2ee2a8568e0@oss.nttdata.com> <069fb3bc-3907-4d85-19fd-e4b2d2f004b4@oss.nttdata.com> From: Fujii Masao Message-ID: Date: Thu, 29 Oct 2020 15:21:57 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/10/07 11:30, Bharath Rupireddy wrote: > On Tue, Oct 6, 2020 at 11:41 AM Bharath Rupireddy > wrote: >> >> On Tue, Oct 6, 2020 at 11:20 AM Fujii Masao wrote: >>> >>> +1 Or it's also ok to make each patch separately. >>> Anyway, thanks! >>> >> >> Thanks. +1 to have separate patches. I will post two separate patches >> for autoprewarm and WalRcvShutdownHandler for further review. The >> other two patches can be for startup.c and syslogger.c. >> > > I'm attaching all the 4 patches here together. > > 1. v1-use-standard-SIGHUP-and-SIGTERM-handlers-in-autoprewarm-process.patch > -- This is the patch initially sent in this mail by me, I just > renamed it. > 2. v1-use-MyLatch-and-standard-SIGHUP-handler-in-startup-process.patch > -- This is the patch proposed by Fuji Masao, I just renamed it. > 3. v1-use-standard-SIGHUP-hanlder-in-syslogger-process.patch > 4. v1-use-standard-SIGTERM-handler-in-walreceiver-process.patch > > Please consider these patches for further review. Thanks for the patches! They look good to me. So barring any objections, I will commit them one by one. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION