Message-ID: <ce729fa858618fbf36453200e7500c3b15c4cbb6.camel@cybertec.at>
Subject: Re: Restoring default privileges on objects
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: "Peter J. Holzer" <hjp-pgsql@hjp.at>, pgsql-hackers@postgresql.org
Date: Fri, 06 Oct 2023 22:16:28 +0200
In-Reply-To: <20230830100030.oxnegs7cxbzvjizt@hjp.at>
References: <96d6885a-5e25-9ae8-4a1a-d7e557a5fe9c@mtneva.com>
	 <1166048641.281962.1693308151542@office.mailbox.org>
	 <1006397.1693318485@sss.pgh.pa.us>
	 <efdd465d-a795-6188-7f71-7cdb4b2be031@mtneva.com>
	 <1550267563.330669.1693335893138@office.mailbox.org>
	 <31246.1693337238@sss.pgh.pa.us>
	 <e7387e04-0a17-3a77-8e0c-da6794625a30@mtneva.com>
	 <20230830100030.oxnegs7cxbzvjizt@hjp.at>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/ce729fa858618fbf36453200e7500c3b15c4cbb6.camel%40cybertec.at>
Precedence: bulk

On Wed, 2023-08-30 at 12:00 +0200, Peter J. Holzer wrote:
> On 2023-08-29 14:44:48 -0600, Stuart McGraw wrote:
> > On 8/29/23 13:27, Tom Lane wrote:
> > > Fixing \dp to honor "\pset null" for this might be a reasonable
> > > thing to do too.=C2=A0 I'm actually a bit surprised that that doesn't
> > > work already.
> >=20
> > That change would still require someone using \dp to realize that
> > the "Access privileges" value could be either '' or NULL (I guess
> > that could be pointed out more obviously in the psql doc), and then
> > do a '\pset null' before doing \dp?=C2=A0 That seems a little inconveni=
ent.
>=20
> Or just always do a \pset null. For me printing NULL the same as an
> empty string is just as confusing in normal tables, so that's the first
> line in my ~/.psqlrc. YMMV, of course.
>=20
> But I guess the point is that people who do \pset null expect to be able
> to distinguish '' and NULL visually and might be surprised if that
> doesn't work everywhere, while people who don't \pset null know that ''
> and NULL are visually indistinguishable and that they may need some
> other way to distinguish them if the difference matters.
>=20
> So +1 for me fixing \dp to honor "\pset null".

+1

Here is a patch that does away with the special handling of NULL values
in psql backslash commands.

Yours,
Laurenz Albe