Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Fom-0001V9-KV for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Dec 2022 00:40:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p5Fok-0005rY-I8 for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Dec 2022 00:40:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Fok-0005qW-8B for pgsql-hackers@lists.postgresql.org; Wed, 14 Dec 2022 00:40:14 +0000 Received: from sender4-op-o11.zoho.com ([136.143.188.11]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Foh-0001mP-45 for pgsql-hackers@lists.postgresql.org; Wed, 14 Dec 2022 00:40:13 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1670978404; cv=none; d=zohomail.com; s=zohoarc; b=a2zbjrQFB1V3NV/Ncb/IYp9T5Hach5IRCiN/UHtqooGp1z+UfLpnRVWhdPR4jOS+IPDeVwzJuJbIdhJA8bhDQX86ZBKzQTYewqDxGoKTL4qQAETrjF0qrAuLyz9dSL7/boyGW8WPfucOSgx63CCpDSQBoxsj8ZkvOCXzijt7HWQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670978404; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Te3HiVGu8VC+9wgXn8v43YZFfmQ5b/1I7KAaOwxsSlE=; b=PDMVYO50Qd/XNpnfEqj4K3c0owhM+TF7yVLHACA4wDLUk7L+9WZemuQfWOyVGK1Ma4h8EFjcDshlbOlFujVqNYFuz9iIMJRKycjNrtww6DWgRsHR/dkg+zjhH77kEMDhUIcaM6zy2lq7HNRpH9ooQHXlBvPo3CBvRby/rJeYVD0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=highgo.ca; spf=pass smtp.mailfrom=david.zhang@highgo.ca; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1670978404; s=zoho; d=highgo.ca; i=david.zhang@highgo.ca; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Te3HiVGu8VC+9wgXn8v43YZFfmQ5b/1I7KAaOwxsSlE=; b=GNk3R6ro75mYMZhfhx89rkGY+P4Og4hg15VUJi+Cw8gcl/KaGOiQSuzoOvESOZYY E4me47lpuTzt/mc+BFJF2y4mxaeY0kG6aH3UY6Ku1hl1lvtATdKJ4w213gsWrOlXag6 VW5wnSzdlZAcP8q36rjJJXgsWBBoGLv6FSzFhkX8= Received: from [192.168.1.88] (d66-183-207-156.bchsia.telus.net [66.183.207.156]) by mx.zohomail.com with SMTPS id 1670978403384440.6673935133541; Tue, 13 Dec 2022 16:40:03 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 16:40:02 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: Make ON_ERROR_STOP stop on shell script failure Content-Language: en-US To: bt22nakamorit , Fujii Masao Cc: Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org References: <20220916.173035.322733707258561235.horikyota.ntt@gmail.com> <4c61d434cb72b2237b3279797b2a387f@oss.nttdata.com> <8a022f2c8de93ea79116f0b7eb42248a@oss.nttdata.com> <3f489f1f-3f91-8a98-4cf3-bad7ff037dc2@oss.nttdata.com> <1de37597cb5050b6d3d76def2826dcd4@oss.nttdata.com> <17e7da013164ab7f514e49e5715e6d0a@oss.nttdata.com> From: David Zhang In-Reply-To: <17e7da013164ab7f514e49e5715e6d0a@oss.nttdata.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-10-12 2:13 a.m., bt22nakamorit wrote: > There was a mistake in the error message for \! so I updated the patch. > Tried to apply this patch to the master branch, but got the error like below. $ git apply --check patch-view.diff error: patch failed: src/bin/psql/command.c:2693 error: src/bin/psql/command.c: patch does not apply I think there are some tests related with "ON_ERROR_STOP" in src/bin/psql/t/001_basic.pl, and we should consider to add corresponding test cases for "on/off/shell/all" to this patch. Best regards, David