Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pkLZe-0004d8-DS
	for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Apr 2023 09:06:30 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pkLZc-0007w0-Bs
	for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Apr 2023 09:06:28 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <peter.eisentraut@enterprisedb.com>)
	id 1pkLZb-0007vp-Em
	for pgsql-hackers@lists.postgresql.org; Thu, 06 Apr 2023 09:06:28 +0000
Received: from new2-smtp.messagingengine.com ([66.111.4.224])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter.eisentraut@enterprisedb.com>)
	id 1pkLZX-001DUC-D5
	for pgsql-hackers@postgresql.org; Thu, 06 Apr 2023 09:06:26 +0000
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
	by mailnew.nyi.internal (Postfix) with ESMTP id 62158581E6E;
	Thu,  6 Apr 2023 05:06:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
  by compute2.internal (MEProxy); Thu, 06 Apr 2023 05:06:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:content-type:date:date:feedback-id:feedback-id
	:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=
	1680771981; x=1680779181; bh=Pmp4jvGhAgzUyk/M+ZQv0nGQcchDwLTjqc8
	YFeKV9oA=; b=gv6O5QmOa47RM/x57IrJ9dUmt73YXTtIhP/nXFttIKC/LdTXydR
	Xiu4dKRkSiHjpPjuOiq/nKJxseR6CSDQXBe0nyC8zuAwGd4WBOz2xuRCqAKxmPBM
	1qSy6kTrouE9y39vgWGnExDfGbCd8DYeUYwPvvGS4YIAF7LNnkPzKZIT8jeeq/vl
	JLcp31Qs37Y+g6gmzqBKG5XyRmwq82sXmmuevLz4V2W3aOKzWOM82P5fY2U+amnf
	wKyAg1L0/RPrpn6J3IN4Bs0/fPi4AlTXHxqM/6nmN5ZVZ4s2f+db+CYdRdHb61MM
	hg9EMa/FtctUAqN3fQ4RqSRk9GkbFRgvJxg==
X-ME-Sender: <xms:jYsuZOrzEnCGxjIHnb5sSW9So7xXVY137CjQQ0ihivpfyASAgcS0Pg>
    <xme:jYsuZMoy5M61yww0w42MPw1ZtPFFT47gLVANU4cY2KOm_cSE_mdpjBcWamyd5TGbo
    J5jpgsVALWnnicLjg>
X-ME-Received: <xmr:jYsuZDN0YxJ20sL4rVVY3Wjo8CHFrrA1oY5_RCSV3WH_uFjBBwqRjh8c3ghLzP-tKubPR10AbP2811hkjurnkJO_j9GrAN0eWA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejfedgtdekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpefrvght
    vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth
    gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhjeduueelfeehuedt
    udefteejveegieeiueejueehfeektddtueeiieeitefhveenucevlhhushhtvghrufhiii
    gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu
    thesvghnthgvrhhprhhishgvuggsrdgtohhm
X-ME-Proxy: <xmx:jYsuZN63pczFo8Ll4ZMZrlcvYTvlkNIiPpHORkALWRy5ghuiHQcXfw>
    <xmx:jYsuZN6BrEZuNctSGBEM_AdixnucZaCiBmFXBaCe8Dq_cZrmnWSeUw>
    <xmx:jYsuZNhbr9ElT_yO1p7GK8ifjqTxewGkh4reXEPgYnGimtZstM64Dg>
    <xmx:jYsuZMQ5HzwtpTnscUmSEESZgwtg3JjFV_qNe4-YxeUi5NdkS4-D_w>
Feedback-ID: i131946ab:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 6 Apr 2023 05:06:19 -0400 (EDT)
Message-ID: <cea67271-ef9f-6c94-e303-bf9269ef6f35@enterprisedb.com>
Date: Thu, 6 Apr 2023 11:06:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: doc: add missing "id" attributes to extension packaging page
Content-Language: en-US
To: Brar Piening <brar@gmx.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
 "Karl O. Pinc" <kop@karlpinc.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>,
 Ian Lawrence Barwick <barwick@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql>
 <a41ed60d-2f95-da52-ba8b-b0b1cc37f3a4@gmx.de>
 <184dc41b-7407-1bb9-7fd4-7fb35db8b993@enterprisedb.com>
 <c6690867-4b06-ad16-b784-4824fcd4d43a@gmx.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <c6690867-4b06-ad16-b784-4824fcd4d43a@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/cea67271-ef9f-6c94-e303-bf9269ef6f35%40enterprisedb.com>
Precedence: bulk

On 04.04.23 21:52, Brar Piening wrote:
>> The XSLT implementation looks sound to me.  It would be a touch better
>> if it had some comments about which parts of the templates were copied
>> from upstream stylesheets and which were changed.  There are examples
>> of such commenting in the existing customization layer.  Also, avoid
>> introducing whitespace differences during said copying.
> 
> I will amend the patch if we agree that this is the way forward.

Ok, it appears everyone agrees that this is the correct approach. 
Please post an updated patch.  There have been so many partial patches 
posted recently, I'm not sure which one is the most current one and who 
is really the author.