Message-ID: <ceb1828c-8104-4f00-b3de-d0bdac9de7a7@iki.fi>
Date: Fri, 22 Nov 2024 15:26:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Changed behavior in rewriteheap
To: Matthias van de Meent <boekewurm+postgres@gmail.com>,
 =?UTF-8?Q?Erik_Nordstr=C3=B6m?= <erik@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CACAa4VJ+QY4pY7M0ECq29uGkrOygikYtao1UG9yCDFosxaps9g@mail.gmail.com>
 <CAEze2Wj3t_N_i=vNm3yHB0TLtgsieYx0_uSMqLqN2Y8qAAbJkw@mail.gmail.com>
 <CACAa4VLT1GB+BR8kgrFbF6GEUNbAAWEb+6NpMUPzYSAA-PL1vg@mail.gmail.com>
 <CAEze2Wg6kz3AypbuvMbx5j5RgasvB6+ykgzRVfrhxsR_m6cCkQ@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <CAEze2Wg6kz3AypbuvMbx5j5RgasvB6+ykgzRVfrhxsR_m6cCkQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/ceb1828c-8104-4f00-b3de-d0bdac9de7a7%40iki.fi>
Precedence: bulk

On 22/11/2024 15:02, Matthias van de Meent wrote:
> I think I'd go with a patch like attached, where the bulk writer
> registers that it started with .relsize pages in the relfork, and use
> that for smgrextend() decisions. It now also records pages_written as
> a separate but accurate value.

Looks good to me. Eric, can you confirm that Matthias's patch fixes the 
problem for you?

-- 
Heikki Linnakangas
Neon (https://neon.tech)