Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1m177Z-0005io-7I
	for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Jul 2021 12:57:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1m177Y-0006MR-5G
	for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Jul 2021 12:57:44 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1m177X-0006Lx-Tm
	for pgsql-hackers@lists.postgresql.org; Wed, 07 Jul 2021 12:57:43 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1m177V-00030B-EO
	for pgsql-hackers@postgresql.org; Wed, 07 Jul 2021 12:57:42 +0000
Received: from hnk.local (p2388012-ipbf1027funabasi.chiba.ocn.ne.jp
 [118.6.6.12])
	by oss.nttdata.com (Postfix) with ESMTPSA id 784C960417;
	Wed,  7 Jul 2021 21:57:37 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.2 at oss.nttdata.com
Subject: Re: track_planning causing performance regression
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Pavel Stehule <pavel.stehule@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
 "Tharakan, Robins" <tharar@amazon.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <646e5cae-5e8b-feaa-43dc-014bf355bf08@oss.nttdata.com>
 <20210418233615.GB7256@telsasoft.com>
 <d4cb31e2-d43f-0811-8f10-cf8e2f052e5e@oss.nttdata.com>
 <20210419145545.GF7256@telsasoft.com>
 <b86e33bf-d549-db6b-f50b-3cb077807a71@oss.nttdata.com>
 <20210421145338.GT7256@telsasoft.com>
 <f2aa2d6a-3b78-0526-4ca5-8ace10eb745e@oss.nttdata.com>
 <20210421154007.GU7256@telsasoft.com> <20210629020918.GE21248@telsasoft.com>
 <CAOBaU_bg0OcRUykMP=_XY7tsBfjtq1NW=JeO5=p=QRg8hXAT1A@mail.gmail.com>
 <20210629024535.GG21248@telsasoft.com>
 <CAOBaU_YJUNCPuEAciSmFBS0EJ16Qa_pDH3mLjSpUnG4FtaSbzg@mail.gmail.com>
 <c162e1b3-08b0-2216-8e9e-80733d4a1a9b@oss.nttdata.com>
 <CAOBaU_ZxTGMapnWTCGaEiAHochUjzEB5XQN3hqbuf0xspDwSbg@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <cef9be18-161c-98b9-ed0d-a23dc973df49@oss.nttdata.com>
Date: Wed, 7 Jul 2021 21:57:37 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: 
 <CAOBaU_ZxTGMapnWTCGaEiAHochUjzEB5XQN3hqbuf0xspDwSbg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/cef9be18-161c-98b9-ed0d-a23dc973df49%40oss.nttdata.com>
Precedence: bulk



On 2021/07/07 18:09, Julien Rouhaud wrote:
> On Thu, Jul 1, 2021 at 4:28 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> I'm fine with this. So what about the following diff? I added <structname> tag.
>>
>>          <varname>pg_stat_statements.track_planning</varname> controls whether
>>          planning operations and duration are tracked by the module.
>>          Enabling this parameter may incur a noticeable performance penalty,
>> -      especially when a fewer kinds of queries are executed on many
>> -      concurrent connections.
>> +      especially when statements with identical query structure are executed
>> +      by many concurrent connections which compete to update a small number of
>> +      <structname>pg_stat_statements</structname> entries.
>>          The default value is <literal>off</literal>.
>>          Only superusers can change this setting.
> 
> It seems perfect, thanks!

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION