Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M324252=pgsql-hackers-arkari@postgresql.org>)
	id 1cwqwR-0002K8-OL
	for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2017 14:02:15 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M324252=pgsql-hackers-arkari@postgresql.org>)
	id 1cwqwR-0001TH-8H
	for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2017 14:02:15 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <david@pgmasters.net>)
	id 1cwqwO-0001Ko-Of
	for pgsql-hackers@postgresql.org; Sat, 08 Apr 2017 14:02:13 +0000
Received: from mail.thelabyrinth.net ([45.56.70.56])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <david@pgmasters.net>)
	id 1cwqwM-0004Yl-Lk
	for pgsql-hackers@postgresql.org; Sat, 08 Apr 2017 14:02:11 +0000
Received: from Davids-iMac.local (unknown [98.204.177.190])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dsteele)
	by mail.thelabyrinth.net (Postfix) with ESMTPSA id B6DFF556E0;
	Sat,  8 Apr 2017 14:02:09 +0000 (UTC)
Subject: Re: WIP: Covering + unique indexes.
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
References: <56168952.4010101@postgrespro.ru>
 <46e1f13e-6887-3851-a525-f046029341eb@postgrespro.ru>
 <20170324124709.22419.51178.pgcf@coridan.postgresql.org>
 <c1f7c059-597f-44e8-7308-73d76ffd493c@sigaev.ru>
 <20170330191138.zawsxgsxnt2qy2as@alap3.anarazel.de>
 <a976fff4-29a9-c799-5c2d-19a371031325@postgrespro.ru>
 <CAH2-WzkT-MeSnHozqoxmmNthVRK9O06rKjCyZZeUri0X41imvw@mail.gmail.com>
 <1cd37c03-fedf-4b35-75b5-711e984e240d@postgrespro.ru>
 <CAH2-Wzm9y59h2m6iZjM4fpdUP5r4bsRVzGbN2gTRCO1j4nZmtw@mail.gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>,
 Teodor Sigaev <teodor@sigaev.ru>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Anastasia Lubennikova <lubennikovaav@gmail.com>,
 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
 Aleksander Alekseev <a.alekseev@postgrespro.ru>
From: David Steele <david@pgmasters.net>
Message-ID: <cf645aea-935f-4bd7-c8e8-ee609909de8c@pgmasters.net>
Date: Sat, 8 Apr 2017 10:02:09 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: 
 <CAH2-Wzm9y59h2m6iZjM4fpdUP5r4bsRVzGbN2gTRCO1j4nZmtw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 4/4/17 2:47 PM, Peter Geoghegan wrote:
> 
> At the very least, you should change comments to note the issue. I
> think it's highly unlikely that this could ever result in a failure to
> find a split point, which there are many defenses against already, but
> I think I would find that difficult to prove. The intent of the code
> is almost as important as the code, at least in my opinion.

This submission as been Returned with Feedback.  Please feel free to
resubmit to a future commitfest.

-- 
-David
david@pgmasters.net


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers