Message-ID: <cf976b924de917c762b53e0d7bcb5ded2d0b1aa3.camel@j-davis.com>
Subject: Re: Remaining dependency on setlocale()
From: Jeff Davis <pgsql@j-davis.com>
To: Peter Eisentraut <peter@eisentraut.org>, Chao Li <li.evan.chao@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, 
	pgsql-hackers@postgresql.org
Date: Tue, 27 Jan 2026 11:44:36 -0800
In-Reply-To: <5267a39d41a00d5d5b3342f10c835cc9e3e27a2c.camel@j-davis.com>
References: <4c5da86af36a0d5e430eee3f60ce5e06f1b5cd34.camel@j-davis.com>
	 <f040113cf384ada69558ec004a04a3ddb3e40a26.camel@j-davis.com>
	 <CA+hUKGJxSDFcTZSGi++PTC=jM49q1oK=v7Lcdf96VQXXvLhoow@mail.gmail.com>
	 <cdd20efc0f5418c597791a1e3a5abb68fa3ce35b.camel@j-davis.com>
	 <d9657a6e51aa20702447bb2386b32fea6218670f.camel@j-davis.com>
	 <b1ea6756-279a-4924-9146-e125af2057b2@eisentraut.org>
	 <8186b28a1a39e61a0d833a4c25a8909ebbbabd48.camel@j-davis.com>
	 <450ceb6260cad30d7afdf155d991a9caafee7c0d.camel@j-davis.com>
	 <DDD50039-02B4-4033-8D22-B086BC448E1C@gmail.com>
	 <78edc741a168c54d57cc898a5877b6443527a2c8.camel@j-davis.com>
	 <83F6E6A9-FF29-41C9-9E15-EA5360E912D0@gmail.com>
	 <5f65b85740197ba6249ea507cddf609f84a6188b.camel@j-davis.com>
	 <38f3f4a6-e95e-47a7-914f-110dd6191301@eisentraut.org>
	 <0e186a9a92634f0c5675a618ff5685d00cd8f836.camel@j-davis.com>
	 <dd0cdd1f-e786-426e-b336-1ffa9b2f1fc6@eisentraut.org>
	 <ac83c2376d4ce2ad423f48c4fe2c416fc5d2b346.camel@j-davis.com>
	 <108e07a2-0632-4f00-984d-fe0e0d0ec726@eisentraut.org>
	 <5267a39d41a00d5d5b3342f10c835cc9e3e27a2c.camel@j-davis.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/cf976b924de917c762b53e0d7bcb5ded2d0b1aa3.camel%40j-davis.com>
Precedence: bulk

On Tue, 2026-01-06 at 14:20 -0800, Jeff Davis wrote:
> Looks good to me.

I closed the entry for this commitfest, though there are a few loose
ends:

  * Not sure what to do about strerror & gettext. One idea is to wrap
both in a uselocale() everywhere. For windows, we use the special
setlocale() mode. For NetBSD, I don't know if we can or should do
anything -- maybe just prevent changing lc_messages?

  * pg_strcasecmp() still used many places in the backend. We should
consider replacing with an ASCII variant or one that uses the database
collation.

  * A number of places still rely on isalpha(), etc., for simple
parsing (e.g. ltree).

Regards,
	Jeff Davis