Message-ID: <cfcc839b-0851-4112-a7c5-1543d129e811@enterprisedb.com>
Date: Thu, 27 Jan 2022 14:42:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: Skipping logical replication transactions on subscriber side
Content-Language: en-US
To: Masahiko Sawada <sawada.mshk@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
 vignesh C <vignesh21@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>,
 "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
 "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>,
 Alexey Lesovsky <lesovsky@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: 
 <CAA4eK1LoUULzh-WreQe3TcL5s5oUG3c1bibC8rSThqknvvKvPQ@mail.gmail.com>
 <CAA4eK1+qwob8N2Ks4i=8=cBJ5trqr3cNuB99-9dRKkMLLZ_tvA@mail.gmail.com>
 <9c28c90c-f5b5-d8b9-e9b3-6af21b976725@enterprisedb.com>
 <CAA4eK1+9yXkWkJSNtWYV2rG7QNAnoAt+eNH0PexoSP9ZQmXKPg@mail.gmail.com>
 <78a7ef21-bb27-f78a-521e-94ddb4d5c669@enterprisedb.com>
 <CAKFQuwY=7v9xyb4A4m6dBnTJyRXvOFnpqnTgauL1US=WO_Ukdg@mail.gmail.com>
 <CAD21AoBf5ZY9Gv07GR10c-f8NmdeX+zvYEbp7JL3kMh9OB6Rig@mail.gmail.com>
 <CAKFQuwa4GUDTqkjdmhrt=4XREX=GTjFhfoRdG6X0uocwtpGvxA@mail.gmail.com>
 <CAD21AoBoMaCMTga7LYN7JEvhBs_gBqa8RLgxM3GBMxRn6f+8qA@mail.gmail.com>
 <CAA4eK1LANoQHgP4Rfe04nf1RWNhwckJ-+Osp+hmm7JuYZ+Wufw@mail.gmail.com>
 <CAD21AoCU2PLm+SxdOdUMpjgHioMB6baOoxqNi_XHD6QQJF+RKg@mail.gmail.com>
 <CAD21AoDHCAD9anS6ZzNyG1-B7F_BvzyiNfZ=O-tMEdwmKhfW8A@mail.gmail.com>
 <CAA4eK1J6VNwofqvs+kLCdf_wWztFLzet0d0N64xOoyx9DgivAw@mail.gmail.com>
 <CAD21AoDL5Vbi438UOJs=Z4O_5HevVa7aeJzCM2jHcXDb48PZhw@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAD21AoDL5Vbi438UOJs=Z4O_5HevVa7aeJzCM2jHcXDb48PZhw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/cfcc839b-0851-4112-a7c5-1543d129e811%40enterprisedb.com>
Precedence: bulk

On 26.01.22 05:05, Masahiko Sawada wrote:
>> I think it is okay to clear after the first successful application of
>> any transaction. What I was not sure was about the idea of giving
>> WARNING/ERROR if the first xact to be applied is not the same as
>> skip_xid.
> Do you prefer not to do anything in this case?

I think a warning would be sensible.  If the user specifies to skip a 
certain transaction and then that doesn't happen, we should at least say 
something.