public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Peter Smith <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [DOCS] Stats views and functions not in order?
Date: Thu, 1 Dec 2022 10:20:34 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHut+PvUdTdK5UGMXkm_U+1Cdez9y6x057GTrb3XSChybjdS3w@mail.gmail.com>
References: <CAHut+Pv8Oa7v06hJb3+HzCtM2u-3oHWMdvXVHhvi7ofB83pNbg@mail.gmail.com>
<CAHut+PvjbV5T4H6vk6=hPrU0iZ2KYx39cxS=xJtUL=Mu6H+t6Q@mail.gmail.com>
<CAHut+PsXR6Fq-Ra2VNUA1ZYi6MncB9de40v+tju9JmqZx00t5g@mail.gmail.com>
<CAHut+PtkV5is3+ZpJRmkZQDvdfFiC+BeBS02xQLNk_xRnfs9=A@mail.gmail.com>
<CAHut+PsvkhrByTmR=pY4K28FfUuuM9fQiKdyHHquDRLVBAj5dg@mail.gmail.com>
<[email protected]>
<CAHut+Pv=tk6u2MbvqfSdD74HRKpV2QP+e=p0X=g7t6Bf23531w@mail.gmail.com>
<CAKFQuwYtjTbYUs+bLUCk7aszXq_rHx0Fj=0e0fiaVKyDZ9k0Yw@mail.gmail.com>
<CAHut+PvkAp4AS03U08uPWjOoAY+zxD1j43xhRH0TUqzuOMx2BQ@mail.gmail.com>
<CAKFQuwa9JtoCBVc6CJb7NC5FqMeEAy_A8X4H8t6kVaw7fz9LTw@mail.gmail.com>
<CAHut+Pv5Efz1TLWOLSoFvoyC0mq+s92yFSd534ctWSdjEFtKCw@mail.gmail.com>
<CAKFQuwYkM5UZT+6tG+NgZvDcd5VavS+xNHsGsWC8jS-KJsxh7w@mail.gmail.com>
<CAHut+PvUdTdK5UGMXkm_U+1Cdez9y6x057GTrb3XSChybjdS3w@mail.gmail.com>
On 29.11.22 08:29, Peter Smith wrote:
> PSA v8* patches.
>
> Here, patches 0001 and 0002 are unchanged, but 0003 has many changes
> per David's suggestion [1] to change all these views to <refentry>
> blocks.
I don't understand what order 0001 is trying to achieve. I know we
didn't necessarily want to go fully alphabetic, but if we're going to
spend time on this, let's come up with a system that the next
contributor who adds a view will be able to understand and follow.
As an aside, I find the mixing of pg_stat_* and pg_statio_* views
visually distracting. It was easier to read before when they were in
separate blocks.
I think something like this would be manageable:
<!-- everything related to global objects, alphabetically -->
pg_stat_archiver
pg_stat_bgwriter
pg_stat_database
pg_stat_database_conflicts
pg_stat_replication_slots
pg_stat_slru
pg_stat_subscription_stats
pg_stat_wal
<!-- all "stat" for schema objects, by "importance" -->
pg_stat_all_tables
pg_stat_sys_tables
pg_stat_user_tables
pg_stat_xact_all_tables
pg_stat_xact_sys_tables
pg_stat_xact_user_tables
pg_stat_all_indexes
pg_stat_sys_indexes
pg_stat_user_indexes
pg_stat_user_functions
pg_stat_xact_user_functions
<!-- all "statio" for schema objects, by "importance" -->
pg_statio_all_tables
pg_statio_sys_tables
pg_statio_user_tables
pg_statio_all_indexes
pg_statio_sys_indexes
pg_statio_user_indexes
pg_statio_all_sequences
pg_statio_sys_sequences
pg_statio_user_sequences
In any case, the remaining patches are new and need further review, so
I'll move this to the next CF.
view thread (23+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [DOCS] Stats views and functions not in order?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox