MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_5007746fe26a378c231799638e71d811"
Date: Wed, 14 Oct 2020 16:21:37 +0900
From: Shinya Okano <btokanosn@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Kasahara Tatsuhito
 <kasahara.tatsuhito@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add a description to the documentation that toast_tuple_target
 affects "Main"
In-Reply-To: <a4941ace-b898-3bd4-270f-2ccc1dc2af07@oss.nttdata.com>
References: <93f46e311a67422e89e770d236059817@oss.nttdata.com>
 <CAP0=ZVJ9Wh2RnphL4nB6PuhODCxeMBBkzg3=5oSu+1FMOaNK6Q@mail.gmail.com>
 <a4941ace-b898-3bd4-270f-2ccc1dc2af07@oss.nttdata.com>
Message-ID: <cfe3c1f5f0987c70ddde187d411739e3@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Precedence: bulk

--=_5007746fe26a378c231799638e71d811
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2020-10-14 01:30, Fujii Masao wrote:
> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano 
>> <btokanosn@oss.nttdata.com> wrote:
>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>> documentation says that it only affects External or Extended, but it
>>> actually affects the compression of Main as well.
>>> 
>>> The attached patch modifies the document to match the actual 
>>> behavior.
>> +1
> 
> +1
> 
> +      we try to compress long column values or to move into TOAST 
> tables, and
> 
> "we try to compress and/or move long column values into TOAST tables,
> and" is better?

Thank you everyone for reviews.
I attached the new version of the patch.

Regards,

-- 
Shinya Okano

--=_5007746fe26a378c231799638e71d811
Content-Transfer-Encoding: base64
Content-Type: text/x-diff; charset=us-ascii;
 name=V2-Add-Main-to-the-toast_tuple_target-doc.patch
Content-Disposition: attachment;
 filename=V2-Add-Main-to-the-toast_tuple_target-doc.patch;
 size=1311

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvY3JlYXRlX3RhYmxlLnNnbWwgYi9kb2Mvc3Jj
L3NnbWwvcmVmL2NyZWF0ZV90YWJsZS5zZ21sCmluZGV4IDI4Zjg0NDA3MWIuLmZkNjc3N2FlMDEg
MTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9yZWYvY3JlYXRlX3RhYmxlLnNnbWwKKysrIGIvZG9j
L3NyYy9zZ21sL3JlZi9jcmVhdGVfdGFibGUuc2dtbApAQCAtMTM1OSwxMCArMTM1OSwxMSBAQCBX
SVRIICggTU9EVUxVUyA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+bnVtZXJpY19saXRl
cmFsPC9yZXBsYWNlYWJsZT4sIFJFTQogICAgIDxsaXN0aXRlbT4KICAgICAgPHBhcmE+CiAgICAg
ICBUaGUgdG9hc3RfdHVwbGVfdGFyZ2V0IHNwZWNpZmllcyB0aGUgbWluaW11bSB0dXBsZSBsZW5n
dGggcmVxdWlyZWQgYmVmb3JlCi0gICAgICB3ZSB0cnkgdG8gbW92ZSBsb25nIGNvbHVtbiB2YWx1
ZXMgaW50byBUT0FTVCB0YWJsZXMsIGFuZCBpcyBhbHNvIHRoZQotICAgICAgdGFyZ2V0IGxlbmd0
aCB3ZSB0cnkgdG8gcmVkdWNlIHRoZSBsZW5ndGggYmVsb3cgb25jZSB0b2FzdGluZyBiZWdpbnMu
Ci0gICAgICBUaGlzIG9ubHkgYWZmZWN0cyBjb2x1bW5zIG1hcmtlZCBhcyBlaXRoZXIgRXh0ZXJu
YWwgb3IgRXh0ZW5kZWQKLSAgICAgIGFuZCBhcHBsaWVzIG9ubHkgdG8gbmV3IHR1cGxlczsgdGhl
cmUgaXMgbm8gZWZmZWN0IG9uIGV4aXN0aW5nIHJvd3MuCisgICAgICB3ZSB0cnkgdG8gY29tcHJl
c3MgYW5kL29yIG1vdmUgbG9uZyBjb2x1bW4gdmFsdWVzIGludG8gVE9BU1QgdGFibGVzLCBhbmQK
KyAgICAgIGlzIGFsc28gdGhlIHRhcmdldCBsZW5ndGggd2UgdHJ5IHRvIHJlZHVjZSB0aGUgbGVu
Z3RoIGJlbG93IG9uY2UgdG9hc3RpbmcKKyAgICAgIGJlZ2lucy4gVGhpcyBhZmZlY3RzIGNvbHVt
bnMgbWFya2VkIGFzIEV4dGVybmFsIChmb3IgbW92ZSksCisgICAgICBNYWluIChmb3IgY29tcHJl
c3Npb24pLCBvciBFeHRlbmRlZCAoZm9yIGJvdGgpIGFuZCBhcHBsaWVzIG9ubHkgdG8gbmV3Cisg
ICAgICB0dXBsZXMuIFRoZXJlIGlzIG5vIGVmZmVjdCBvbiBleGlzdGluZyByb3dzLgogICAgICAg
QnkgZGVmYXVsdCB0aGlzIHBhcmFtZXRlciBpcyBzZXQgdG8gYWxsb3cgYXQgbGVhc3QgNCB0dXBs
ZXMgcGVyIGJsb2NrLAogICAgICAgd2hpY2ggd2l0aCB0aGUgZGVmYXVsdCBibG9jayBzaXplIHdp
bGwgYmUgMjA0MCBieXRlcy4gVmFsaWQgdmFsdWVzIGFyZQogICAgICAgYmV0d2VlbiAxMjggYnl0
ZXMgYW5kIHRoZSAoYmxvY2sgc2l6ZSAtIGhlYWRlciksIGJ5IGRlZmF1bHQgODE2MCBieXRlcy4K
--=_5007746fe26a378c231799638e71d811--