Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fKOYD-0008UW-90 for pgsql-hackers@arkaria.postgresql.org; Sun, 20 May 2018 13:39:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fKOYC-0005W0-6H for pgsql-hackers@arkaria.postgresql.org; Sun, 20 May 2018 13:39:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fKOYB-0005Vq-Nz for pgsql-hackers@lists.postgresql.org; Sun, 20 May 2018 13:39:04 +0000 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fKOY5-000603-SO for pgsql-hackers@postgresql.org; Sun, 20 May 2018 13:39:00 +0000 Received: by mail-wm0-x229.google.com with SMTP id m129-v6so22276338wmb.3 for ; Sun, 20 May 2018 06:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yNJIrxDZwxOTk9sbj563zjSr/9yt6vMr81d2B5yqmEw=; b=iBLonVisfLjOzvg/dQRtN4Nf7BpoCte+NvBYZDjCm3Mt2yxsOkA1whVlu2z7x/px2+ DVkWNerY7kSGU9NmDWWMjcQxZrzMuVCWs1eT2Ht0BzAr1+g+E5yTngX4WkRZrAinbL52 CcjJDIC1YQ6ztLo4hcOlctVcYV8uY/uwgBTIiOfFhqAOhoxUVDpfFWRyeH7PK+y/P98g 7wOfCDPqc203O4t3b9Vkoa3oGC4Bn/xxre39WulAZh7H78VE87vYPOzAPFOqgAe/wTwW lNmR2T4HveA64dT7WBdwsgUwktVTYQZ63+4NlewexPw2BgjBcEXHxEFj+0uj2myR4aa6 Ms5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yNJIrxDZwxOTk9sbj563zjSr/9yt6vMr81d2B5yqmEw=; b=fCbPDk5x3ftr8uQvMz6kheMy/0HM01By3og2B0o868SukkDM8KZZ1QSU6sNZdLsCLp YO8TQMWzGxg5b2FpJqnCTlVdkSctwudJrnTgZH9HC1vr+zX0MEHBuZvFL1z4JVXRe/XZ M3COq+lLz6yPVIBIP/9a0R9dIEqih7R4k0K1HLR4coD4GSPQCrQHmQUNNef2DiFaOrXN 9ijDP2snpcVneqCPwnZMCBf3Y3TtO39MgJ64XfboGRfpe23m8ONmghFapEGalY82oux0 aA/so7s9KLcupk6G3n4gPfkhZnxte48bSWE8oe0c6wQRfAIVVCTigXAJAnSrWq5plwbB r20w== X-Gm-Message-State: ALKqPwcgUyGFIs7wdJtCpi+Vm87MNCbsK5aabW5lm0WcXjYaXchR/0th ds3/jG3j4c2rpxGzuKcl0+G1LA== X-Google-Smtp-Source: AB8JxZpKBsteCcM903WhIh27e911puvKm1JSRYutUoostgAUYvretiyLygvTXHVJVNqB7hnvjsuEPw== X-Received: by 2002:a50:8fa5:: with SMTP id y34-v6mr19905840edy.290.1526823534138; Sun, 20 May 2018 06:38:54 -0700 (PDT) Received: from [10.8.8.59] ([185.94.189.190]) by smtp.gmail.com with ESMTPSA id w9-v6sm6196917edb.38.2018.05.20.06.38.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 May 2018 06:38:53 -0700 (PDT) Subject: Re: Fix for FETCH FIRST syntax problems To: Andrew Gierth , pgsql-hackers@postgresql.org Cc: Tom Lane , Michael Paquier References: <877enz476l.fsf@news-spur.riddles.org.uk> <22981.1526770675@sss.pgh.pa.us> <03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com> <25267.1526773270@sss.pgh.pa.us> <20180519235706.GA1603@paquier.xyz> <87tvr32gvz.fsf@news-spur.riddles.org.uk> From: Vik Fearing Openpgp: preference=signencrypt Autocrypt: addr=vik.fearing@2ndquadrant.com; prefer-encrypt=mutual; keydata= xsFNBFg9q8kBEADfBQMKbYmvL7k4D4ghRYon0lMRf9c+dADesMGsBh5SYTK1/t4S4iCfbc8d QUCyJWSiJYkT1MZNSywbr3hNahZ7qAN0y4kvGNUIxXJGcza5qH5gHQYFrpB/IDoZcZ5/l260 Y5roqQos7kimpALNrl2cXWkR98Z9FWZOocImzdBnKV+qHzD9ZCPISPqR92N67gPqLD4YNx5Y T4NkT2N2nYZlyvv6X3t5/haLWpSLTJ/7ESD6jwTs7Ok4meLidSqr8U25p/L4mb+pscR6l5Hq aJXagW9oQ0uI50Wlri1GeE/JTqaURxfOCWBE3RzrRdhH0HYMOz49gLqba0s4eBlMw18R0OWt TD4mRnpD41X4aaSrMEqm2xXZAa8T+UFlQXWliMvFJ4rQhAogPLN9yI93FDy5pqJdtu3T/mJu HycJfiJHtgGVP8bsMQdg5X4kNWO2LnerJQiO+cYambgb5RWBS3byjO8f05sIXQxIR1nLdGEY 7Cy5/eIN6+qRA3kpRjfQ2QOlEKxVWNLu9t+xGphRi6TidZWnhHRwfCkeelR9R4niubLQPirl /XvToUtm0opXBHbVxTVblM0i7z+x9tnQUCa1f710pnJ/LRqE2Se/JPbEeg5JH4MLLGdr8uxf fv9E8dJVvmTRIWOJFNFnd9e3b9K6I/ek+ysVFsNrKnP9dS4R0QARAQABzSBWaWsgRmVhcmlu ZyA8dmlrQDJuZHF1YWRyYW50LmZyPsLBfQQTAQgAJwUCWD2ryQIbIwUJCWYBgAULCQgHAgYV CAkKCwIEFgIDAQIeAQIXgAAKCRBzOWT4unEhz0W+D/0ZqG/7SmWxSPSm3IcwQaGvxKIE/XFv jZ5USS6W1U/Ttq8qXnJbWOTzEKl6NVQcAuAIAYdvOjwrDDR9SMSMPvHmd7LniOZ4/+V2rdLj fOXzExI+1yJ1TYv1pGTgt5ZmjARIvge942iEYHQey5pavoNI1/C9V0RLuh2yS6dLax21295V OFOhQD11mDJLJ8c/ILVpadqt90V9bQzBWycPOjnwjhxD4kVXMjihnl54EuMp08UW6OTCP4ux /SxJFfTM1WDr+GDk7RgsG3bJfwftdUP2Qc8drwu0LAT41edmaigFGM1RMKeBWeo5Tdcm/Wmo uDeLJwL+CGvEZEjNrLxoXBhuRcv+9m5eYOafqewKgZXTmeZImbk75Jp502LCQHXhdatr9O8a KKjmkKqz+uPOV+4qsvqXdMCCFWb15/Pd/a8ffPMRwq6ebDOPYXJUkGqc65tSlf0gRxfIKof3 gO3TevZ0U1nc7kBa/QNe2QN6RC24+GbyJNEvQ6g2ZbBddffiuYZElsGM3+yiM6jz2RWG4uLQ /Qjw6ZwhNUCOepVa3SsLkSE0HN2M2emN8exQIdJw37IiKIsZPPFa+J3netLfXB4F+/BnwVqK GW8eaLYQWQYRBPTMKgLCqGDCgNIB8cVG7zmx7zYDPXNEwKPfcGSkixfQJxgq1InWDyVg2qwU TP0iVM7BTQRYPavJARAAsdzHCSxLnqy1UW0qNhJoZaIkSbQQ6Bjqgfo4KZKvt2eBe363ubgw 5j6VCfpBpOSJYQrOadY7GOKw0m8iwtr1bvrNg/7SoqfwoKLBTvuxo5WsUD9e8f/Hy1CoMz/3 o1qAvBiQK+MnZvmgtwvwqWpx/g+H2uH8aPttNC1x9lO866o4JtoVWumi01si6KKjO+ZNazPi n9a0JW4OVeLxhIy0OnrE4KMOrnHZlJPIdGP36dtFMK9tyqQ3z3zOp/HN+3mrQZAphH/2idLK wRZURPpisvy3HES9yN/JAWtPEYB0OAhKGJhgLDue08zM8FRNa5ldc/oJCqMEC8D5bh6g3LCz uIM11hOMD8OJNX1lGnzdicBLMghUfhtAJ+KfBGqIG3hLxzYp8RiIfG/HJyA6dhqpxG3y6yjO 0r24THuXceW7ygqQUB+J2KK8B1iWTwiMBvvIav9tOQTcYkU+EFtN7zwkC3aN2HV8I7QLDUWw OyWZ1+J1ff3xyCjMhZ0SaBV8kUy981RE8lnmy/T6lE9iFfj2roSkCLcUkODb9mz1BSeg7l1J yRGqQ2ypxS3l77h+JC1SMRrDUz1vFIIAuvQEjJgnV5JUjmNi/0s+/HQU8YRlQWERSH9pHwFL ZgSwH5hqCLFjiGLxxHqJ4JZLoP7J1I5tpuUkbVPhreRNNZ9ro0Wtd9cAEQEAAcLBZQQYAQgA DwUCWD2ryQIbDAUJCWYBgAAKCRBzOWT4unEhz2qgD/95NfvOedTfZ2P0hXTHlE0oGL9pIP21 dOng/fJT1yc4nA4MfNV3Hf72Gpw/XLpnMgovanqj+15ZyFPirCaB9lCjEiorzSsLN9k0I1OC +gIbouFHgYo3nzeRJf/hMlAzef7sqjuD5WyI7miMeaKXkjTGyjC39xX2nq5EHCI8V/uBtT94 3cyZmCrEl64AKjlnFfkNKhlYWpfDWSVSxz79QAIw0wW4ILNFfAp3z4DPjqGut98XBlmtQlDj RMlqeUHDIGLQjKNmxH95vbTS9eAFom6jA99Bl4nWCWUYHoGA/y7Ov6z9vQwqkJ4WqPMg+mas 7nZNQiexBj3tG5pRU2M7NURnaLiINFXid+kjKmNEUgNyd0haIqiIRtkRWZ2zvAwfudS7HDq1 RB6GWGHtJrVFRIkgs3gBoyPz3kSwlYieid6Ywquxd3dQqkN6cdlnvt2uossgRnqXx5HugP81 Faadir4t4t6HqoLHynzvvT9fMijT//O6Fb0MFqZP2rf3i7zh7/rwtpdxI2m/SbTJgvMqlvGn riBgDbjEz8XNMGqMk/WPNcKkk8prCPta9ltMl7yd3LqzCG6KRz7TtQae25BcBF1IKobZYbgf qc5fRxkCHCy6IDu70pve2tt1hzvZquE2Z5uTMFp2k213HJQKklY/jAOmVhM2O2T2oSaKAr1u MUmXcw== Organization: 2ndQuadrant France Message-ID: Date: Sun, 20 May 2018 15:38:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87tvr32gvz.fsf@news-spur.riddles.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 20/05/18 05:25, Andrew Gierth wrote: > +select_fetch_first_value: > + c_expr { $$ = $1; } > + | '+' I_or_F_const > + { $$ = (Node *) makeSimpleA_Expr(AEXPR_OP, "+", NULL, $2, @1); } > + | '-' I_or_F_const > + { $$ = doNegate($2, @1); } I think there should be a comment for why you're accepting FCONST when the value has to be integral. -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support