Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pWdfz-0008QK-5d
	for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2023 13:36:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pWdfx-0007xm-VL
	for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2023 13:36:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andrew@dunslane.net>)
	id 1pWdfx-0007xc-Ls
	for pgsql-hackers@lists.postgresql.org; Mon, 27 Feb 2023 13:36:21 +0000
Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andrew@dunslane.net>)
	id 1pWdfv-000187-8d
	for pgsql-hackers@postgresql.org; Mon, 27 Feb 2023 13:36:21 +0000
Received: (Authenticated sender: adsend@dunslane.net)
	by mail.gandi.net (Postfix) with ESMTPSA id A2AD9240012;
	Mon, 27 Feb 2023 13:36:13 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="------------IytwEcY9ZSwacie5RaERtUiY"
Message-ID: <d104f128-4437-69a3-5d2a-a6bdf788d027@dunslane.net>
Date: Mon, 27 Feb 2023 08:36:12 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: meson vs make: missing/inconsistent ENV
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
 Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org,
 Peter Eisentraut <peter@eisentraut.org>
References: <20230226225239.GL1653@telsasoft.com>
 <20230226232104.5djexwyitlfemrhg@awork3.anarazel.de>
 <20230227020029.GN1653@telsasoft.com> <87edqbjr1i.fsf@wibble.ilmari.org>
 <f5a573f0-f453-261a-99df-16b7b395a107@dunslane.net>
In-Reply-To: <f5a573f0-f453-261a-99df-16b7b395a107@dunslane.net>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/d104f128-4437-69a3-5d2a-a6bdf788d027%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------IytwEcY9ZSwacie5RaERtUiY
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2023-02-27 Mo 07:33, Andrew Dunstan wrote:
>
>
> On 2023-02-27 Mo 06:17, Dagfinn Ilmari Mannsåker wrote:
>> Justin Pryzby<pryzby@telsasoft.com>  writes:
>>
>>> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
>>>>> Is there any consideration of promoting these or other warnings to
>>>>> fatal?
>>>> You mean the perl warnings?
>>> Yes - it'd be nice if the warnings caused an obvious failure to allow
>>> addressing the issue.  I noticed the icu warning while looking at a bug
>>> in 0da243fed, and updating to add ZSTD.
>> Perl warnings can be made fatal with `use warnings FATAL =>
>> <categories>;`, but one should be careful about which categories to
>> fatalise, per<https://metacpan.org/pod/warnings#Fatal-Warnings>.
>>
>> Some categories are inherently unsafe to fatalise, as documented in
>> <https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS>.
>>
>
> Yeah.
>
>
> It would be nice if there were some fuller explanation of the various 
> categories, but I don't know of one.
>
>
>

Looks like the explanations are in the perldiag manual page. 
<https://perldoc.perl.org/perldiag>


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------IytwEcY9ZSwacie5RaERtUiY
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2023-02-27 Mo 07:33, Andrew Dunstan
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:f5a573f0-f453-261a-99df-16b7b395a107@dunslane.net">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <p><br>
      </p>
      <div class="moz-cite-prefix">On 2023-02-27 Mo 06:17, Dagfinn
        Ilmari Mannsåker wrote:<br>
      </div>
      <blockquote type="cite"
        cite="mid:87edqbjr1i.fsf@wibble.ilmari.org">
        <pre class="moz-quote-pre" wrap="">Justin Pryzby <a class="moz-txt-link-rfc2396E" href="mailto:pryzby@telsasoft.com" moz-do-not-send="true">&lt;pryzby@telsasoft.com&gt;</a> writes:

</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
</pre>
          <blockquote type="cite">
            <blockquote type="cite">
              <pre class="moz-quote-pre" wrap="">Is there any consideration of promoting these or other warnings to
fatal?
</pre>
            </blockquote>
            <pre class="moz-quote-pre" wrap="">You mean the perl warnings?
</pre>
          </blockquote>
          <pre class="moz-quote-pre" wrap="">Yes - it'd be nice if the warnings caused an obvious failure to allow
addressing the issue.  I noticed the icu warning while looking at a bug
in 0da243fed, and updating to add ZSTD.  
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">Perl warnings can be made fatal with `use warnings FATAL =&gt;
&lt;categories&gt;;`, but one should be careful about which categories to
fatalise, per <a class="moz-txt-link-rfc2396E" href="https://metacpan.org/pod/warnings#Fatal-Warnings" moz-do-not-send="true">&lt;https://metacpan.org/pod/warnings#Fatal-Warnings&gt;</a>.

Some categories are inherently unsafe to fatalise, as documented in
<a class="moz-txt-link-rfc2396E" href="https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS" moz-do-not-send="true">&lt;https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS&gt;</a>.

</pre>
      </blockquote>
      <p><br>
      </p>
      <p>Yeah.</p>
      <p><br>
      </p>
      <p>It would be nice if there were some fuller explanation of the
        various categories, but I don't know of one.</p>
      <p><br>
      </p>
      <br>
    </blockquote>
    <p><br>
    </p>
    <p>Looks like the explanations are in the perldiag manual page.
      <a class="moz-txt-link-rfc2396E" href="https://perldoc.perl.org/perldiag">&lt;https://perldoc.perl.org/perldiag&gt;</a><br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------IytwEcY9ZSwacie5RaERtUiY--