MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_d76c83b8ed3890b2d1924b0d8d3d4645"
Date: Fri, 24 Apr 2020 11:29:43 +0900
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: pgsql-hackers@postgresql.org
Subject: Why are wait events not reported even though it reads/writes a
 timeline history file?
Message-ID: <d11b0c910b63684424e06772eb844ab5@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Precedence: bulk

--=_d76c83b8ed3890b2d1924b0d8d3d4645
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8;
 format=flowed

Hi, 

There are two unexpected codes for me about wait events for timeline 
history file.
Please let me know your thoughts whether if we need to change.


1. readTimeLineHistory() function in timeline.c

The readTimeLineHistory() reads a timeline history file, 
but it doesn't report “WAIT_EVENT_TIMELINE_HISTORY_READ".

In my understanding, sscanf() is blocking read. 
So, it's important to report a wait event.

2. writeTimeLineHistory() function in timeline.c

The writeTimeLineHistory() function may write a timeline history file 
twice,
but it reports “WAIT_EVENT_TIMELINE_HISTORY_WRITE" only once.

It makes sense to report a wait event twice, because both of them use 
write().

I attached a patch to mention the code line number.


I checked the commit log which "WAIT_EVENT_TIMELINE_HISTORY_READ" and
"WAIT_EVENT_TIMELINE_HISTORY_WRITE" are committed and the discussion 
about it.
But I can't find the reason.

Please give me your comments.
If we need to change, I can make a patch to fix them.


By the way, which is correct "timeline's history file" or "timeline 
history file"?
The timeline.c has both. In my understanding, the latter is correct. If 
so, I will modify together.

Regards,

--
Masahiro Ikeda
NTT DATA CORPORATION
--=_d76c83b8ed3890b2d1924b0d8d3d4645
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-some-wait-events-for-timeline-history-file-are-not-r.patch
Content-Disposition: attachment;
 filename=0001-some-wait-events-for-timeline-history-file-are-not-r.patch;
 size=1200

RnJvbSAyZTZmMzQyMDI0YTA3NTkwMzkxMGI5NGIzNzI5MmVmZDNhYTFmM2E4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlybyBJa2VkYSA8aWtlZGFtc2hAb3NzLm50dGRhdGEu
Y29tPgpEYXRlOiBUaHUsIDIzIEFwciAyMDIwIDE2OjI0OjA3ICswOTAwClN1YmplY3Q6IFtQQVRD
SF0gc29tZSB3YWl0IGV2ZW50cyBmb3IgdGltZWxpbmUgaGlzdG9yeSBmaWxlIGFyZSBub3QgcmVw
b3J0ZWQuCgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3RpbWVsaW5lLmMgfCA0ICsr
KysKIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvYmFj
a2VuZC9hY2Nlc3MvdHJhbnNhbS90aW1lbGluZS5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5z
YW0vdGltZWxpbmUuYwppbmRleCBkZTU3ZDY5OWFmLi5mMTQwMTAwNTA1IDEwMDY0NAotLS0gYS9z
cmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS90aW1lbGluZS5jCisrKyBiL3NyYy9iYWNrZW5kL2Fj
Y2Vzcy90cmFuc2FtL3RpbWVsaW5lLmMKQEAgLTE0MCw2ICsxNDAsOCBAQCByZWFkVGltZUxpbmVI
aXN0b3J5KFRpbWVMaW5lSUQgdGFyZ2V0VExJKQogCQlpZiAoKnB0ciA9PSAnXDAnIHx8ICpwdHIg
PT0gJyMnKQogCQkJY29udGludWU7CiAKKwkJIyBUcnkgdG8gcmVhZCBhIHRpbWVsaW5lIGhpc3Rv
cnkgZmlsZS4KKwkJIyBCdXQsIGl0IGRvZXNuJ3QgcmVwb3J0ICJXQUlUX0VWRU5UX1RJTUVMSU5F
X0hJU1RPUllfUkVBRCIuCiAJCW5maWVsZHMgPSBzc2NhbmYoZmxpbmUsICIldVx0JVgvJVgiLCAm
dGxpLCAmc3dpdGNocG9pbnRfaGksICZzd2l0Y2hwb2ludF9sbyk7CiAKIAkJaWYgKG5maWVsZHMg
PCAxKQpAQCAtMzkzLDYgKzM5NSw4IEBAIHdyaXRlVGltZUxpbmVIaXN0b3J5KFRpbWVMaW5lSUQg
bmV3VExJLCBUaW1lTGluZUlEIHBhcmVudFRMSSwKIAogCW5ieXRlcyA9IHN0cmxlbihidWZmZXIp
OwogCWVycm5vID0gMDsKKwkjIFRyeSB0byB3cml0ZSBhIHRpbWVsaW5lIGhpc3RvcnkgZmlsZS4K
KwkjIEJ1dCwgaXQgZG9lc24ndCByZXBvcnQgIldBSVRfRVZFTlRfVElNRUxJTkVfSElTVE9SWV9X
UklURSIuCiAJaWYgKChpbnQpIHdyaXRlKGZkLCBidWZmZXIsIG5ieXRlcykgIT0gbmJ5dGVzKQog
CXsKIAkJaW50CQkJc2F2ZV9lcnJubyA9IGVycm5vOwotLSAKMi4yNC4yIChBcHBsZSBHaXQtMTI3
KQoK
--=_d76c83b8ed3890b2d1924b0d8d3d4645--