Subject: Re: Feature improvement of tab completion for DEALLOCATE
To: btnakamichin <btnakamichin@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
References: <ec1a45b06edfce13706f2c765778d8c2@oss.nttdata.com>
 <997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com>
 <680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <d12635e7-69b9-15fd-3b6d-014645ffb851@oss.nttdata.com>
Date: Mon, 28 Sep 2020 11:31:42 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2020/09/25 15:18, btnakamichin wrote:
> 2020-09-25 14:30 に Fujii Masao さんは書きました:
>> On 2020/09/25 13:45, btnakamichin wrote:
>>> Hello!
>>>
>>> I’d like to improve the deallocate tab completion.
>>>
>>> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.
>>
>> Thanks for the patch! It looks basically good, but I think it's better
>> to add newline just before UNION to avoid long line, as follows.
>>
>> - COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
>> + COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
>> +                                                       " UNION SELECT 'ALL'");
>>
>> Regards,
> 
> Thank you, I appreciate your comment.
> 
> I have attached pattch　with newline.

Thanks for updating the patch! But it contains only the diff from the previous patch.
Anyway, I pushed the change that you proposed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION