Subject: Re: base backup client as auxiliary backend process
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
References: <20191107041630.GK1768@paquier.xyz>
 <4792e456-d75f-8e6a-2d47-34b8f78c266f@2ndquadrant.com>
 <116725031573825947@iva1-ef4837f8671e.qloud-c.yandex.net>
 <8d8c851a-c951-f98e-22c2-f62621c32d3b@2ndquadrant.com>
 <CA+fd4k4BcYrYucNfTnK-CQX3+jsG+PRPEhHAUSo-W4P0Lec57A@mail.gmail.com>
 <4c79f835-b443-7b02-9097-aa1a40f46be9@2ndquadrant.com>
 <CA+fd4k4dM0iEPLxyVyme2RAFsn8SUgrNtBJOu81YqTY4V+nqZA@mail.gmail.com>
 <7925a361-d48c-db03-30b4-fcd331ef7f02@2ndquadrant.com>
 <CA+fd4k4A9hadga4AtyKfxQMgZ9DMzPsV=NAvCcMVEjEZye8vXw@mail.gmail.com>
 <5686daaa-e39f-3814-7ece-e96462f20616@2ndquadrant.com>
 <20200203124731.ykmyps26ohan4fsx@alap3.anarazel.de>
 <e8f86ba5-48f1-a80a-7f1d-b76bcb9c5c47@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
 Sergei Kornilov <sk@zsrv.org>, Michael Paquier <michael@paquier.xyz>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Organization: 2ndQuadrant
Message-ID: <d12686c6-7566-8190-8fb0-af4927e8e4fe@2ndquadrant.com>
Date: Sat, 22 Feb 2020 16:12:27 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <e8f86ba5-48f1-a80a-7f1d-b76bcb9c5c47@2ndquadrant.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-02-17 18:42, Peter Eisentraut wrote:
> On 2020-02-03 13:47, Andres Freund wrote:
>> Comment:
>>
>> - It'd be good to split out the feature independent refactorings, like
>>     the introduction of InitControlFile(), into their own commit. Right
>>     now it's hard to separate out what should just should be moved code,
>>     and what should be behavioural changes. Especially when there's stuff
>>     like just reindenting comments as part of the patch.
> 
> Agreed.  Here are three refactoring patches extracted that seem useful
> on their own.

These have been committed.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services