public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Borisov <[email protected]>
To: Peter Eisentraut <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: Unicode update and some tooling improvements
Date: Fri, 13 Mar 2026 13:11:41 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
26.02.2026 23:36, Peter Eisentraut wrote:
> This is the annual update of the Unicode data. I also worked a bit on
> the tooling. The update-unicode target under meson did not update the
> data in contrib/unaccent/, so I added that. I also fixed a Python
> deprecation warning in the generation script and made some light changes
> in the surrounding documentation.
Installed, tested, checked it out.
I hope I'm not late.
"[PATCH 3/6] Implement unaccent Unicode data update in meson"
The idea of raising the minimum Meson version is good.
But it seems like we can do without raising the version.
As I understand it, the minimum version is being raised because of
.replace(), but it can be successfully replaced here with the following
construct:
cldr_version_dashed = '-'.join(CLDR_VERSION.split('.'))
url = cldr_baseurl.format(cldr_version_dashed, f)
I would increase the minimum version of Meson, but I would do it with a
separate patch so that the commit log would be "loud":
- Increase the minimum version for Meson.
This would be useful for users who look at commit logs.
Currently, the minimum version for Meson is increased "secretly" inside
the patch. Or at least explicitly indicate this in the commit log for
this patch.
Otherwise, looks good to me.
I am in favor of regular Unicode updates. 🙂
--
Best regards,
Alexander Borisov
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Unicode update and some tooling improvements
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox