Message-ID: <d20864b929ff769a0ebf772359719f05bb6982cd.camel@j-davis.com>
Subject: Re: pgsql: Fix search_path to a safe value during maintenance
 operations.
From: Jeff Davis <pgsql@j-davis.com>
To: Jeff Davis <jdavis@postgresql.org>, pgsql-committers@lists.postgresql.org
Date: Fri, 09 Jun 2023 17:37:57 -0700
In-Reply-To: <89a415b86d5421941e4281ba5bf6288934078624.camel@j-davis.com>
References: <E1q7j7Y-000z1H-Hr@gemulon.postgresql.org>
	 <89a415b86d5421941e4281ba5bf6288934078624.camel@j-davis.com>
Content-Type: multipart/mixed; boundary="=-PG/iEVP/ZWOKFd/pa642"
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/d20864b929ff769a0ebf772359719f05bb6982cd.camel%40j-davis.com>
Precedence: bulk

--=-PG/iEVP/ZWOKFd/pa642
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2023-06-09 at 15:16 -0700, Jeff Davis wrote:
> On Fri, 2023-06-09 at 20:54 +0000, Jeff Davis wrote:
> > Fix search_path to a safe value during maintenance operations.
>=20
> Looks like this is causing pg_amcheck failures in the buildfarm.
> Investigating...

It looks related to bt_index_check_internal(), which is called by SQL
functions bt_index_check() and bt_index_parent_check(). SQL functions
can be called in parallel, so it raises the error:

  ERROR:  cannot set parameters during a parallel operation

because commit 05e1737351 added the SetConfigOption() line. Normally
those functions would not be called in parallel, but
debug_parallel_mode makes that happen.

Attached a patch to mark those functions as PARALLEL UNSAFE, which
fixes the problem.

Alternatively, I could just take out that line, as those SQL functions
are not controlled by the MAINTAIN privilege. But for consistency I
think it's a good idea to leave it in so that index functions are
called with the right search path for amcheck.


--=20
Jeff Davis
PostgreSQL Contributor Team - AWS


--=-PG/iEVP/ZWOKFd/pa642
Content-Disposition: attachment;
	filename="v1-0001-amcheck-mark-bt_index_check-PARALLEL-UNSAFE.patch"
Content-Type: text/x-patch;
	name="v1-0001-amcheck-mark-bt_index_check-PARALLEL-UNSAFE.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSAwYmMxMWJiYzRiMDYyMjhkMzNiZDlmYzZiMjlkY2M5YTI1ZDgxMTUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBG
cmksIDkgSnVuIDIwMjMgMTc6MjQ6NTMgLTA3MDAKU3ViamVjdDogW1BBVENIIHYxXSBhbWNoZWNr
OiBtYXJrIGJ0X2luZGV4X2NoZWNrKCkgUEFSQUxMRUwgVU5TQUZFLgoKVGhlc2UgZnVuY3Rpb25z
IGNhbGwgYnRfaW5kZXhfY2hlY2tfaW50ZXJuYWwoKSwgd2hpY2ggbmVlZHMgdG8gc2V0IHRoZQpy
aWdodCBzZWFyY2ggcGF0aCBiZWZvcmUgZXhlY3V0aW5nIGFueSBpbmRleCBmdW5jdGlvbnMuCgpE
aXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tLzIwMjMwNjA5MjMyNDQ2LkdBMTIzNjI0QG5h
dGhhbnhwczEzCi0tLQogY29udHJpYi9hbWNoZWNrL01ha2VmaWxlICAgICAgICAgICAgICB8ICA0
ICsrKy0KIGNvbnRyaWIvYW1jaGVjay9hbWNoZWNrLS0xLjMtLTEuNC5zcWwgfCAxMyArKysrKysr
KysrKysrCiBjb250cmliL2FtY2hlY2svYW1jaGVjay5jb250cm9sICAgICAgIHwgIDIgKy0KIDMg
ZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKIGNyZWF0ZSBt
b2RlIDEwMDY0NCBjb250cmliL2FtY2hlY2svYW1jaGVjay0tMS4zLS0xLjQuc3FsCgpkaWZmIC0t
Z2l0IGEvY29udHJpYi9hbWNoZWNrL01ha2VmaWxlIGIvY29udHJpYi9hbWNoZWNrL01ha2VmaWxl
CmluZGV4IGI4MmYyMjFlNTAuLjQ4OTZjNTg2ZjggMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvYW1jaGVj
ay9NYWtlZmlsZQorKysgYi9jb250cmliL2FtY2hlY2svTWFrZWZpbGUKQEAgLTcsNyArNyw5IEBA
IE9CSlMgPSBcCiAJdmVyaWZ5X25idHJlZS5vCiAKIEVYVEVOU0lPTiA9IGFtY2hlY2sKLURBVEEg
PSBhbWNoZWNrLS0xLjItLTEuMy5zcWwgYW1jaGVjay0tMS4xLS0xLjIuc3FsIGFtY2hlY2stLTEu
MC0tMS4xLnNxbCBhbWNoZWNrLS0xLjAuc3FsCitEQVRBID0gYW1jaGVjay0tMS4zLS0xLjQuc3Fs
IGFtY2hlY2stLTEuMi0tMS4zLnNxbCBhbWNoZWNrLS0xLjEtLTEuMi5zcWwgXAorCWFtY2hlY2st
LTEuMC0tMS4xLnNxbCBhbWNoZWNrLS0xLjAuc3FsCisKIFBHRklMRURFU0MgPSAiYW1jaGVjayAt
IGZ1bmN0aW9uIGZvciB2ZXJpZnlpbmcgcmVsYXRpb24gaW50ZWdyaXR5IgogCiBSRUdSRVNTID0g
Y2hlY2sgY2hlY2tfYnRyZWUgY2hlY2tfaGVhcApkaWZmIC0tZ2l0IGEvY29udHJpYi9hbWNoZWNr
L2FtY2hlY2stLTEuMy0tMS40LnNxbCBiL2NvbnRyaWIvYW1jaGVjay9hbWNoZWNrLS0xLjMtLTEu
NC5zcWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uNDA5Y2Q1NTE5NQot
LS0gL2Rldi9udWxsCisrKyBiL2NvbnRyaWIvYW1jaGVjay9hbWNoZWNrLS0xLjMtLTEuNC5zcWwK
QEAgLTAsMCArMSwxMyBAQAorLyogY29udHJpYi9hbWNoZWNrL2FtY2hlY2stLTEuMy0tMS40LnNx
bCAqLworCistLSBjb21wbGFpbiBpZiBzY3JpcHQgaXMgc291cmNlZCBpbiBwc3FsLCByYXRoZXIg
dGhhbiB2aWEgQ1JFQVRFIEVYVEVOU0lPTgorXGVjaG8gVXNlICJBTFRFUiBFWFRFTlNJT04gYW1j
aGVjayBVUERBVEUgVE8gJzEuNCciIHRvIGxvYWQgdGhpcyBmaWxlLiBccXVpdAorCistLQorLS0g
TWFyayBidF9pbmRleF9jaGVjayBmdW5jdGlvbnMgYXMgUEFSQUxMRUwgVU5TQUZFLgorLS0KK0FM
VEVSIEZVTkNUSU9OIGJ0X2luZGV4X2NoZWNrKHJlZ2NsYXNzKSBQQVJBTExFTCBVTlNBRkU7CitB
TFRFUiBGVU5DVElPTiBidF9pbmRleF9jaGVjayhyZWdjbGFzcywgYm9vbGVhbikgUEFSQUxMRUwg
VU5TQUZFOworQUxURVIgRlVOQ1RJT04gYnRfaW5kZXhfcGFyZW50X2NoZWNrKHJlZ2NsYXNzKSBQ
QVJBTExFTCBVTlNBRkU7CitBTFRFUiBGVU5DVElPTiBidF9pbmRleF9wYXJlbnRfY2hlY2socmVn
Y2xhc3MsIGJvb2xlYW4pIFBBUkFMTEVMIFVOU0FGRTsKK0FMVEVSIEZVTkNUSU9OIGJ0X2luZGV4
X3BhcmVudF9jaGVjayhyZWdjbGFzcywgYm9vbGVhbiwgYm9vbGVhbikgUEFSQUxMRUwgVU5TQUZF
OwpkaWZmIC0tZ2l0IGEvY29udHJpYi9hbWNoZWNrL2FtY2hlY2suY29udHJvbCBiL2NvbnRyaWIv
YW1jaGVjay9hbWNoZWNrLmNvbnRyb2wKaW5kZXggYWI1MDkzMWY3NS4uZTY3YWNlMDFjOSAxMDA2
NDQKLS0tIGEvY29udHJpYi9hbWNoZWNrL2FtY2hlY2suY29udHJvbAorKysgYi9jb250cmliL2Ft
Y2hlY2svYW1jaGVjay5jb250cm9sCkBAIC0xLDUgKzEsNSBAQAogIyBhbWNoZWNrIGV4dGVuc2lv
bgogY29tbWVudCA9ICdmdW5jdGlvbnMgZm9yIHZlcmlmeWluZyByZWxhdGlvbiBpbnRlZ3JpdHkn
Ci1kZWZhdWx0X3ZlcnNpb24gPSAnMS4zJworZGVmYXVsdF92ZXJzaW9uID0gJzEuNCcKIG1vZHVs
ZV9wYXRobmFtZSA9ICckbGliZGlyL2FtY2hlY2snCiByZWxvY2F0YWJsZSA9IHRydWUKLS0gCjIu
MzQuMQoK


--=-PG/iEVP/ZWOKFd/pa642--