Message-ID: <d22ba3d9-357d-4357-aa16-ec77d134c26c@pgmasters.net>
Date: Sun, 28 Jan 2024 19:28:41 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add recovery to pg_control and remove backup_label
To: Michael Paquier <michael@paquier.xyz>, vignesh C <vignesh21@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>,
 Andres Freund <andres@anarazel.de>, Stephen Frost <sfrost@snowman.net>
References: <ZU2zbPwGwy5ammRm@paquier.xyz>
 <f4762790-efc4-4dd1-a3d0-02d183d9466c@pgmasters.net>
 <ZVGn6PY0LQ7RbDVL@paquier.xyz>
 <77ad92e7-3e37-40e2-8e3b-df3cf0108aa8@pgmasters.net>
 <ZVQfgWvoGDWm37J_@paquier.xyz>
 <fb5a0e35-0ac0-4265-b0fe-135638adecd0@pgmasters.net>
 <ZVVcZ2HooBnhld_z@paquier.xyz>
 <a1d77886-97ac-4ec3-8f5d-7f0d95cbdc1e@pgmasters.net>
 <ZVqzRSbi2feDhmf7@paquier.xyz>
 <CALDaNm0_yyfrpHXDZe-rwXnzBjiFUNsab_-YA=k2TTC-NT0bCA@mail.gmail.com>
 <ZbbfJIsGGR-DmmWW@paquier.xyz>
Content-Language: en-US
From: David Steele <david@pgmasters.net>
In-Reply-To: <ZbbfJIsGGR-DmmWW@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d22ba3d9-357d-4357-aa16-ec77d134c26c%40pgmasters.net>
Precedence: bulk

On 1/28/24 19:11, Michael Paquier wrote:
> On Fri, Jan 26, 2024 at 06:27:30PM +0530, vignesh C wrote:
>> Please post an updated version for the same.
>>
>> [1] - http://cfbot.cputube.org/patch_46_3511.log
> 
> With the recent introduction of incremental backups that depend on
> backup_label and the rather negative feedback received, I think that
> it would be better to return this entry as RwF for now.  What do you
> think?

I've been thinking it makes little sense to update the patch. It would 
be a lot of work with all the new changes for incremental backup and 
since Andres and Robert appear to be very against the idea, I doubt it 
would be worth the effort.

I have withdrawn the patch.

Regards,
-David