Message-ID: <d2d013bd-c13f-cb39-7b9c-d002617c8777@enterprisedb.com>
Date: Thu, 21 Jul 2022 18:19:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: Make name optional in CREATE STATISTICS
Content-Language: en-US
To: Dean Rasheed <dean.a.rasheed@gmail.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: 
 <CANbhV-FGD2d_C3zFTfT2aRfX_TaPSgOeKES58RLZx5XzQp5NhA@mail.gmail.com>
 <CAEze2WjCAo3s1TLWLNLr+rgGQri3+1=p+wtOEWquLzc2PGWHAg@mail.gmail.com>
 <CANbhV-GeeACF=v4+6+bvKbE9pEj0vgpDdJ+dFfNnRBoi2QZrEQ@mail.gmail.com>
 <CAEze2WhShe3BvKQZJC19=ER+WuicMPoW0kYCk7sZENimC39J0Q@mail.gmail.com>
 <CANbhV-HRr3nTNd1M_Tro5vXcdf1OSWTZVwgJO2Grr3S0bTmmGA@mail.gmail.com>
 <CAEze2Wh97rKj5-g+f-98MTiLRrz+teAcQuo7tv2EPt68YDAjVQ@mail.gmail.com>
 <CAEZATCW993Lt_bsT90VFMpxF-0s6aKw_4TesB_F5GqM8e1oP9A@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: 
 <CAEZATCW993Lt_bsT90VFMpxF-0s6aKw_4TesB_F5GqM8e1oP9A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d2d013bd-c13f-cb39-7b9c-d002617c8777%40enterprisedb.com>
Precedence: bulk

On 7/21/22 16:12, Dean Rasheed wrote:
> On Wed, 20 Jul 2022 at 12:01, Matthias van de Meent
> <boekewurm+postgres@gmail.com> wrote:
>>
>> On Wed, 13 Jul 2022 at 08:07, Simon Riggs <simon.riggs@enterprisedb.com> wrote:
>>>
>>>> + *                CREATE STATISTICS [ [IF NOT EXISTS] stats_name ]
>>
>> I think this is ready for a committer, so I've marked it as such.
>>
> 
> Picking this up...
> 
> I tend to agree with Matthias' earlier point about avoiding code
> duplication in the grammar. Without going off and refactoring other
> parts of the grammar not related to this patch, it's still a slightly
> smaller, simpler change, and less code duplication, to do this using a
> new opt_stats_name production in the grammar, as in the attached.
> 
> I also noticed a comment in CreateStatistics() that needed updating.
> 
> Barring any further comments, I'll push this shortly.
> 

+1


-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company