Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qf4BL-009QYk-Ku for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Sep 2023 20:03:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qf4BJ-003RYL-1t for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Sep 2023 20:03:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qf4BI-003RYD-Ne for pgsql-hackers@lists.postgresql.org; Sat, 09 Sep 2023 20:03:48 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qf4BA-0048Ic-DO for pgsql-hackers@postgresql.org; Sat, 09 Sep 2023 20:03:47 +0000 Received: from [10.5.0.2] (unknown [193.43.135.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 25E765466D for ; Sat, 9 Sep 2023 20:03:38 +0000 (UTC) Message-ID: Date: Sat, 9 Sep 2023 16:03:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: Add const qualifiers From: David Steele To: Pg Hackers References: <669a035c-d23d-2f38-7ff0-0cb93e01d610@pgmasters.net> Content-Language: en-US In-Reply-To: <669a035c-d23d-2f38-7ff0-0cb93e01d610@pgmasters.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 9/1/23 11:39, David Steele wrote: > Hackers, > > I noticed that there was a mismatch between the const qualifiers for > excludeDirContents in src/backend/backup/backup/basebackup.c and > src/bin/pg_rewind/file_map.c and that led me to use ^static const.*\*.*= > to do a quick search for similar cases. > > I think at the least we should make excludeDirContents match, but the > rest of the changes seem like a good idea as well. Added to 2023-11 CF. Regards, -David