Message-ID: <d2da2fd87bf3ba9500a11727fa52cab8c24555df.camel@j-davis.com>
Subject: Re: Built-in CTYPE provider
From: Jeff Davis <pgsql@j-davis.com>
To: Thomas Munro <thomas.munro@gmail.com>, Peter Eisentraut
	 <peter@eisentraut.org>
Cc: Daniel Verite <daniel@manitou-mail.org>, Robert Haas
 <robertmhaas@gmail.com>,  Jeremy Schneider <schneider@ardentperf.com>,
 pgsql-hackers@postgresql.org
Date: Thu, 04 Apr 2024 16:38:11 -0700
In-Reply-To: 
 <CA+hUKGK-ZqV1njkG_=xcCqXh2fcMkz85FTMnhS2opm4ZerH=xw@mail.gmail.com>
References: <6f3e94c0-f174-4380-9b69-072f8a838881@manitou-mail.org>
	 <2692039df6b0cac20c5e488fa0209e8958c5fedb.camel@j-davis.com>
	 <27bb0e52-801d-4f73-a0a4-02cfdd4a9ada@eisentraut.org>
	 <4a69d067374d2f6bfb66f5bfb2ab9a020493d49f.camel@j-davis.com>
	 <3bc653b5d562ae9e2838b11cb696816c328a489a.camel@j-davis.com>
	 <163f4e2190cdf67f67016044e503c5004547e5a9.camel@j-davis.com>
	 <6bdb98e68b2b05aa71f7f934e227738eac84ecee.camel@j-davis.com>
	 <19b34a70-f5cf-4faf-88dc-917db44ed48d@eisentraut.org>
	 <846a7e1fa2024918b58ff7583523a2f3de9a11b4.camel@j-davis.com>
	 <3117d30aa911b408b90420f4f280fa0c3b5851be.camel@j-davis.com>
	 <4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org>
	 <7451f81ba0cb512222ab759de8ca1cffe44e9acb.camel@j-davis.com>
	 <1f309153-8198-4efa-86dd-8c304ec0040c@eisentraut.org>
	 <a21b515000f121244db2a5570d4292d19df23379.camel@j-davis.com>
	 <a8804ef9-fda6-4660-9f98-ecd1315f958c@eisentraut.org>
	 <480c02813ee26e83e305d015be6a63059bb3ddd8.camel@j-davis.com>
	 <aadafbe2-b731-4009-bb9a-b2e55cf32c83@eisentraut.org>
	 <CA+hUKGK-ZqV1njkG_=xcCqXh2fcMkz85FTMnhS2opm4ZerH=xw@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-udBkuk039XPjDpC+AMcf"
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/d2da2fd87bf3ba9500a11727fa52cab8c24555df.camel%40j-davis.com>
Precedence: bulk

--=-udBkuk039XPjDpC+AMcf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2024-04-05 at 11:22 +1300, Thomas Munro wrote:
> Hi,
>=20
> +command_ok(
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 'initdb', '--no-sync',
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 '--locale-provider=3Dbuiltin', '-E UTF-8',
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 '--builtin-locale=3DC.UTF-8', "$tempdir/data8"
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ],
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'locale provider builtin with -E UT=
F-8 --builtin-
> locale=3DC.UTF-8');

...

> =C2=A0 LC_COLLATE:=C2=A0 en_US
> =C2=A0 LC_CTYPE:=C2=A0=C2=A0=C2=A0 en_US
> =C2=A0 LC_MESSAGES: C
> =C2=A0 LC_MONETARY: en_US
> =C2=A0 LC_NUMERIC:=C2=A0 en_US
> =C2=A0 LC_TIME:=C2=A0=C2=A0=C2=A0=C2=A0 en_US
> initdb: error: encoding mismatch
> initdb: detail: The encoding you selected (UTF8) and the encoding
> that
> the selected locale uses (LATIN1) do not match.

Thank you for the report.

I fixed it in e2a2357671 by forcing the environment locale to C which
is compatible with any encoding. The test still forces the encoding to
UTF-8 and the collation to the builtin C.UTF-8.

In passing, I noticed some unrelated regression test failures when I
set LANG=3Dtr_TR: tsearch, tsdict, json, and jsonb. There's an additional
failure in the updatable_views test when LANG=3Dtr_TR.utf8. I haven't
looked into the details yet.

Regards,
	Jeff Davis


--=-udBkuk039XPjDpC+AMcf
Content-Disposition: attachment;
 filename="v1-0001-Fix-test-failure-in-001_initdb.pl.patch"
Content-Type: text/x-patch;
 name="v1-0001-Fix-test-failure-in-001_initdb.pl.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSBhN2JmNThmMjdiY2Q2MGJmNzljMDk3YzdmNDYyZmExODMyNjRlOWNkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU
aHUsIDQgQXByIDIwMjQgMTU6NTU6MDMgLTA3MDAKU3ViamVjdDogW1BBVENIIHYxXSBGaXggdGVz
dCBmYWlsdXJlIGluIDAwMV9pbml0ZGIucGwuCgpSZXBvcnRlZC1ieTogVGhvbWFzIE11bnJvCkRp
c2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vQ0EraFVLR0stWnFWMW5qa0dfPXhjQ3FYaDJm
Y01rejg1RlRNbmhTMm9wbTRaZXJIPXh3QG1haWwuZ21haWwuY29tCi0tLQogc3JjL2Jpbi9pbml0
ZGIvdC8wMDFfaW5pdGRiLnBsIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr
KQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vaW5pdGRiL3QvMDAxX2luaXRkYi5wbCBiL3NyYy9iaW4v
aW5pdGRiL3QvMDAxX2luaXRkYi5wbAppbmRleCBjNjNkMzIwNmQ5Li5iMzFkYWQyNDY0IDEwMDY0
NAotLS0gYS9zcmMvYmluL2luaXRkYi90LzAwMV9pbml0ZGIucGwKKysrIGIvc3JjL2Jpbi9pbml0
ZGIvdC8wMDFfaW5pdGRiLnBsCkBAIC0yMDAsNiArMjAwLDcgQEAgY29tbWFuZF9vaygKIAlbCiAJ
CSdpbml0ZGInLCAnLS1uby1zeW5jJywKIAkJJy0tbG9jYWxlLXByb3ZpZGVyPWJ1aWx0aW4nLCAn
LUUgVVRGLTgnLAorCQknLS1sYy1jb2xsYXRlPUMnLCAnLS1sYy1jdHlwZT1DJywKIAkJJy0tYnVp
bHRpbi1sb2NhbGU9Qy5VVEYtOCcsICIkdGVtcGRpci9kYXRhOCIKIAldLAogCSdsb2NhbGUgcHJv
dmlkZXIgYnVpbHRpbiB3aXRoIC1FIFVURi04IC0tYnVpbHRpbi1sb2NhbGU9Qy5VVEYtOCcpOwpA
QCAtMjA4LDYgKzIwOSw3IEBAIGNvbW1hbmRfZmFpbHMoCiAJWwogCQknaW5pdGRiJywgJy0tbm8t
c3luYycsCiAJCSctLWxvY2FsZS1wcm92aWRlcj1idWlsdGluJywgJy1FIFNRTF9BU0NJSScsCisJ
CSctLWxjLWNvbGxhdGU9QycsICctLWxjLWN0eXBlPUMnLAogCQknLS1idWlsdGluLWxvY2FsZT1D
LlVURi04JywgIiR0ZW1wZGlyL2RhdGE5IgogCV0sCiAJJ2xvY2FsZSBwcm92aWRlciBidWlsdGlu
IHdpdGggLS1idWlsdGluLWxvY2FsZT1DLlVURi04IGZhaWxzIGZvciBTUUxfQVNDSUknCi0tIAoy
LjM0LjEKCg==


--=-udBkuk039XPjDpC+AMcf--