Message-ID: <d363c358-2c67-92bc-660f-ff82636c155f@enterprisedb.com>
Date: Tue, 25 Jan 2022 11:47:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: GUC flags
Content-Language: en-US
To: Justin Pryzby <pryzby@telsasoft.com>,
 Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org, bruce@momjian.us, tgl@sss.pgh.pa.us
References: <YbG7sp+2YEYgbY0D@paquier.xyz>
 <20211209155322.GG17618@telsasoft.com> <20211229023240.GM24477@telsasoft.com>
 <20220105.114757.369416916044334409.horikyota.ntt@gmail.com>
 <20220105030648.GE14051@telsasoft.com> <YdUp118ekFgGiixT@paquier.xyz>
 <20220105235517.GR14051@telsasoft.com> <YdZ7zCymonPV4//X@paquier.xyz>
 <20220106053641.GW14051@telsasoft.com> <20220125010729.GC23027@telsasoft.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220125010729.GC23027@telsasoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d363c358-2c67-92bc-660f-ff82636c155f%40enterprisedb.com>
Precedence: bulk

On 25.01.22 02:07, Justin Pryzby wrote:
> +CREATE TABLE pg_settings_flags AS SELECT name, category,
> +	'NO_SHOW_ALL'	=ANY(flags) AS no_show_all,
> +	'NO_RESET_ALL'	=ANY(flags) AS no_reset_all,
> +	'NOT_IN_SAMPLE'	=ANY(flags) AS not_in_sample,
> +	'EXPLAIN'	=ANY(flags) AS guc_explain,
> +	'COMPUTED'	=ANY(flags) AS guc_computed
> +	FROM pg_show_all_settings();

Does this stuff have any value for users?  I'm worried we are exposing a 
bunch of stuff that is really just for internal purposes.  Like, what 
value does showing "not_in_sample" have?  On the other hand, 
"guc_explain" might be genuinely useful, since that is part of a 
user-facing feature.  (I don't like the "guc_*" naming though.)

Your patch doesn't contain a documentation change, so I don't know how 
and to what extend this is supposed to be presented to users.